Distillation

Date: Sep 8, 2026

• 🔴 [requested-tests] (03:57) User asked to add focused regression tests in /home/byk/Code/opencode-v2-pilot for the current Promise permission adapter semantics, inspecting packages/core/test/plugin.test.ts, fixtures, the Tool service invocation API, and Permission errors.
• 🔴 (03:57) User required tests to exercise a real activated Promise plugin/tool and real host adapter for four cases, in order: 1. successful ctx.permission.assert remains successful; 2. typed Permission.CorrectedError({feedback}) becomes a model-facing Tool.Error whose message is exactly feedback, rather than a defect; 3. a defect remains a defect and is not converted; 4. plain DeclinedError should retain its established defect tunnel if practical.
• 🔴 [restricted-scope] (03:57) User required only necessary test/fixture changes and explicitly prohibited altering the adapter implementation.
• 🔴 (03:57) User required Effect v4 house style, existing testEffect, and package-local testing.
• 🔴 (03:57) User required running bun typecheck and focused tests from packages/core with --printConsoleTrace.
• 🔴 (03:57) User requested the final report include changed files, exact test results, and any mismatch in the current implementation.
• 🟡 (03:57) Assistant stated it would inspect repository guidance, current plugin tests and fixtures, the Tool invocation path, and Permission error definitions before adding only focused regression coverage and running package-local typecheck/tests.
• 🔴 (03:58) User’s repository testing rule: never run package tests from the repo root; run them from package directories such as packages/core.
• 🔴 (03:58) User’s type-checking rule: always run bun typecheck from package directories, for example packages/core; never run tsc directly.
• 🔴 (03:58) User’s runtime dependency rule: dependencies flow from Schema to Core and Protocol, then from Core and Protocol to Server; Client runtime code may depend on Schema and Protocol but never Core or Server; sdk composes Client, Core, and Server.
• 🔴 (03:58) User’s import rule: never alias imports; do not use forms such as import { foo as bar } from "..." or resolve as pathResolve.
• 🔴 (03:58) User’s import rule: never use type-position import("...") references such as Schema.declare<import("@opencode/plugin/effect/plugin").Plugin["effect"]>; only as a last resort when names genuinely collide may an aliased type import such as import type { Plugin as PluginDefinition } from "..." be used, though it remains strongly discouraged.
• 🔴 (03:58) User’s import rule also prohibits star imports such as import * as Foo from "..." and import type * as Foo from "..."; namespace-style values should use a module’s exported namespace by name, such as import { Project } from "@opencode/core/project" followed by Project.ID.
• 🔴 (03:58) User’s testing conventions: avoid mocks and globalThis.* unless it is the only option; test the actual implementation rather than duplicating logic in tests.
• 🔴 (03:58) User’s Effect testing conventions: use current Effect v4/effect-smol source and nearby repository patterns; prefer Effect.gen(function* () { ... }), existing testEffect(...), explicit layers, scoped fixtures/finalizers, and it.live(...) for real platform behavior.
• 🟡 (03:58) Existing packages/core/test/plugin.test.ts uses testEffect(PluginTestLayer), imports fromPromise from @opencode/plugin/promise/adapter, and already contains a test named "exposes canonical permission assertions to Promise plugins" that activates a promise-permission plugin, calls ctx.permission.assert(...), waits on a Deferred, and expects the plugin state to be "active".
• 🟡 (03:58) The existing canonical permission test uses sessionID: Session.ID.make("ses_plugin_permission"), action: "shell", resources: ["'true'"], and source { type: "tool", messageID: "msg_plugin_permission", id: "call_plugin_permission" }.
• 🟡 (03:58) Existing packages/core/test/plugin/fixture.ts defines permissionLayer with Permission.Service.of(...); its assert implementation is currently () => Effect.void, while ask returns { id: input.id ?? Permission.ID.create(), effect: "ask" }, and reply, get, forSession, and list are inert/empty test implementations.
• 🟡 (03:58) PluginTestLayer in packages/core/test/plugin/fixture.ts includes both Permission.node and Tool.node, and replaces Permission.node with permissionLayer.
• 🟡 (03:58) Initial Tool invocation search found tool.execute(decoded, context) in packages/core/src/tool/runtime.ts:36; unrelated execute(...) matches also appeared in packages/core/src/tool/plugin/webfetch.ts:75, packages/core/src/tool/plugin/webfetch.ts:135, and packages/core/src/tool/plugin/webfetch.ts:136.
• 🔴 (03:58) Repository rules state current implementation changes belong in packages/core, packages/cli, packages/server, packages/protocol, packages/schema, and related generated client surfaces when required; public Protocol or Server HttpApi changes require bun run generate from packages/client, and generated client files must not be edited directly.
• 🔴 (03:58) Repository rules state this repository does not use Changesets and .changeset files must not be added.