Distillation

Date: September 16, 2026

• 🔴 (13:24) User stated Lore tests use a temporary SQLite database through packages/core/test/setup.ts and must never use the production database at ~/.local/share/lore/lore.db.
• 🔴 (13:24) User stated releases use Sentry Craft through GitHub Actions; versions and CHANGELOG.md must never be edited manually because Craft handles both automatically.
• 🔴 (13:24) User documented release commands: gh workflow run release.yml -f version=auto uses conventional commits to determine semver, while gh workflow run release.yml -f version=0.23.0 requests an explicit version.
• 🔴 (13:24) User documented the 6-step release workflow: 1. scripts/bump-version.sh updates all package.json versions; 2. changelog is generated from conventional commit messages; 3. a release/X.Y.Z branch is created and pushed; 4. CI tests and builds npm tarballs, standalone binaries, and delta patches; 5. Craft opens a publish issue and the Publish workflow runs when it is labeled accepted; 6. publishing uses npm OIDC trusted publishing and creates a GitHub Release with binaries and patches. .craft.yml defines targets for 4 npm workspaces, the legacy opencode-lore alias, and the GitHub Release.
• 🔴 (13:24) User stated every adversarial-review defect must receive a deterministic regression test in the same PR that fails on the base branch, passes with the fix, and drives the real precondition; a guard test must fail if the guard is removed.
• 🔴 (13:24) User stated adversarial test setup must reproduce real lifecycle order: state already exists before the handling operation, delete-then-recreate occurs across lifecycle boundaries, and content can be modified while sync is disabled.
• 🔴 (13:24) User stated fan-out additions require corresponding parametrized contract coverage: SYNCED_TABLES via packages/core/test/sync-registry-contract.test.ts; MIGRATIONS via the db.test.ts schema-version assertion plus migration-specific tests; and AGENTS via agents.test.ts, including name, displayName, binary, detect(), and a constant placeholder string for binary.
• 🔴 (13:24) User stated skip and early-return branches are the highest-risk correctness surface; guards such as NOT EXISTS, latest <> 'upsert', and content matching previously masked data-loss bugs, so each skip branch needs a test that makes it skip something incorrectly and proves that it does not.
• 🔴 (13:24) User stated property-based tests over faithful mocks are preferred for sequence-dependent bugs; the #833 property battery found 4 sync-engine bugs missed by example tests across enable/disable/push/pull boundaries.
• 🔴 (13:24) User requires failing-first TDD for bug fixes: write the regression test first, confirm it fails on the base branch, then confirm it passes after the fix; never trust a fix without seeing the test fail first.
• 🔴 (13:24) User stated memoized arrays shared by multiple callers should be frozen so accidental mutation throws a TypeError in strict mode rather than silently corrupting shared cache state, as with the syncedColumns PRAGMA cache.
• 🔴 (13:24) User stated db().query monkeypatches are shadowed by the tracing Proxy; SQL-counting tests must use the log.registerSink({ withDbSpan }) seam because assigning db().query = ... is silently ignored, as empirically verified in #874.
• 🔴 [requested-review] (13:24) User requires 2 distinct review passes for non-trivial changes: 1. adversarial/correctness review covering enumerated break states, apply-then-revert mutants, property-test stability across 10 runs, hash-equivalence proofs, frozen-array mutation safety, and stale-cache analysis; 2. security/pentest review covering injection vectors, credential leaks, protocol-level attacks, and privilege escalation. Adversarial review is mandatory before merge; security review depends on the risk profile.
• 🔴 [requested-review] (13:24) User requires reviewers to run pnpm test, pnpm run typecheck, pnpm run lint, and pnpm run format:check; inspect exit codes because a blank output tail can conceal lint or format failure; verify property tests over 10 runs; hash-verify that the working tree is unmodified afterward; and provide per-point PASS / FAIL / CONCERN / MUST-FIX verdicts with file:line evidence plus an overall MERGE / DO-NOT-MERGE verdict rather than an unstructured “LGTM.”
• 🔴 (13:24) User stated changes to correctness-critical paths—including the sync engine, hashing, lifecycle, and migrations—require adversarial review regardless of size; mechanical or test-only PRs may skip it at reviewer discretion.
• 🔴 (13:24) User documented core development commands: pnpm install, pnpm test, pnpm run typecheck, pnpm run lint, pnpm run lint:fix, pnpm run format, pnpm run format:check, and pnpm run build.
• 🔴 (13:25) User’s current jj working copy is change tmzmtlss at commit e6d0f1edc8504c79ef3a6baacb1d74e4908e116b, description fix(core): correct embedding runtime selection and admission, based on change pxrvwsvv at commit 2cbf40060c67df229731cf1b9e34d5bf22ec2145, main, description feat(cch): add seeds for Claude Code up to 2.1.272 (#1780).
• 🔴 (13:25) User’s current working copy has 18 changed files totaling 1,818 insertions and 90 deletions: added packages/core/src/cgroup-memory.ts and packages/core/test/cgroup-memory.test.ts; modified packages/core/src/embedding/local.ts, packages/core/src/embedding/pool.ts, packages/core/src/embedding-cap.ts, packages/core/src/embedding-worker-types.ts, packages/core/src/embedding-worker.ts, packages/core/src/embedding.ts, packages/core/src/ort-native.ts, packages/core/test/embedding-cap.test.ts, packages/core/test/embedding-pool-memory.test.ts, packages/core/test/embedding-pool.test.ts, packages/core/test/embedding-worker-types.test.ts, packages/core/test/ort-native.test.ts, packages/gateway/script/bundle.ts, packages/gateway/script/ort-platform-package.ts, packages/gateway/test/bundle-exports.test.ts, and packages/gateway/test/ort-platform-package.test.ts.
• 🔴 (13:25) User’s repository reported a conflicting bookmark named fix/responses-private-references; jj suggested inspecting it with jj bookmark list and resolving it with jj bookmark set <name> -r <rev>.
• 🔴 (13:25) User stated native ONNX Runtime package resolution is fail-closed and must never interrupt WASM fallback; an unresolvable package is an expected dist-only case and resolution must never throw.
• 🔴 (13:25) User stated source-workspace native ONNX Runtime resolution must inspect only the worker package’s own node_modules and must never select an arbitrary package from elsewhere.
• 🔴 (13:25) User documented that native ONNX Runtime thread selection must account for container CPU constraints rather than blindly using host logical-core count from os.cpus(), because a 1-vCPU container on a 32-core host could otherwise spawn approximately 32 native threads, each with its own memory arena.
• 🔴 (13:25) User’s gateway package @loreai/gateway is version 0.40.0, requires Node.js >=22.15, depends on onnxruntime-node 1.27.0 as a dev dependency, and publishes dist/embedding-worker.cjs, dist/embedding-worker.js, dist/ort-wasm-simd-threaded.mjs, and dist/ort-wasm-simd-threaded.wasm among its package files.