Distillation

Date: Sep 16, 2026

• 🟡 [requested-review] (22:35) User requested an independent, read-only, adversarial correctness review of immutable provider candidate /home/byk/Code/opencode-lore-provider-error, stable change qzwttkwltwzr, commit 493b0655a388, base 2cbf40060c67, expected cumulative plain-diff SHA-256 93617337752dee74776c2fb173d829f37c6616727fa72268f07c8c8f2f195422, six declared files, and clean child qnmstlol.
• 🔴 (22:35) User stated repo-setup is unavailable and instructed the reviewer to read repository guidance/scripts.
• 🔴 (22:35) User required the review to make no edits, formatting changes, dependency installations, VCS mutations, network access, server launches, or production-database access.
• 🔴 (22:35) User required repository integrity verification at both the start and end of the review.
• 🔴 (22:35) User required inspection of all changed lines, callers, and tests across aliases, trusted metadata, source sequence, in-progress projection, failure prevalidation, usage/accounting, cancellation/backpressure, retries, rollback/persistence, and fixed logging and throwing sinks.
• 🔴 (22:35) User required validation of fail-first and mutation discrimination, including sink containment.
• 🔴 (22:35) User reported supplied validation results: 445 focused tests, 661 integration tests, 30 repeated runs, and static/bundle checks were green.
• 🔴 (22:35) User stated the prior parent correctness review concluded MERGE, but the newer head still requires review.
• 🔴 (22:35) User said focused tests should be run only if useful.
• 🔴 (22:35) User required exact HEAD line references and a structured verdict using PASS, CONCERN, MUST-FIX, and residual risks.
• 🔴 (22:35) User requires review findings to be never warning-only; use lore fallback.
• 🔴 (22:35) User required the review response to end exactly with either MERGE or DO-NOT-MERGE.
• 🔴 (22:36) Repository /home/byk/Code/opencode-lore-provider-error contains both .jj/ and .git/, making it a colocated Jujutsu/Git repository; mutations must use jj.
• 🔴 (22:36) User/project guidance states jj never fails on conflict: conflicts are recorded in the resulting commit and must be checked with jj st after rebase, new, or squash, then resolved manually rather than with interactive jj resolve.
• 🔴 (22:36) Project runtime is Node.js >= 22.5; it is a TypeScript monorepo using pnpm workspaces.
• 🔴 (22:36) Project database is SQLite in WAL mode with FTS5 full-text search, stored at ~/.local/share/lore/lore.db.
• 🔴 (22:36) Tests use a temporary SQLite database configured via packages/core/test/setup.ts, never the production DB.
• 🔴 (22:36) Every non-trivial PR requires an adversarial correctness review before merge under quality/REVIEW.md.
• 🔴 (22:36) Releases use Sentry Craft through GitHub Actions; never manually bump versions or edit CHANGELOG.md, because Craft handles both automatically.
• 🟡 (22:36) Release commands documented by the project are gh workflow run release.yml -f version=auto for conventional-commit-derived semver and gh workflow run release.yml -f version=0.23.0 for an explicit version.
• 🔴 (22:45) Project regression-test discipline requires a bug regression test to fail on the base branch, proving reproduction, and pass with the fix; tests of guards must fail when the guard is deleted.
• 🔴 (22:45) User/project guidance states: “Never trust the fix without seeing it fail.”
• 🔴 (22:45) Project review workflow requires enumerated cases, apply-then-revert mutants, property-test stability across 10 runs, exact evidence, and an overall MERGE or DO-NOT-MERGE verdict; unstructured “LGTM” is not acceptable.