Distillation

Date: Sep 8, 2026

• 🟡 (03:21) Bash reproduction showed that continue executed outside a for, while, or until loop emits bash: line 1: continue: only meaningful in a \for', `while', or `until' loop; a second reproduction printed one, two, and status=0`, confirming the error does not automatically skip subsequent commands.
• 🟡 (03:22) Working tree had modified files: .github/workflows/ci-poller.yml, .github/workflows/publish.yml, docs/publish-issue-format.md, scripts/generate-publish-issue-title-parser.js, src/modules/__tests__/details-from-context.js, src/modules/__tests__/publish-workflow.js, src/modules/__tests__/release-revision.js, src/modules/details-from-context.js, src/modules/publish-issue-title.js, src/modules/publish-issue-title.peggy, src/modules/release-revision.js, src/publish/inputs.js, src/publish/resolve-ci-poller-input.js, src/publish/resolve-location.js, and src/publish/resolve-release-revision.js; untracked paths were src/modules/__tests__/generate-publish-issue-title-parser.js, src/publish/__tests__/, and src/publish/discover-location.js.
• 🟡 (03:22) Direct invocation of updateReleaseRevision() in /home/byk/Code/getsentry/publish-workspace-acceptance/src/modules/release-revision.js:40 threw Error: Release revision must be a lowercase 40-character SHA. under Node.js v24.0.0.
• 🟡 (03:23) Generated parser src/modules/publish-issue-title.js exports StartRules: ["PublishIssueTitle", "ReleaseRevision", "CheckRunsLinkCount"], SyntaxError: peg$SyntaxError, and parse: peg$parse.
• 🟡 (03:23) Assistant audit found a critical CI-poller control-flow bug: .github/workflows/ci-poller.yml:95-102 executes each iteration in a subshell, while error paths at :105-109 and :152-160 use continue; since the subshell itself has no loop, Bash rejects continue and then continues executing rather than skipping the enclosing while iteration.
• 🟡 (03:23) Assistant determined the CI-poller bug can clear an issue body: on update-resolver or JSON-decoding failure, updated_body_file remains empty (.github/workflows/ci-poller.yml:151,157-160) but execution reaches gh issue edit --body-file "$updated_body_file" at :162, potentially replacing the issue body with an empty file. Assistant classified this as DO-NOT-MERGE.
• 🟡 (03:23) Assistant audit found a major generated-documentation validation gap: scripts/generate-publish-issue-title-parser.js:27-38 finds/replaces only the first generated-marker pair, so two valid generated blocks can pass --check if both match; src/modules/__tests__/generate-publish-issue-title-parser.js:7-14 tests missing markers only and does not cover duplicate or malformed marker pairs.
• 🟡 (03:23) Assistant contract audit marked body-start canonical RequestHeader as passing: src/modules/publish-issue-title.peggy:39-47 requires Requested by at offset zero and ordered header fields.
• 🟡 (03:23) Assistant contract audit marked exact repository binding as passing: src/modules/release-revision.js:25-29 requires the parsed check-runs-link repository to exactly equal the title repository.
• 🟡 (03:23) Assistant contract audit marked lowercase 40-hex SHA validation and optional terminal /checks/ slash handling as passing: grammar at src/modules/publish-issue-title.peggy:46,50-55; replacement validation at src/modules/release-revision.js:3-5,38-41.
• 🟡 (03:23) Assistant contract audit marked global duplicate View check runs detection as passing: whole-body counting precedes header parsing in src/modules/release-revision.js:7-14, with a global scanner in src/modules/publish-issue-title.peggy:58-62.
• 🟡 (03:23) Assistant contract audit marked canonical merge-target authority and documented grammar as passing: merge target is sourced only from the parsed request header in src/modules/details-from-context.js:54-57; grammar/docs agree at src/modules/publish-issue-title.peggy:81-83 and docs/publish-issue-format.md:93-94.
• 🟡 (03:23) Assistant contract audit marked revision updates as preserving all bytes outside the indexed SHA: src/modules/release-revision.js:43-44 performs indexed replacement only.
• 🟡 (03:23) Assistant contract audit marked issue-body trailing-newline handling and temp cleanup as passing in intended paths: .github/workflows/ci-poller.yml:103,157-160 use jq -j for raw body/result and :99-102 has a trap for all three temporary files; the continue control-flow bug still prevents this from being safe on error paths.
• 🟡 (03:23) Assistant contract audit marked trigger/gating invariants and manual recovery as passing: .github/workflows/ci-poller.yml:3-24 preserves workflow_dispatch and its gate; .github/workflows/publish.yml:108-114 requires fresh ci-ready with accepted status and no pending or failed checks.
• 🟡 (03:23) Assistant contract audit marked checkout-version requirement as passing at the changed poller checkout site: .github/workflows/ci-poller.yml:51-54 uses actions/checkout@v7.
• 🟡 (03:23) Assistant contract audit marked exact-SHA checkout followed by root .craft.yml discovery and fail-closed behavior as passing: .github/workflows/publish.yml:138-174 checks out the SHA before discovery; src/publish/discover-location.js:14-42 checks root configuration and rejects invalid output.
• 🟡 (03:23) Assistant contract audit marked use of intentional getsentry/craft:latest as passing: both discovery (src/publish/discover-location.js:27) and publication (.github/workflows/publish.yml:231) use latest.
• 🟡 (03:23) Assistant contract audit marked JSON handoff and Action serialization as passing: src/publish/inputs.js:9 and src/publish/resolve-location.js:14-22 serialize JSON; .github/workflows/publish.yml:165,182-185 consumes it using fromJSON.
• 🟡 (03:23) Assistant contract audit marked Peggy/parser/docs parity as passing because yarn test ran check:generated and src/modules/publish-issue-title.js:1469-1473 exports required start rules; duplicate generated-documentation markers remain a failure.
• 🟡 (03:23) Assistant contract audit marked CocoaPods and unrelated churn as passing: no CocoaPods or lockfile changes were present and git diff --check passed.
• 🟡 (03:23) Assistant required regression coverage for resolver failure and JSON-extraction failure at workflow level, proving no gh issue edit executes and all temporary files are removed.
• 🟡 (03:23) Assistant required byte-for-byte revision-replacement tests covering CRLF, trailing newlines, and decoy text; current src/modules/__tests__/release-revision.js:127-134 test checks only toContain.
• 🟡 (03:23) Assistant required parser regressions for uppercase input SHA, non-40-character input SHA, /checks//, and any prefix before Requested by.
• 🟡 (03:23) Assistant required rejection tests for duplicate generated-documentation marker blocks.
• 🟡 (03:23) Assistant reported read-only verification passed: yarn test with 86 tests, yarn lint, and git diff --check.