Distillation

Date: Sep 15, 2026

• 🔴 (22:02) User directed that package tests must never be run from the repository root; tests should be run from the relevant package directory.
• 🔴 [requested-bug-fix] (22:02) User requested implementation of the confirmed post-promotion retry scheduling bug in /home/byk/Code/opencode, without recall, while preserving unrelated files and performing no commit, build, service operation, or full-suite run.
• 🔴 (22:02) User specified the failing sequence: prompt A is promoted; prompt B is admitted with resume:false; an exact retry of A with resume:true causes SessionInput.requestExecution to no-op because A is promoted, but SessionV2.prompt unconditionally calls execution.wake(), allowing the runner to promote B.
• 🔴 (22:02) User specified the new internal contract: SessionInput.admit must return both the admitted row and whether the current invocation should issue the advisory wake; SessionV2.prompt must call execution.wake() only when shouldWake is true.
• 🔴 (22:02) User specified exact wake semantics: 1. new prompt with requestExecution=true durably projects wake_pending=true and returns shouldWake=true; 2. new resume:false returns false; 3. exact unpromoted retry upgrading false→true via durable PromptExecutionRequested returns true; 4. exact input already having wake_pending=true may return true to re-drive the advisory wake; 5. exact promoted input returns false even with resume:true; 6. conflicts fail before mutation or wake; 7. defect, idempotence, and concurrent paths derive shouldWake from durable stored state and never wake promoted input.
• 🔴 [requested-tests] (22:02) User requested a deterministic regression for “A promoted + B resume:false + retry A resume:true,” proving no execution wake occurs and B remains unpromoted, plus direct semantics coverage if needed.
• 🔴 (22:02) User requested only focused Core tests and Core typecheck, with exact changed files and results reported.
• 🟡 (22:03) Investigation confirmed the root cause in packages/core/src/session.ts: after SessionInput.admit(...), SessionV2.prompt called execution.wake(admitted.sessionID) whenever input.resume !== false, independently of whether the admitted input had already been promoted.
• 🟡 (22:03) Investigation confirmed the prior behavior in packages/core/src/session/input.ts: an exact existing admission invoked requestExecution(...) when requested but returned only the existing Admitted; requestExecution returned without signaling a result when promoted_seq was non-null or wake_pending was already true.
• 🟡 (22:05) Implemented the new SessionInput.admit result contract in packages/core/src/session/input.ts as { admitted, shouldWake }. Existing exact admissions now calculate shouldWake through durable execution state; new admissions return the admitted value plus wake eligibility.
• 🟡 (22:05) Changed SessionInput.requestExecution in packages/core/src/session/input.ts to return false for a promoted row, true for an unpromoted row already having wake_pending=true, and after publishing deterministic event ID evt_prompt_execution_${input.id}, re-read durable state to determine whether execution remains pending.
• 🟡 (22:05) Added SessionInput.executionPending in packages/core/src/session/input.ts; it reads session_id, promoted_seq, and wake_pending, dies with SessionInput.LifecycleConflict for a missing or mismatched row, and returns promoted_seq === null && wake_pending.
• 🟡 (22:05) Updated the admission defect/idempotence path in packages/core/src/session/input.ts: it re-reads the stored row, checks equivalence before execution mutation, returns shouldWake:false when execution was not requested, and otherwise derives the result through requestExecution.
• 🟡 (22:05) Updated packages/core/src/session.ts so SessionV2.prompt receives the admission object, performs prompt equivalence against admission.admitted, and calls execution.wake(...) only when admission.shouldWake is true.
• 🟡 (22:05) Updated direct SessionInput.admit call sites in packages/core/test/session-runner.test.ts and packages/core/test/session-projector.test.ts to use the new { admitted, shouldWake } return shape where the admitted row is needed.
• 🟡 (22:06) Added regression/semantics coverage in packages/core/test/session-prompt.test.ts for the revised wake contract, including the promoted-A/pending-B retry scenario requested by the user.
• 🟡 (22:06) Initial focused packages/core/test/session-prompt.test.ts run completed with 5 pass, 24 filtered out, 0 fail, and 24 expect() calls in 1.68s.
• 🟡 (22:07) Broader focused Core testing across 3 files completed with 153 pass, 0 fail, and 466 expect() calls in 10.51s.
• 🟡 (22:07) Initial Core tsgo --noEmit failed at src/session/input.ts:80 with TS18048: 'event.durable' is possibly 'undefined'.
• 🟡 (22:07) Fixed the TS18048 durable-event narrowing issue in packages/core/src/session/input.ts.
• 🟡 (22:08) After the type fix, focused Core testing across 3 files completed with 153 pass, 0 fail, and 466 expect() calls in 12.21s; the following tsgo --noEmit completed successfully.
• 🟡 (22:09) Final focused Core verification across 3 files completed with 153 pass, 0 fail, and 466 expect() calls in 11.50s; final tsgo --noEmit completed successfully.
• 🟡 (22:09) Files changed for the fix were packages/core/src/session/input.ts, packages/core/src/session.ts, packages/core/test/session-runner.test.ts, packages/core/test/session-projector.test.ts, and packages/core/test/session-prompt.test.ts.