Distillation

Date: Sep 16, 2026

• 🔴 [enforced-workflow] (13:23) User’s repository instructions require tests to run from package directories such as packages/core, never from the repository root because of the do-not-run-tests-from-root guard.
• 🔴 [enforced-workflow] (13:23) User requires type checking with bun typecheck from package directories (for example, packages/core) and never with tsc directly.
• 🔴 (13:23) User’s required runtime dependency direction is Schema → Core and Protocol, then Core and Protocol → Server. Client runtime code may depend on Schema and Protocol but never Core or Server; sdk-next composes Client, Core, and Server.
• 🔴 [corrected-style] (13:23) User requires never aliasing imports; prohibited forms include import { foo as bar } from "..." and renamed imports such as resolve as pathResolve.
• 🔴 [corrected-style] (13:23) User requires never using star imports; prohibited forms include import * as Foo from "..." and import type * as Foo from "...". Namespace-style values must use a module’s named exported namespace, such as import { Project } from "@opencode-ai/core/project" followed by Project.ID.
• 🔴 (13:23) User’s repository instructions prefer dynamic imports for heavy modules needed only in selected paths, with bindings destructured near the top of the narrowest applicable scope; inline chains such as await import("./module").then((mod) => mod.value()) and (await import("./module")).value() are disallowed, and branch-specific imports should remain inside their branch.
• 🔴 (13:23) User’s repository instructions establish dev as the default branch; local main may not exist, so diffs should use dev or origin/dev.
• 🔴 (13:23) User’s repository instructions require short branch names of at most 3 hyphen-separated words, without slashes or type prefixes such as feat/ or fix/.
• 🔴 (13:23) User’s repository instructions require conventional commit-style messages and PR titles in type(scope): summary form, with valid types feat, fix, docs, chore, refactor, and test.
• 🔴 (13:23) User’s repository testing rules say to avoid mocks where possible, avoid globalThis.* unless it is the only option, test actual implementations, and not duplicate implementation logic in tests.
• 🟡 (13:23) Review-tree package metadata: /tmp/opencode/session-recovery-review-v5-49183f9e/packages/core/package.json defines package @opencode-ai/core version 1.18.30; its test script is bun test --only-failures, and its typecheck script is tsgo --noEmit.
• 🟡 (13:23) The latest source regression tests were located at /home/byk/Code/opencode/packages/core/test/session-runner.test.ts: keeps a provider defect after Step finish unknown at line 2037, keeps provider failure unknown until unresolved tools are durable at line 2060, and retains the claim after Step interruption until runner finalizers finish at line 3661.
• 🟡 (13:23) The latest source regression test never wakes work settled between selection and redrive CAS was located at /home/byk/Code/opencode/packages/core/test/session-projector.test.ts:711.
• 🟡 (13:24) Investigation found the latest /home/byk/Code/opencode/packages/core/test/session-runner.test.ts contains a minimal runner-finalizer harness absent from the rejected v5 copy: let runnerFinalizer = Effect.void at line 75; Effect.ensuring(Effect.suspend(() => runnerFinalizer)) wrapping sessionRunner.run(...) at line 251; reset runnerFinalizer = Effect.void at line 359; and test assignment runnerFinalizer = Deferred.succeed(finalizerStarted, undefined).pipe(Effect.andThen(Deferred.await(releaseFinalizer))) at line 3669.
• 🟡 (13:24) In rejected v5’s /tmp/opencode/session-recovery-review-v5-49183f9e/packages/core/test/session-runner.test.ts, SessionExecutionLocal.make(...) directly uses run: (claim, force, recoveryInputID) => sessionRunner.run({ ...claim, force, recoveryInputID }) at line 248 and its setup block has no runnerFinalizer reset, confirming that the latest runner-finalizer test harness had not yet been overlaid.
• 🟡 (13:24) The latest source /home/byk/Code/opencode/packages/core/test/session-runner.test.ts had 4,191 lines, while rejected v5’s /tmp/opencode/session-recovery-review-v5-49183f9e/packages/core/test/session-runner.test.ts had 4,056 lines before the requested test-only overlay.