Distillation

Date: Sep 17, 2026

• 🔴 (09:47) User requires reconcileEmbedCap() to never re-probe up to or past a persisted knownBadCap on a memory-rich reboot; the hard ceiling is knownBadCap - 1.
• 🔴 (09:47) User requires knownBadCap to act only as a ceiling and never raise a lower trusted learned cap; knownBadCap=0 means none learned and imposes no ceiling.
• 🟡 (09:47) packages/core/test/embedding-cap.test.ts verifies reconcileEmbedCap(4 * GB, stored, 4000, 3000) === 2999, preserves a trusted cap of 1500 below the ceiling, and verifies reprobeEmbedCap(2000, 64 * GB, 2400) === 2399.
• 🟡 (09:47) Embedding-cap persistence uses knownBadCap?: number in packages/core/src/embedding-cap.ts and packages/core/src/embedding/local.ts; EmbeddingPool seeds lastOomCap from persisted knownBadCap, updates it with Math.max(this.lastOomCap, capBefore) after OOM, and persists it alongside the lowered/re-probed cap.
• 🔴 (09:48) User’s repository is colocated Jujutsu/Git (.jj/ and .git/); mutations must use jj, while Git is limited to read-only operations or unsupported tasks.
• 🔴 (09:48) User requires the Jujutsu invariant that operations never fail on conflict: rebase, new, and squash record conflicts in the resulting commit, after which jj st must be checked and files resolved manually rather than with interactive jj resolve.
• 🔴 (09:48) User’s Jujutsu workflow forbids interactive flags, requires -m "msg" for describe/commit operations, prefers stable change IDs over rewritten commit IDs, and requires verifying mutations with jj st and jj log.
• 🔴 (09:48) User’s review discipline requires every defect found by adversarial review to land with a deterministic regression test that fails on the base branch, passes on the fix, and drives the real precondition; a guard test must fail when the guard is removed.
• 🔴 [requested-tests] (09:48) User requires adversarial-order regression setup: state must already exist before the operation that handles it; lifecycle tests must cover delete-then-recreate while sync is OFF followed by re-enable; and tests must cover modify-while-off when capture triggers cannot observe the change.
• 🔴 [requested-tests] (09:48) User requires fan-out registry additions to run their contract batteries: SYNCED_TABLES → packages/core/test/sync-registry-contract.test.ts; MIGRATIONS → db.test.ts with toBe(MIGRATIONS.length) plus migration-specific tests; AGENTS → agents.test.ts validating name, displayName, binary, and detect(), with binary a constant placeholder string.
• 🔴 (09:48) User considers skip/early-return branches the highest-risk surface; every NOT EXISTS, latest <> 'upsert', content-match, or equivalent skip branch needs a test that makes it skip something incorrectly and proves the defect is prevented.
• 🔴 (09:48) User mandates failing-first TDD for bug fixes: “Never trust the fix without seeing it fail.”
• 🔴 (09:48) User requires two distinct review passes for non-trivial changes: 1. adversarial/correctness review covering breakable state, apply-then-revert mutants, property stability ×10, hash equivalence, frozen-array mutation safety, and stale-cache analysis; 2. security/pentest review covering injection, credential leaks, protocol attacks, and privilege escalation.
• 🔴 [requested-review] (09:48) User requires reviewers to run pnpm test, pnpm run typecheck, pnpm run lint, and pnpm run format:check; verify property tests over 10 runs; hash-verify an unmodified working tree; and report per-point PASS / FAIL / CONCERN / MUST-FIX verdicts with file:line evidence plus an overall MERGE / DO-NOT-MERGE decision.
• 🔴 (09:48) User requires adversarial review before merge for correctness-critical sync-engine, hashing, lifecycle, and migration changes; mechanical or test-only changes may skip it at reviewer discretion, while security review is determined by risk profile.
• 🟡 (09:48) Current Jujutsu log showed change tmzmtlsspstn at commit 6a5b70c9ee77 with description fix(core): correct embedding runtime selection and admission, based on pxrvwsvvkmpo / 2cbf40060c67 (feat(cch): add seeds for Claude Code up to 2.1.272 (#1780)); the linked Git worktree HEAD still contained full parent commit 2cbf40060c67df229731cf1b9e34d5bf22ec2145.
• 🟡 (09:49) The embedding-runtime change spans exactly 20 files with 2081 insertions(+) and 205 deletions(-): packages/core/src/cgroup-memory.ts, packages/core/src/embedding/local.ts, packages/core/src/embedding/pool.ts, packages/core/src/embedding-cap.ts, packages/core/src/embedding-worker-types.ts, packages/core/src/embedding-worker.ts, packages/core/src/embedding.ts, packages/core/src/ort-native.ts, packages/core/test/cgroup-memory.test.ts, packages/core/test/embedding-cap.test.ts, packages/core/test/embedding-pool-memory.test.ts, packages/core/test/embedding-pool.test.ts, packages/core/test/embedding-wasm-fallback.test.ts, packages/core/test/embedding-worker-stdio.test.ts, packages/core/test/embedding-worker-types.test.ts, packages/core/test/ort-native.test.ts, packages/gateway/script/bundle.ts, packages/gateway/script/ort-platform-package.ts, packages/gateway/test/bundle-exports.test.ts, and packages/gateway/test/ort-platform-package.test.ts.
• 🔴 (09:49) User requires the adaptive embedding cap never to exceed the Nomic v1.5 maximum sequence length represented by EMBED_TOKEN_CEILING.
• 🔴 (09:49) User set EMBED_BACKOFF_FACTOR = 0.7, EMBED_REPROBE_RATIO = 1.3, and EMBED_CAP_TRUST_BAND = 0.25.
• 🔴 (09:49) User requires no upward embedding-cap re-probe when free memory never improves enough to cross EMBED_REPROBE_RATIO; in that condition it must never re-probe.
• 🟡 (09:49) packages/core/src/embedding-cap.ts also defines BACKFILL_FULLSPEED_CORES = 8; its cap model clamps estimates into [MIN_EMBED_TOKENS, MODEL_MAX_TOKENS] and accounts for the npm/WASM path’s fixed 4 GiB heap and transient O(L²) attention allocation.