Distillation

["faf91225e56ca863c4f87fea070c8f3f","13840c99aab89dc90b4308450292d93a","bdea97f36db72cedd2ea1d7bbccfed61","4737a3beb26bbc2e0565a843d21d2ccf"]

<observations> Date: Aug 4, 2026 * 🟡 (21:13) Grep across getsentry repo found 12 `connect` matches: sentry/signals.py:58 (BetterSignal.connect), workflow_engine/defaults/workflows.py:25 (connect_workflows_to_issue_stream), workflow_engine/endpoints/validators/utils.py:156/204 (connect_workflows_to_detectors, connect_detectors_to_workflows), testutils/hybrid_cloud.py:81/88 (connection_transaction_depth_above_watermark, connections_above_watermark), net/http.py:262 (connection_from_url), services/filestore/s3.py:330 (connection property), integrations/perforce/p4protocol/protocol.py:261/325 (connect, connected), hybridcloud/outbox/category.py:78/100 (connect_cell_model_updates, connect_control_model_updates) * 🟡 (21:13) Django version installed: 5.2.12 at /home/byk/Code/getsentry/getsentry/.venv/lib/python3.13/site-packages/django/__init__.py * 🟡 (21:13) Read django/dispatch/dispatcher.py:50-124 — `Signal.connect(receiver, sender=None, weak=True, dispatch_uid=None)`. Lookup key is `(dispatch_uid, _make_id(sender))` when dispatch_uid provided, else `(_make_id(receiver), _make_id(sender))`. Duplicate key → silently dropped, receiver NOT replaced. Sender_receivers_cache cleared on connect * 🟡 (21:14) Read django/dispatch/dispatcher.py:85-124 continuation — DEBUG check verifies callable receiver and **kwargs support. weak=True uses WeakMethod for bound methods. Thread-safe via self.lock; finalizer registers _remove_receiver * 🟡 (21:14) Agent reasoning on dispatch_uid deduplication impact: with dispatch_uid, lookup_key=(dispatch_uid, sender_id) — receiver NOT in key. So 1st connect with dispatch_uid="X", receiver=A stored; 2nd connect with dispatch_uid="X", receiver=B is silently dropped, A remains. CRITICAL for test_notify_orbital_is_noop_when_udp_socket_unset: signal keeps original _notify_orbital (real impl) after module reload with noop * 🟡 (21:14) Agent reasoning on test design limitation: test only verifies direct call path (orbital.notify_orbital), not signal path (event_accepted.send_robust). In production, module loads once so signal has correct handler. Test suggested fix: disconnect with dispatch_uid before reload, assert via event_accepted.send_robust * 🟡 (21:14) Agent reasoning on BetterSignal.connect: passes *args, **kwargs to super().connect() so dispatch_uid propagates correctly through BetterSignal wrapper at sentry/signals.py:58 * 🟢 (21:14) Agent generated PR #21336 independent code review with: summary (4 changes across 6 commits), no critical issues, 9 concerns (test signal path gap, rsplit IPv6 behavior change, udp_addr set on socket failure, _ip_from_event untested edges, empty ip fallback, single invalid endpoint test shape, redundant double-reload, fragile startup metrics.incr, no_socket only on parse failure not unreachable host), 8 nits (module comment placement, if data vs None, redundant mock imports, dispatch_uid naming, _outcomes helper tag shape, cellsilo.py twemproxy ellipsis comment, _ip_from_event docstring Kafka reference, platform AttributeError on non-string), and 12 verified-good items * 🟡 (21:14) Agent verified the `dispatch_uid="getsentry.receivers.orbital"` deduplication satisfies the sentry-bugbot concern about reload leaks. Confirmed via django/dispatch/dispatcher