Distillation

Date: September 16, 2026

• 🔴 (22:02) User/project invariant: Always preserve strict output-mode and binary-safety contracts. sentry api must preserve rawApiRequest() status text; empty textual non-2xx bodies must produce an HTTP status/request fallback; JSON mode must expose {status, statusText, body} so empty success and error responses remain distinguishable; binary Uint8Array successes bypass formatters and remain raw; binary errors emit only status/content-type/byte-count summaries and never bytes or JSON coercion; prompts must never block scripted runs or interleave with stdout JSON.
• 🔴 (22:02) User/project invariant for issue collapse behavior: buildIssueListCollapse() always starts with ['filtered','unhandled'], conditionally adding 'lifetime' and then 'stats'.
• 🔴 (22:02) User stated src/commands/issue/list.ts defines LIFETIME_FIELDS = new Set(['count','userCount','firstSeen','lastSeen']); these fields may be stripped by collapse=lifetime on the issue-list endpoint.
• 🔴 (22:02) User stated buildListApiOptions(json, fields) enables collapseLifetime only when json && fields !== undefined && fields.length > 0 && !fields.some(f => LIFETIME_FIELDS.has(f)); human output never collapses lifetime.
• 🔴 (22:02) User stated ISSUE_DETAIL_COLLAPSE safely includes 'lifetime' because the detail endpoint preserves top-level fields. IssueViewOutputSchema in src/types/sentry.ts extends SentryIssueSchema with event, org, replayIds, and trace, which jsonTransformIssueView adds; view.ts wires it through schema: IssueViewOutputSchema. count, userCount, firstSeen, and lastSeen are always present on issue view and are only potentially absent from issue list when collapse=lifetime is active.
• 🔴 (22:02) User coding rule: Always declare explicit class fields and assign them in the constructor body; never use TypeScript constructor parameter properties such as constructor(private readonly handle: FileHandle). Biome’s noParameterProperties rule applies to new classes in src/lib/**/*.ts; it previously caught 4 errors at lines 281, 310, 311, and 312 during the FileOldReader/MemoryOldReader addition in bspatch.ts.
• 🔴 (22:02) User tooling rule: Always use file-path invocation for authoritative Biome results, e.g. biome check <file>. biome check --stdin-file-path=<file> can falsely exit with code 1 and report contents aren't fixed; this was confirmed during the agent-skills.ts review when stdin mode failed but --write produced zero changes.
• 🔴 (22:02) User stated .github/workflows/ci.yml:507 uses grep "^nightly-${MAJOR_MINOR}\\.", where the unescaped dot inside MAJOR_MINOR is technically a regex metacharacter. It is harmless in practice because MAJOR_MINOR is always digits, derived via cut -d. -f1,2 from X.Y.Z-dev.TS, and .github/workflows/ci.yml:501 first applies the sanitizing ^nightly-[0-9] filter.
• 🟡 (22:02) Defensive alternatives identified for the .github/workflows/ci.yml:507 grep: (1) grep -F "^nightly-${MAJOR_MINOR}." for literal matching; (2) ${MAJOR_MINOR//./\\.} to escape dots in shell; or (3) [[ "$tag" == nightly-${MAJOR_MINOR}.* ]] for direct Bash pattern matching.
• 🔴 (22:02) User/project invariant: Progress UI must be strictly cosmetic and must never throw or abort underlying work. Every rendering path, including onProgress callbacks and done(), must use try/catch that swallows display errors. Progress data must remain accurate and non-misleading; multi-hop patch chains should use percentage-only formatting when summed byte totals are inflated. Regression tests must verify both that unguarded rendering would fail and that the intended format is passed at the call site.
• 🔴 [requested-tests] (22:02) User/project testing standard for OpenAI Responses streaming fixes: add exhaustive focused regression coverage for principal and continuation paths, including malformed or non-monotonic events, terminal variants, cancellation/backpressure, accounting, rollback, and private-data redaction. Run targeted Vitest cases first, then the complete affected test file and TypeScript checks as appropriate. Treat expected protocol/failure logs and stack traces as normal test output and determine success from assertions and final pass counts.
• 🔴 [enforced-workflow] (22:02) User/project completion standard: Before concluding streaming work, inspect the Jujutsu revision, diff scope, conflicts, and bookmark placement, and confirm the working copy is clean.
• 🔴 (22:02) User/project Responses-streaming invariant: response.output_text.done is authoritative and must replace accumulated text rather than relying on concatenated deltas. Preserve strict identity/type reconciliation; on malformed or contradictory terminal data, redact private recall arguments and identifiers, fail closed with the appropriate public error, and do not execute recall or follow-up logic when validation fails.