Distillation

Date: Sep 16, 2026

• 🔴 [enforced-workflow] (22:35) User instructed the agent to resume the existing recovery implementation session in place after the server restart, preserving all edits, tests, and results while continuing the original blocker-fix assignment.
• 🔴 [requested-evidence] (22:35) User required substantive fail-first, fixed, and mutant evidence for the blocker fix.
• 🔴 (22:35) User specified memory recovery through lore recall --project /home/byk/Code/opencode-lore --scope project ... or local /ui/search if needed.
• 🔴 (22:35) User required failures to never be warning-only.
• 🔴 (22:35) User prohibited touching the server, production DB, bookmarks, or commits during this work.
• 🔴 (22:35) Project test policy in /home/byk/Code/opencode-lore-recall-recovery/AGENTS.md requires tests to use a temporary SQLite DB through packages/core/test/setup.ts, never the production DB.
• 🔴 (22:35) Project release policy in /home/byk/Code/opencode-lore-recall-recovery/AGENTS.md says never manually bump versions or edit CHANGELOG.md; Sentry Craft handles both automatically.
• 🔴 [enforced-workflow] (22:35) Project regression discipline in quality/REVIEW.md requires every defect found by adversarial review to receive a deterministic regression test in the same PR that fails on the base branch, passes on the fix, and drives the real precondition rather than artificially constructing state.
• 🔴 [enforced-workflow] (22:35) Project policy states tests of a guard must fail when that guard is deleted; if a test still passes after guard removal, it does not test the guard.
• 🔴 [enforced-workflow] (22:35) Project TDD policy states every bug fix must be driven by a regression test written first, observed failing on the base branch, and then observed passing on the fix: “Never trust the fix without seeing it fail.”
• 🔴 [requested-review] (22:35) Non-trivial changes require two distinct review passes: 1. adversarial/correctness review covering enumerated breaking states, apply-then-revert mutants, property-test stability ×10, hash-equivalence proofs, frozen-array mutation safety, and stale-cache analysis; 2. security/pentest review covering injection vectors, credential leaks, protocol attacks, and privilege escalation.
• 🔴 [enforced-workflow] (22:35) Reviewers must run pnpm test, pnpm run typecheck, pnpm run lint, and pnpm run format:check; verify exit codes because a blank output tail may conceal lint/format failures; run property tests ×10; confirm the working tree remains unmodified using hashes; and report per-point PASS / FAIL / CONCERN / MUST-FIX verdicts with file:line evidence plus an overall MERGE / DO-NOT-MERGE verdict.
• 🟡 (22:35) Project review guidance identifies skip/early-return branches as the highest-risk surface; examples include NOT EXISTS, latest <> 'upsert', and content-match guards. Every skip branch should have a test that makes it skip something incorrectly and proves the defect is prevented.
• 🟡 (22:35) Project review guidance recommends frozen shared arrays for memoized results so accidental mutation throws TypeError in strict mode rather than silently corrupting shared caches.
• 🟡 (22:35) Project review guidance states db().query monkeypatches are shadowed by the tracing Proxy; SQL-counting tests must use log.registerSink({ withDbSpan }).
• 🟡 (22:36) Root package.json scripts include "test": "vitest run" with "pretest": "pnpm --filter @loreai/gateway run bundle", "typecheck": "pnpm -r run typecheck", "lint": "oxlint --type-aware", "format:check": "oxfmt --check", "premutation": "pnpm --filter @loreai/gateway run bundle", and "mutation": "stryker run".
• 🔴 (22:36) User required private source coverage to never be emitted to the client.
• 🟡 (22:37) Current recovery implementation in packages/gateway/src/pipeline.ts:10258-10272 calls applyResponsesEvent(state, event, parsed), then passes an accepted Codex quota event through appendCodexRateLimitEvent(publicCodexRateLimits, acceptedCodexRateLimit); publicData is the canonical JSON.stringify(publicCodexRateLimit) only when that shared public accumulator accepts the event, otherwise it remains the original data.
• 🟡 (22:37) The use of publicCodexRateLimits in packages/gateway/src/pipeline.ts:10264-10269 introduces a public-output accumulator distinct from the internal per-state state.codexRateLimits, providing a place to enforce a combined quota-metadata budget across principal and continuation streams.
• 🟡 (22:37) packages/gateway/src/pipeline.ts:10309-10350 suppresses events belonging to recall items or unresolved tool identities while still byte-counting them. It encodes hidden events with formatResponsesEvent(event, data), tracks deferredBytes, hiddenRecallBytes, and per-index unresolvedToolBytes, and throws SSEStreamLimitError("recall stream exceeded deferred event limit") when maxDeferredBytes or maxHiddenRecallBytes is exceeded.