Distillation

🔴 (20:48) User stated, “I want to minimize the review request noise for the backend maintainers.” 🟡 (20:48) terraform-github-pr-34847 intentionally combines three changes because each helps prune indirect remote-state-backend dependencies, while splitting dependency-graph changes into separate PRs tends to cause entangled merge conflicts under Go’s module-dependency model: 1. Terraform-owned module source-address normalization; 2. moving SynthBody into package configtesting; 3. pruning legacy/terraform. 🟡 (20:48) The PR author planned to un-request backend-maintainer reviews because the changes do not meaningfully alter backends; GitHub automatically added the requests because of code-owner rules. 🟡 (20:48) Terraform retained go-getter for actual module installation because that code is sensitive to security advisories and shared upstream ownership enables fixes across HashiCorp products in one place; only parsing and normalization of historical shorthand source addresses moved under Terraform’s control. 🟡 (20:48) The copied go-getter detector logic and unit tests were intended to preserve behavior, except Terraform deliberately removed obsolete Bitbucket repository-type API detection. Bitbucket had dropped Mercurial support, and removal also prevents source-address parsing from secretly making an internet API request. (meaning 2020) 🟡 (20:48) legacy/terraform, originally a snapshot of Terraform v0.11’s package terraform, now exists exclusively for legacy/helper/schema, which some remote-state backends still use; provider- and provisioner-related dead code was pruned because those backends do not need it, reducing indirect backend dependencies. 🟡 (20:48) SynthBody, a helper for constructing synthetic hcl.Body values in configuration tests without source files, moved from package configs to package configtesting; isolating it avoids pulling package configs’ broader dependency graph into backend test utilities, and configtesting may later host other configuration-mocking helpers.