Distillation

Date: Sep 16, 2026

• 🔴 (13:13) User stated that jj never fails on conflict; conflicts are recorded in the resulting commit and must be detected with jj st, resolved by manually editing conflict markers, and not handled with interactive jj resolve.
• 🔴 [enforced-vcs-workflow] (13:13) User’s repository contains both .jj/ and .git/, making it a colocated jj repository; mutations must use jj, not git, so the operation log remains consistent.
• 🔴 [enforced-vcs-workflow] (13:13) User’s jj workflow forbids interactive flags such as -i and --interactive, requires -m "msg" for describe/commit operations, requires mutation verification with jj st and jj log, prefers stable change IDs over commit IDs, and forbids rebasing or describing immutable commits.
• 🔴 (13:14) User’s project is the Lore TypeScript/pnpm monorepo at /home/byk/Code/opencode-lore-embedding-runtime, using Node.js >= 22.5; root package.json pins Volta Node 24.16.0, pnpm 10.28.0, and package manager pnpm@10.28.0.
• 🔴 (13:14) User stated tests use a temporary SQLite database through packages/core/test/setup.ts, never the production database at ~/.local/share/lore/lore.db.
• 🔴 [enforced-release-workflow] (13:14) User stated never to manually bump package versions or edit CHANGELOG.md; Sentry Craft handles both automatically. Releases are triggered with gh workflow run release.yml -f version=auto or an explicit version such as gh workflow run release.yml -f version=0.23.0.
• 🔴 [enforced-review-workflow] (13:15) User’s review policy requires every adversarial-review defect to receive a deterministic regression test in the same PR that fails on the base branch, passes on the fix, and drives the real precondition; tests of guards must fail when the guard is deleted.
• 🔴 [enforced-tdd] (13:15) User stated: “Never trust the fix without seeing it fail.” Bug fixes must be driven by a regression test written first, confirmed failing on the base branch, then confirmed passing with the fix.
• 🔴 [enforced-review-workflow] (13:15) User’s non-trivial PR workflow requires separate adversarial/correctness and security/pentest review passes. Reviewers must run pnpm test, pnpm run typecheck, pnpm run lint, and pnpm run format:check; verify property tests across 10 runs; hash-verify an unmodified working tree; and report per-point PASS / FAIL / CONCERN / MUST-FIX verdicts with file:line evidence plus an overall MERGE / DO-NOT-MERGE.
• 🔴 (13:15) User stated a worker must never be admitted from a stale cgroup directory or a cached discovery miss; memoryFiles() in packages/core/src/cgroup-memory.ts:126-133 therefore rereads /proc/self/cgroup and /proc/self/mountinfo on every discovery.
• 🟡 (13:15) Current packages/core/src/cgroup-memory.ts:31-54 parses both v1 memory-controller and v2 unified memberships and orders candidates as [v1Memory, v2], preferring an explicit v1 memory controller on hybrid hosts.
• 🟡 (13:15) Current resolveLinuxCgroupMemoryFiles() in packages/core/src/cgroup-memory.ts:75-124 gathers all matching mounts for each membership; it prefers direct mounts sorted by descending root.length, accepts a namespaced interpretation only when exactly one namespaced candidate exists, and otherwise returns null.
• 🟡 (13:15) Current cgroup path hardening in packages/core/src/cgroup-memory.ts:22-29 decodes procfs octal escapes, rejects paths that are not absolute, contain NUL, or contain a .. segment, then applies posix.normalize().
• 🟡 (13:15) Current readLinuxCgroupMemoryHeadroomBytes() in packages/core/src/cgroup-memory.ts:152-205 reads v2 memory.current with both memory.high and memory.max, or v1 memory.usage_in_bytes with memory.limit_in_bytes; walks from the resolved directory to its mount point; computes the minimum finite Math.max(0, limit - usage) across boundaries; and returns undefined on malformed, unsafe, missing, or unreadable required data except for the unregulated v2 root special case.