Distillation

Date: Sep 16, 2026

• 🔴 [requested-review] (22:33) User requested an independent, read-only, adversarial correctness review of immutable projection candidate /home/byk/Code/opencode-lore-responses-projection-security, stable change lnvrxqoqsqut, commit f30236708bc9, based on main@origin commit 2cbf40060c67.
• 🔴 (22:33) User stated the expected cumulative plain diff SHA is b7df735637f9d033c895867ebe157cb05f8d390bea78842d58d14fd8091fd3e1.
• 🔴 (22:33) User stated the candidate should change exactly pipeline.ts plus a recall-aware test, with clean empty child kwmswwmt.
• 🔴 (22:33) User required reading AGENTS.md, quality/REVIEW.md, and scripts; user noted repo-setup is unavailable.
• 🔴 (22:33) User required no edits, formatting, installation, VCS mutation, network use, server startup, or production-database access during the review.
• 🔴 (22:33) User required verification of repository identity, status, conflicts, changed files, and hash both at the start and end of the review.
• 🔴 (22:33) User required inspection of every changed line plus relevant lifecycle, projection, terminal, callback, and test code.
• 🔴 (22:33) User required auditing: live-principal remapping; incremental source-to-public ledger behavior; lower/higher sparse ordering; recall-anchor reservation; deferred/continuation remapping; terminal identity consistency; exact semantic-frame allowlisting after recall; created_at validation; accumulator-first invariant; output:[] failure; bounded complexity; side effects before predictable failure; cancellation; backpressure; and transaction behavior.
• 🔴 (22:33) User specified test evidence to assess: failing-first and mutations; 11-case 110/110; 230 full/transport; 258 adjacent; and green static/bundle checks. Focused tests should run only if useful.
• 🔴 (22:33) User required findings against exact HEAD file-and-line locations, classified as PASS, CONCERN, or MUST-FIX, with test-discrimination analysis and residual risks.
• 🔴 (22:33) User directed: “Never warning-only; local lore recall/UI fallback.”
• 🔴 (22:33) User required the final review output to end exactly with either MERGE or DO-NOT-MERGE.
• 🔴 (22:34) User stated that jj never fails on conflict: merge conflicts are recorded in the resulting commit and must be detected with jj st and resolved by editing files.
• 🔴 (22:34) Repository /home/byk/Code/opencode-lore-responses-projection-security contains both .jj/ and .git/; jj guidance requires using jj rather than git for mutations so the operation log remains consistent.
• 🔴 (22:34) jj workflow rules supplied by the user: never use interactive flags; always pass -m "msg" when describing/committing; verify mutations with jj st and jj log; prefer stable letter-based change IDs over hexadecimal commit IDs; never rebase or describe an immutable commit; and do not use interactive jj resolve.
• 🔴 (22:35) Project runtime is Node.js >= 22.5; the codebase is a TypeScript monorepo using pnpm workspaces; storage is SQLite in WAL mode with FTS5, normally at ~/.local/share/lore/lore.db.
• 🔴 (22:35) Tests use a temporary SQLite database through packages/core/test/setup.ts; they must never use the production database.
• 🔴 (22:35) User/project release policy: never manually bump versions or edit CHANGELOG.md; Sentry Craft handles both automatically.
• 🔴 (22:35) Release workflow details: scripts/bump-version.sh updates all package.json versions; conventional commits generate the changelog; a release/X.Y.Z branch is created; CI builds npm tarballs, standalone binaries, and delta patches; Craft opens a publish issue; labeling it accepted triggers npm OIDC publishing and a GitHub Release.
• 🔴 (22:35) Review policy requires every non-trivial PR to receive an adversarial correctness review before merge.
• 🔴 (22:35) Regression tests must fail on the base branch, pass with the fix, and fail when the relevant guard is deleted; user/project policy states: “Never trust the fix without seeing it fail.”
• 🔴 (22:35) Review workflow requires property-test stability across ×10 runs and structured evidence; an unstructured “LGTM” is not acceptable.
• 🔴 (22:35) The scripts/ directory contains exactly 12 entries: bump-version.sh, cch-scan.c, check-cc-version.ts, check-docs-links.mjs, check-patches.ts, check-preview-links.mjs, check-social-meta.mjs, extract-cch-seed.ts, generate-config-docs.ts, generate-env-docs.ts, generate-release-checksums.mjs, and smoke-install.mjs.