Distillation

🔴 (23:52) User provided the patch checksum 3417558ce792780a5ada5fef4c6a57cd9a2f7106236abc803b3cea31fe79efbf. 🔴 (23:52) User provided the branch’s 3-commit sequence, newest first: 723375b6c (fix(cli): address upgrade review findings), 9c874298e (fix(cli): address toolkit bridge review), and 04867eaf9 (feat(cli): add toolkit upgrade bridge). 🔴 (23:52) User stated package-manager upgrades always need network access to fetch and install packages; consequently, offline upgrade mode is supported only for curl-installed binaries. 🔴 (23:52) User stated nightly builds are GitHub-only and pinned nightly version validation must always use the curl (GitHub) lookup, regardless of the current installation method. 🔴 (23:52) User stated sentry cli upgrade nightly switches to the nightly channel and updates the CLI. 🔴 (23:52) User stated trailing path separators should be stripped for comparison, but never from a bare root such as /. 🔴 (23:52) User stated the upgrade-source probing caller receives the successful probe response so it never repeats the successful request. 🟡 (23:52) packages/cli/src/commands/cli/upgrade.ts now imports UpgradeSource from ../../lib/binary.js and resolveExistingUpgradeVersion plus resolveLatestUpgradeVersion from ../../lib/upgrade.js; pinned versions are resolved through resolvePinnedVersion(lookupMethod, target), with any returned source replacing the prior source. 🟡 (23:52) validateMethod() in packages/cli/src/commands/cli/upgrade.ts rejects method === "unknown" with UpgradeError("unknown_method"); rejects a pinned stable version with Homebrew using UpgradeError("unsupported_operation", "Homebrew does not support installing a specific version. Run 'brew upgrade getsentry/tools/sentry' to upgrade to the latest formula version."); and rejects offline mode for every method except curl with UpgradeError("unsupported_operation", "Offline upgrade is only supported for curl-installed binaries."). 🟡 (23:52) Upgrade check warnings use sentry cli upgrade ${target} for a specifically pinned version and otherwise use sentry cli upgrade; no update hint is emitted when CLI_VERSION === target. 🟡 (23:52) Successful delta upgrades log Applied delta patch (${formatBytes(downloadResult.patchBytes)} downloaded) when downloadResult.patchBytes is present. 🟡 (23:52) Post-upgrade shadowing warnings say Your ${method}-installed sentry may still appear earlier in PATH. and, when available, add Consider removing it: ${hint}. Removal hints are: npm uninstall -g sentry, pnpm remove -g sentry, bun remove -g sentry, yarn global remove sentry, and brew uninstall getsentry/tools/sentry. 🟡 (23:52) packages/cli/src/commands/cli/upgrade.ts avoids a redundant setInstallInfo call because install information is already recorded by the child setup --install process. 🟡 (23:52) packages/cli/src/lib/binary.ts defines KNOWN_CURL_DIRS as [".local/bin", "bin", ".sentry/bin"], LEGACY_INSTALL_SUBDIR as join(".sentry", "bin"), and LEGACY_INSTALL_SUBDIRS as [LEGACY_INSTALL_SUBDIR]; migration is deliberately limited to the pre-XDG ~/.sentry/bin, while ~/.local/bin and ~/bin remain valid current targets. 🟡 (23:52) samePath(a, b) in packages/cli/src/lib/binary.ts tolerates trailing separators and compares case-insensitively on Windows and macOS, based on module-load constant IS_CASE_INSENSITIVE_FS; Linux-style case-sensitive filesystems retain case-sensitive comparison. 🟡 (23:52) InstallationMethod in packages/cli/src/lib/binary.ts is the union "curl" | "brew" | "npm" | "pnpm" | "bun" | "yarn" | "unknown"; invalid parsed values throw Invalid method: ${value}. Must be one of: ${VALID_METHODS.join(", ")}. 🟡 (23:52) Musl detection in packages/cli/src/lib/binary.ts uses two ordered heuristics: 1. check /lib/ld-musl-<arch>.so.1; 2. inspect combined stdout and stderr from ldd --version for "musl". The result is cached in cachedIsMusl; if ldd is unavailable or fails, the code assumes glibc and caches false. 🟡 (23:52) packages/cli/src/lib/binary.ts adds GitHub upgrade-source probing infrastructure, including getGitHubReleasesUrl(), exported GITHUB_RELEASES_URL, UpgradeSource, a getProbeUrl(source) callback, and ordered source probing that defaults to all configured upgrade sources. 🟡 (23:52) Nightly version detection uses isNightlyVersion(version), which checks for "-dev."; the documented nightly format is X.Y.Z-dev.<unix-seconds>. 🟡 (23:52) isDowngrade(current, target) returns whether compareVersions(current, target) === 1. 🟡 (23:52) determineInstallDir(homeDir, env) uses this exact priority: 1. $SENTRY_INSTALL_DIR; 2. absolute $XDG_BIN_HOME; 3. ~/.local/bin if it exists and is in $PATH; 4. ~/bin if it exists and is in $PATH; 5. ~/.local/bin as the XDG-aligned fallback, with setup responsible for PATH modification.