Distillation

Date: Sep 17, 2026

• 🔴 [requested-review] (08:41) User requested a read-only exploratory audit of the CURRENT working-copy native ONNX runtime selection/fallback/packaging changes in /home/byk/Code/opencode-lore-embedding-runtime at Jujutsu change tmzmtlss, comparing against parent 2cbf4006 only as needed.
• 🔴 [enforced-workflow] (08:41) User prohibited editing files, mutating VCS, using the network, running services, or accessing production databases during the audit.
• 🔴 (08:41) User specified primary audit targets: packages/core/src/ort-native.ts, packages/core/src/embedding-worker-types.ts, packages/core/src/embedding-worker.ts, packages/gateway/script/bundle.ts, packages/gateway/script/ort-platform-package.ts, and all directly relevant tests.
• 🔴 (08:41) User requested investigation of concrete correctness/security defects, platform/ABI/format edge cases, unsafe fallback classifications, package-resolution or vendoring mismatches, and missing regressions.
• 🔴 (08:41) User requested special attention to forceWasm semantics, raw TypeScript development/test behavior, vendored/SEA behavior, supported platform-package discovery, ELF/Mach-O/PE classification, native initialization fallback boundaries, and preserving WASM numThreads=1.
• 🔴 (08:41) User required the audit response to contain only substantive findings ordered by severity, with exact current file:line evidence and concise suggested tests/fixes; explicitly state if there are no findings.
• 🔴 (08:41) User directed not to claim final merge approval because the candidate may change.
• 🔴 (08:42) User stated Jujutsu (jj) never fails on conflict: operations record the conflict in the resulting commit, after which jj st must be checked and conflicted files resolved manually; jj resolve must not be used because it is interactive.
• 🔴 (08:42) User’s Jujutsu workflow rules: use jj, not git, when .jj/ exists; never use interactive flags; always pass -m "msg" for describe/commit operations; verify mutations with jj st and jj log; prefer stable change IDs; never rebase or describe immutable commits; use jj undo, jj op log, or jj op restore <op-id> for recovery.
• 🟡 (08:42) Assistant stated the required repo-setup skill was unavailable and that it would apply repository instructions directly while keeping the audit read-only.
• 🟡 (08:42) Repository status showed working copy @ as change tmzmtlss, commit 8888d203b173a59866a454f08ba0273d182cf131, description fix(core): correct embedding runtime selection and admission, parent change pxrvwsvv, commit 2cbf40060c67df229731cf1b9e34d5bf22ec2145, with conflicts=false.
• 🟡 (08:42) Working-copy diff contained 20 changed files with 1,929 insertions and 205 deletions: added packages/core/src/cgroup-memory.ts and packages/core/test/cgroup-memory.test.ts; modified packages/core/src/embedding/local.ts, packages/core/src/embedding/pool.ts, packages/core/src/embedding-cap.ts, packages/core/src/embedding-worker-types.ts, packages/core/src/embedding-worker.ts, packages/core/src/embedding.ts, packages/core/src/ort-native.ts, packages/core/test/embedding-cap.test.ts, packages/core/test/embedding-pool-memory.test.ts, packages/core/test/embedding-pool.test.ts, packages/core/test/embedding-wasm-fallback.test.ts, packages/core/test/embedding-worker-stdio.test.ts, packages/core/test/embedding-worker-types.test.ts, packages/core/test/ort-native.test.ts, packages/gateway/script/bundle.ts, packages/gateway/script/ort-platform-package.ts, packages/gateway/test/bundle-exports.test.ts, and packages/gateway/test/ort-platform-package.test.ts.
• 🟡 (08:42) Repository status warned that bookmark fix/responses-private-references had conflicts, while the audited working-copy change itself reported conflicts=false.
• 🔴 (08:42) User stated the repository requires every non-trivial PR to receive an adversarial correctness review before merge, following quality/REVIEW.md.
• 🔴 (08:42) User stated the project runtime is Node.js >= 22.5, the language is TypeScript in a pnpm workspace monorepo, and tests use a temporary SQLite database via packages/core/test/setup.ts—never the production DB.
• 🔴 (08:42) User stated @loreai/core is consumed by gateway, OpenCode, and Pi; the gateway bundles core into a single CJS file via esbuild, while the OpenCode package ships raw TypeScript.
• 🔴 (08:42) User stated the gateway build uses packages/gateway/script/build.ts to produce a CJS bundle and packages/gateway/script/bundle.ts to create the standalone binary; the core build uses packages/core/script/build.ts for Node.js-compatible CJS output.
• 🔴 (08:42) User stated releases use Sentry Craft via GitHub Actions and directed: “Never manually bump versions or edit CHANGELOG.md”; Craft handles both automatically.
• 🔴 (08:43) User stated every adversarial-review defect must receive a deterministic regression test in the same PR that fails on the base branch, passes on the fix, and drives the real precondition rather than an artificially constructed state.
• 🔴 (08:43) User stated tests that exercise a guard must fail when that guard is deleted.
• 🔴 (08:43) User stated skip/early-return branches are the highest-risk surface and each needs a test that causes the branch to fire wrongly and proves it does not skip something it should handle.
• 🔴 (08:43) User requires TDD failing-first for bug fixes: “Never trust the fix without seeing it fail.”
• 🔴 (08:43) User stated non-trivial review must use two separate passes: 1. adversarial/correctness review covering enumerated cases, apply-then-revert mutants, property-test stability ×10, hash-equivalence proofs, frozen-array mutation safety, and stale-cache analysis; 2. security/pentest review covering injection vectors, credential leaks, protocol-level attacks, and privilege escalation.
• 🔴 (08:43) User stated reviewers must run pnpm test, pnpm run typecheck, pnpm run lint, and pnpm run format:check; check exit codes; verify property-test stability with 10 runs; confirm the working tree remains unmodified via hashes; and report per-point PASS / FAIL / CONCERN / MUST-FIX verdicts with file:line evidence plus an overall MERGE / DO-NOT-MERGE verdict.
• 🟡 (08:43) Root package.json specifies packageManager: "pnpm@10.28.0", Volta Node 24.16.0, Volta pnpm 10.28.0, and an onnxruntime-node override of 1.27.0; onnxruntime-node is included in pnpm.onlyBuiltDependencies.
• 🟡 (08:43) Root scripts include test: "vitest run" with pretest: "pnpm --filter @loreai/gateway run bundle", test:coverage: "pnpm --filter @loreai/gateway run bundle && vitest run --coverage", typecheck: "pnpm -r run typecheck", lint: "oxlint --type-aware", format:check: "oxfmt --check", build: "pnpm -r run build", and postinstall: "pnpm --filter @loreai/gateway run build".