Dashboard › opencode-lore › Distillation
746a54a2-4c17-493a-b373-5132842c7fc0["lore_tm_v1_JBKorTd6U4rP44ZVWUVy3YLIpG9Gn_HtuWi5K5T9KQ8"]
Date: Sep 16, 2026
DO-NOT-MERGE.tmzmtlsspstnppsrlpmuulsywurmlnqu, but the commit advanced from aee4651c96b009c28f9e79f40f019fd2c7c49a0a to 1a05f4ab33e9ef541ddcb5a9bf62be6b60d85610; parent remained 2cbf40060c67df229731cf1b9e34d5bf22ec2145; current @ had no file conflicts. The report printed the prior diff SHA-256 as f0b8e99bf067fc02503826cb13843a0baf725f9ae83276de21c6da0ba3c5c1dc and current SHA-256 as e0b19388dc7503fe3953af260d915172af8307413c1038ec97024142ab5c5670.MUST-FIX findings, in order: 1. Native loader classification discards Node’s err.code at embedding-worker.ts:231-233 and uses string-only isNativeOrtLoadError() at embedding-worker-types.ts:224-234, missing forms such as wrong ELF class, missing GLIBC_*, Windows %1 is not a valid Win32 application, and versioned Darwin libraries; tests at embedding-worker-types.test.ts:82-100 and bundle-exports.test.ts:225-229 do not exercise a real coded loader error. 2. Native format/ABI validation at ort-native.ts:150-172,271-285 does not validate architecture, ELF class, Mach-O CPU, PE signature/machine, minimum size, or N-API runtime compatibility; the successful fixture at ort-native.test.ts:35-43 is only 4 bytes. 3. Worker artifacts remain outside the freshness gate because only dist/index.cjs and dist/index.bun.js are checked at bundle-exports.test.ts:60-61,114-123, while embedding-worker.cjs and embedding-worker.js are asserted and executed at :185-198. 4. Free-form exception text still reaches console diagnostics at embedding-worker.ts:293-295,309-311 and crosses the worker boundary through init-error at embedding-worker.ts:322-328 and embedding-worker-types.ts:74-80.CONCERN findings, in order: 1. resolveDeclaredPackageDir() uses ancestor-walking Node resolution at ort-native.ts:136-148, contradicting the ownership claim at :193-196; ort-native.test.ts:383-401 deliberately accepts an ancestor package. 2. validNativeBinding() canonicalizes only the addon at ort-native.ts:150-183 and does not validate sibling ONNX Runtime libraries, allowing sibling symlinks to escape the package boundary.PASS items: 1. Unsupported targets and unsupported Linux libc fail closed at ort-native.ts:207-213. 2. Package identity, version, OS, and CPU receive exact comparisons at ort-native.ts:221-269. 3. The rewritten WASM-respawn message contains no raw diagnostic at embedding-worker.ts:233-239,270-282.bundle-exports.test.ts:132-155 may rebuild and mutate dist/, violating the read-only constraint; it stated that the static defects were independently decisive.