Distillation

Date: Aug 26, 2026

• 🟡 (13:20) In /home/byk/Code/getsentry/craft-workspace-action-propagation/src/commands/publish.ts, runPostReleaseCommand(newVersion, postReleaseCommand?) returns false without running when postReleaseCommand === ''; otherwise parses a specified command with shellQuote.parse(), or runs executable DEFAULT_POST_RELEASE_SCRIPT_PATH using /bin/bash; it appends '' and newVersion to arguments, calls spawnProcess() with buildReleaseCommandEnv({ CRAFT_RELEASED_VERSION: newVersion }), and returns true.
• 🟡 (13:20) publishMain(argv: PublishOptions) obtains the active configuration through getConfiguration() || {}, checks dirty Git state unless argv.noGitChecks, uses config.releaseBranchPrefix || DEFAULT_RELEASE_BRANCH_NAME, and either checks out argv.rev (resolving its branch name with git.raw('name-rev', '--name-only', '--no-undefined', rev)) or the release branch ${branchPrefix}/${newVersion}.
• 🟡 (13:20) When release-branch checkout fails in publishMain(), it invokes findReleaseBranches(git, branchPrefix) and throws ConfigurationError containing the missing branch, a craft prepare suggestion, the configured/default prefix, exact branch matches, fuzzy prefix matches, or “No release branches found on the remote,” plus the original error.
• 🟡 (13:20) After checkout, publishMain() resolves revision = await git.revparse('HEAD'), obtains status/artifact providers, executes checkRevisionStatus(statusProvider, revision, argv.noStatusCheck), printRevisionSummary(artifactProvider, revision), and checkRequiredArtifacts(artifactProvider, revision, config.requireNames).
• 🟡 (13:20) publishMain() expands npm workspace targets through expandWorkspaceTargets(config.targets || []); SpecialTarget.All or SpecialTarget.None cannot be combined with any other target and causes an error log plus undefined return.
• 🟡 (13:20) Publish-state path computation uses getPublishStatePath(newVersion, getPublishStateGitHubConfig(publishStateGithubConfig), process.cwd(), getActiveWorkspace()), thereby propagating the selected workspace into publish-state filenames. getGlobalGitHubConfig() errors are caught and use null, allowing getPublishStatePath() to fall back to a cwd-hash-only filename in $XDG_STATE_HOME/craft/.
• 🟡 (13:20) publishMain() no longer reads legacy project-local .craft-publish-${newVersion}.json files due to attacker-influenceable repository contents; it warns users to migrate pre-seeded published-target state to the new $XDG_STATE_HOME/craft/ path.
• 🟡 (13:20) If the XDG publish state file exists, publishMain() parses it, resets targetsToPublish to all expanded target IDs, and skips each ID in publishState.published; otherwise it initializes publishState = { published: Object.create(null) }. Before publishing, it creates dirname(publishStateFile) with mkdirSync(..., { recursive: true }); after every successful publishToTarget(target, newVersion, revision), it records that target ID as true and writes JSON state with safeFs.writeFileSync().
• 🟡 (13:20) src/schemas/project_config.ts defines releaseUnitFields: github, targets, preReleaseCommand, postReleaseCommand, releaseBranchPrefix, changelog, changelogPolicy, requireNames, statusProvider, artifactProvider, versioning, and optional boolean noMerge (documented as defaulting to true for compiled GitHub Actions with a dist/ folder).
• 🟡 (13:20) WorkspaceSchema is z.object({ ...releaseUnitFields, github: GitHubGlobalConfigSchema.partial().optional() }); workspace fields are optional inherited overrides, and partial GitHub config specifically allows overriding projectPath, owner, or repo while inheriting other top-level GitHub fields.
• 🟡 (13:20) CraftProjectConfigSchema accepts optional minVersion, constrained by /^\d+\.\d+\.\d+.*$/, and optional workspaces: z.record(z.string(), WorkspaceSchema). Documentation distinguishes named independently-versioned Craft workspaces from an npm target’s workspaces: true, which discovers packages within one target and publishes all at the same version.
• 🟡 (13:20) Project package is @sentry/craft version 2.31.0-dev.0; CLI binaries craft and sentry-craft both map to dist/craft. Test script is vitest run; typecheck script is tsc --noEmit; Volta pins Node 24.18.0 and pnpm 10.27.0.
• 🟡 (13:21) Targeted Craft test run vitest run -- src/__tests__/action.test.ts src/commands/__tests__/publish.test.ts completed successfully: 60 test files passed; 1,132 tests passed and 1 skipped (1,133 total); duration 28.21s.
• 🟡 (13:21) The Craft test run emitted Vite/esbuild warnings in src/targets/__tests__/symbolCollector.test.ts at assignments around lines 58 and 68: assignments to imported checkExecutableIsPresent will throw because imports are immutable.
• 🟡 (13:21) Acceptance-project test run in /home/byk/Code/getsentry/publish-workspace-acceptance, vitest run src/modules/__tests__/details-from-context.js src/modules/__tests__/update-issue.js, passed: 2 test files and all 15 tests passed; duration 273ms.
• 🟡 (13:21) The acceptance test run warned that vitest.config.js:1:1 uses ESM syntax while loaded as CommonJS, unsupported by Vite’s future-default configLoader: 'native'; suggested remedies are a .mjs extension, "type": "module" in the closest package.json, or VITE_CONFIG_NATIVE_IGNORE_WARNING=true to suppress the warning.