Distillation

Date: Sep 8, 2026

• 🔴 (08:20) User requires bun typecheck to be run from package directories such as packages/core; never run tsc directly.
• 🔴 (08:20) User requires runtime dependencies to flow from Schema to Core and Protocol, then from Core and Protocol to Server. Client runtime code may depend on Schema and Protocol, but never Core or Server; sdk composes Client, Core, and Server.
• 🔴 (08:20) User prohibits aliased imports such as import { foo as bar } from "..." and renamed imports such as resolve as pathResolve.
• 🔴 (08:20) User prohibits type-position import("...") references such as Schema.declare<import("@opencode/plugin/effect/plugin").Plugin["effect"]>. An aliased type import such as import type { Plugin as PluginDefinition } from "..." is permitted only as a last resort when names genuinely collide and no other option exists.
• 🔴 (08:20) User prohibits star imports, including import * as Foo from "..." and import type * as Foo from "...". Namespace-style values should use the module’s named exported namespace, e.g. import { Project } from "@opencode/core/project" followed by Project.ID.
• 🔴 (08:20) User requires every Effect-version plugin domain to extend the corresponding Effect API client interface from @opencode/client/effect/api, not redefine functions already present there, and add only functions meaningful in the plugin context.
• 🟡 (08:20) Reviewed /home/byk/Code/opencode-v2-pilot/packages/plugin/src/promise/adapter.ts lines 60–109. The stream adapter’s close() uses iterator.return?.() ?? Promise.resolve({ done: true as const, value: undefined }); abort invokes void close(); close is added to subscriptions; the abort listener uses { once: true }; and an already-aborted signal triggers abort() immediately.
• 🟡 (08:20) In /home/byk/Code/opencode-v2-pilot/packages/plugin/src/promise/adapter.ts, stream next() closes after a completed iterator result and also closes before re-rejecting an iterator error; the returned iterable exposes return: close and satisfies StreamAdapter.
• 🟡 (08:20) rpcFromEffect in /home/byk/Code/opencode-v2-pilot/packages/plugin/src/promise/adapter.ts obtains Effect.context<Scope.Scope>(), creates run with Effect.runPromiseWith(context), builds a local RPC client via host(definition), and exposes subscriptions through streams(local.events.subscribe(name), options).
• 🟡 (08:20) Portable RPC methods in rpcFromEffect are generated from Object.keys(definition.methods). Each local[name] is asserted as (input: unknown) => Effect.Effect<unknown, unknown> under oxlint-disable-next-line typescript-eslint/no-unsafe-type-assertion, then executed as run(method(input), { signal: options?.signal }).
• 🟡 (08:20) A search returned no files; the displayed result did not identify the query.
• 🟡 (08:20) Search in /home/byk/Code/opencode-v2-pilot/packages/core/src/permission.ts found 15 permission-error/assertion references: line 64 DeclinedError; line 66 CorrectedError; line 85 Error = BlockedError | CorrectedError; line 105 assert: (input: AssertInput) => Effect.Effect<void, Error | SessionErrors.NotFoundError>; line 117 deferred errors DeclinedError | CorrectedError; line 132 failure of pending deferred items with new DeclinedError(); line 202 creation of Deferred.make<void, DeclinedError | CorrectedError>(); line 221 Effect.fn("Permission.assert"); lines 240–242 comment that CorrectedError with feedback remains typed while Permission.DeclinedError becomes a defect via Effect.die(error); line 268 selection between new CorrectedError({ feedback: input.message }) and new DeclinedError(); line 278 deferred failure with new DeclinedError(); and line 324 Service.of({ ask, assert, reply, get, forSession, list }).
• 🟡 (08:20) The same search found 3 legacy references in /home/byk/Code/opencode-v2-pilot/packages/core/src/v1/permission.ts: line 13 defines CorrectedError tagged "PermissionCorrectedError"; line 33 defines Error = DeniedError | RejectedError | CorrectedError.