Distillation

Date: Sep 10, 2026

• 🔴 (03:54) User-provided immutable security review returned DO-NOT-MERGE with three MUST-FIX blockers: raw prefetched-release provenance bypass, pinned stable targets inheriting the persisted nightly changelog channel, and GHCR retries losing non-Error abort reasons.
• 🔴 (03:54) User required prefetchedReleases to accept branded NormalizedGitHubReleases and pass isNormalizedForSource() before reuse; absent or mismatched branding must return null or fetch from the selected source—“never normalize caller-supplied raw prefetched data.”
• 🔴 (03:54) User stated the provenance bug was in packages/cli/src/lib/release-notes.ts:430-438,640-642,746: unbranded GitHubRelease[] arrays were reinterpreted under the caller-provided source, defeating the structural source branding in packages/cli/src/lib/delta-upgrade.ts:75-120; packages/cli/test/lib/release-notes.test.ts:390-419 preserved this unwanted behavior.
• 🔴 (03:54) User required four prefetched-release provenance regressions: 1. raw valid Toolkit releases must be rejected, 2. Toolkit-normalized releases used with the legacy source must be rejected, 3. legacy-normalized releases used with Toolkit must be rejected, and 4. same-source branded releases must succeed. The three rejected cases must neither fetch nor produce a changelog.
• 🔴 (03:54) User stated artifact behavior must “always follow the target; only persisted channel state follows the tracking channel.”
• 🔴 (03:54) User stated the pinned-stable channel bug was in packages/cli/src/commands/cli/upgrade.ts:276-280,1023-1029,1037-1043: getArtifactChannel() returned trackingChannel for every non-nightly target, so sentry cli upgrade 1.2.3 while tracking nightly installed through stable npm/GitHub assets but requested a nightly changelog, which a nightly current version’s timestamp parsing would normally suppress.
• 🔴 (03:54) User required artifact channel derivation solely from target: a nightly target uses nightly; every other target uses stable.
• 🔴 (03:54) User required pinned-stable regressions for both npm and curl while persisted tracking remains nightly: changelog requests must use the selected stable releases endpoint and “never the commits endpoint”; persisted channel must remain nightly, and the inverse pinned-nightly regression must remain.
• 🔴 (03:54) User stated the GHCR cancellation bug was in packages/cli/src/lib/ghcr.ts:79-97,135-150: fetchWithRetry() normalized the caught value to Error before comparison with externalSignal.reason, losing identity for string, number, symbol, or plain-object reasons and converting cancellation into UpgradeError("network_error").
• 🔴 (03:54) User required GHCR cancellation to compare against the raw caught value before normalization and rethrow externalSignal.reason unchanged.
• 🔴 (03:54) User required token and manifest cancellation regressions with string and plain-object reasons, asserting exact identity/value propagation and exactly one request; equivalent coverage is also required for both GHCR blob stages. Existing packages/cli/test/lib/ghcr.test.ts:441-451 covered only an Error reason.
• 🟡 (03:54) Immutable security review additionally verified installer objects were byte-identical between base and head and reiterated that all 16 changed files/tests were inspected only through immutable Git objects; no tests were executed because worktree access would violate the review constraint.
• 🟡 (03:54) Assistant decided to combine the provenance and target-channel blockers with the cancellation fix and change the prefetched API type to branded normalized arrays, enforcing provenance through both TypeScript and runtime checks.
• 🟡 (03:55) Production changes updated five files: packages/cli/src/lib/binary.ts, packages/cli/src/lib/ghcr.ts, packages/cli/src/lib/upgrade.ts, packages/cli/src/commands/cli/upgrade.ts, and packages/cli/src/lib/release-notes.ts.
• 🟡 (03:55) Assistant reported the updated production contract rejects unbranded or source-mismatched prefetched data, makes stable targets use stable changelogs, and makes pre-request cancellation paths rethrow signal.reason; test updates for branded type boundaries and primitive/object cancellation were still in progress.