Distillation

Date: Aug 24, 2026

• 🔴 (14:55) User-provided review feedback states that extractWorkspaceSelection always treats the next argv token after --workspace as the workspace name, including another flag or a missing value; this can select a bogus workspace before yargs parsing, disagree with argv.workspace, and suppress CRAFT_WORKSPACE for a valueless flag.
• 🔴 [requested-built-in-parser] (14:55) User asked, “Can we not use Node's built-in argument parser for this?” regarding src/utils/helpers.ts argument parsing.
• 🔴 [requested-version-gate-change] (14:55) User agreed that WORKSPACES_MIN_VERSION should be pushed to the next expected version; feedback says 2.27.x and 2.28.0 shipped without top-level workspaces support and the feature is heading to 2.29.0.
• 🟡 (14:55) Review feedback identified a high-severity configuration merge bug in src/config.ts#L136-L142 and src/config.ts#L456-L459: shallow-merging a workspace-only github.projectPath when top-level github is absent produces a truthy incomplete github object, causing getGlobalGitHubConfig to skip git-remote detection and return no owner/repo.
• 🟡 (14:55) Existing PR comment says commit 42d17f0 fixed the incomplete GitHub config issue by adopting merged github only when it has both owner and repo; otherwise leaving it unset so getGlobalGitHubConfig() falls back to git-remote detection. It added regression test does not produce an incomplete github when base has none.
• 🟡 (14:55) Existing PR comment says commit 42d17f0 fixed extractWorkspaceSelection so --workspace --dry-run and missing values are not workspace names and bare/empty flags do not suppress CRAFT_WORKSPACE; the function was moved to utils/helpers with unit tests, and redundant post-parse middleware that clobbered pre-parse selection was removed.
• 🟡 (14:55) Review feedback identified that versionGreaterOrEqualThan in src/config.ts#L519-L527 can throw when compared SemVer values contain build metadata such as +build123; checkMinimalConfigVersion strips metadata only for prereleases, and isVersionGteMinVersion can crash when .craft.yml specifies values such as minVersion: "2.27.0+linux".
• 🟡 (14:55) Assistant stated that PR 848 has three substantive new review points: use Node’s built-in argv parser, move the workspaces version gate to the next release, and make SemVer comparisons safe with build metadata. Assistant said it would verify the PR head and Node parser behavior, then fix all three on the PR branch without touching the user’s current branch.