Distillation

Date: Sep 4, 2026

• 🔴 [requested-read-only-audit] (13:14) User requested a final strict READ-ONLY adversarial audit of complete current uncommitted diffs and related source in both exact worktrees: /home/byk/Code/getsentry/craft-workspace-action-propagation and /home/byk/Code/getsentry/publish-workspace-acceptance.
• 🔴 (13:14) User directed that the audit must not edit files, regenerate artifacts, format files, or modify git state.
• 🔴 (13:14) User stated that action.yml Validate workspace remediation validates PATH_INPUT before any side effect; allowed input is safe concrete relative POSIX segments with . root allowed; validation must reject traversal, absolute, empty, option-like, prototype, and non-ASCII inputs before git/craft/network effects.
• 🔴 (13:14) User stated that action.yml remediation preserves workspace-input mutual exclusion, validates workspace segments, and requires titles to include the repository plus the exact full concrete workspace suffix.
• 🔴 (13:14) User stated the action must never inherit CRAFT_WORKSPACE; both prepare and targets must explicitly clear it before considering explicit action workspace input.
• 🔴 (13:14) User preference/directive: a root workspace input always is root through prepare/targets/title/state.
• 🔴 (13:14) User stated Publish remediation uses shared semantic repository/version validation in both detailsFromContext (publish controller) and getCiPollerInput (CI poller), before API endpoints, check-run parsing, checkout, state, and publish.
• 🔴 (13:14) User stated semantic validation must fail closed for malformed, ., .., __proto__, leading-dash, empty/non-token repository values and option-like/incomplete/non-semver version values; valid build metadata 4.2.6+sentry1 must remain accepted.
• 🔴 (13:14) User stated Craft glob results must require physical realpath containment under the workspace root and regression coverage must exclude external symlink matches.
• 🔴 (13:14) User directed review of: exact full path matching without normalization; action mutual exclusion; remote config root; glob safety with valid standard globs; pre-side-effect validation in all paths; root config fallback; revision before target checkout; fresh ci-ready only; state isolation with exact --rev; canonical path-only grammar; tests/generated parser/docs/diff hygiene; action shell semantics; and CI poller behavior.
• 🔴 (13:14) User required the audit response to contain only severity-ordered exact file:line findings; explicitly report PASS/CONCERN/MUST-FIX for each numbered remediation and all major workflow contracts; end exactly MERGE or DO-NOT-MERGE; never return empty.
• 🔴 (13:14) User preference/directive: always throw for unexpected values.
• 🔴 (13:14) User preference/directive: always carry the full concrete path/workspace value.
• 🟡 (13:14) Tool returned “No files found” twice before both worktree directories were successfully enumerated.
• 🟡 (13:14) Tool enumerated /home/byk/Code/getsentry/craft-workspace-action-propagation as a 33-entry directory containing .craft.yml, .git, .github/, action.yml, dist/, docs/, node_modules/, package.json, pnpm-lock.yaml, README.md, src/, tsconfig.json, and vitest.config.mts, among other listed files.
• 🟡 (13:14) Tool enumerated /home/byk/Code/getsentry/publish-workspace-acceptance as a 15-entry directory containing .git, .github/, AGENTS.md, docs/, node_modules/, package.json, README.md, scripts/, src/, vitest.config.js, and yarn.lock.
• 🟡 (13:14) publish-workspace-acceptance/AGENTS.md states this is the Sentry Publish Repository, a GitHub Actions approval system for publishing releases across Sentry projects using Craft; it is a CommonJS JavaScript project on Node.js 24.0.0.
• 🟡 (13:14) publish-workspace-acceptance/AGENTS.md specifies Yarn classic 1.22.22 via Volta and says not to use npm; commands include yarn install, yarn test, yarn test:watch, yarn test src/modules/__tests__/update-issue.js, yarn test -t "pattern", yarn lint, and yarn prettier.
• 🟡 (13:14) publish-workspace-acceptance/AGENTS.md specifies kebab-case files, camelCase variables/functions such as detailsFromContext and publishRepo, UPPER_SNAKE_CASE constants, CommonJS source modules, ES Modules test files, Prettier defaults with double quotes and semicolons, early guard-clause validation, descriptive errors, and throwing on unknown switch cases.
• 🟡 (13:14) publish-workspace-acceptance/AGENTS.md specifies Vitest v4.0.0 with globals enabled; source layout is src/libs/, src/modules/, and src/publish/; key dependencies are @actions/core, @actions/github, and @sentry/node.
• 🟡 (13:14) Partial uncommitted-diff output indicates modifications in the Craft worktree including action.yml, src/__tests__/action.test.ts, src/commands/prepare.ts, workspace/config-related source, documentation, and tests; the output is explicitly elided and does not establish complete diff contents.
• 🟡 (13:14) Partial diff text indicates documentation changed from describing craft workspace list as printing exact configured workspace names to printing concrete workspace paths as a JSON array; it states action publish titles always carry the full concrete path.
• 🟡 (13:14) Partial diff text indicates action tests were added/changed to reject path-workspace grammar values including cli\nnext and packages/*, and to exercise Read Craft Targets with prepare\ntargets\n.
• 🟡 (13:14) Partial diff text indicates workspace tests create directories such as packages/mcp and packages/cli, test glob patterns including packages/* and packages/[cm]*, create an external symlink at packages/external, and test getWorkspaceNames().
• 🟡 (13:14) Partial diff text indicates workspace/config implementation additions include getWorkspaceNamesFromConfig, glob matching with { posix: true }, physical containment logic checking realMatch.startsWith(\${realRoot}${path.sep}`), workspace-segment validation rejecting empty segments, .and likely other disallowed forms, andgit.revparse(['--show-toplevel'])`.