Distillation

Date: Sep 8, 2026

• 🔴 (03:30) User directive: New Craft requests always include the checkout repository identity.
• 🔴 (03:30) User directive: A missing root .craft.yml always means checkout-path behavior.
• 🔴 (03:30) User directive: The controller never normalizes names.
• 🟡 (03:30) docs/publish-issue-format.md now presents the canonical publish-title syntax as a generated Peggy grammar from src/modules/publish-issue-title.peggy, delimited by <!-- BEGIN GENERATED TITLE GRAMMAR --> and <!-- END GENERATED TITLE GRAMMAR -->, replacing the hand-written EBNF.
• 🟡 (03:30) Generated PublishIssueTitle grammar requires "publish: ", optional "getsentry/", repo:Repository, optional path:Path, "@", version:Version, and end-of-input !.; returns { repo, path: path || "", version }. RepositoryCharacter is [A-Za-z0-9_.-]; Path comprises one or more "/"-prefixed PathSegments; Version is [A-Za-z0-9_.+-]+.
• 🟡 (03:30) Publish-issue documentation clarifies that the title path suffix is syntactic only; after checking out the CI-approved revision from the View check runs link, the controller treats a suffix as a workspace only if it exactly matches a concrete workspace path returned by craft workspace list from a checkout with root .craft.yml; otherwise it remains a checkout path. Root-configuration discovery errors fail the release.
• 🟡 (03:30) Documentation examples distinguish root release publish: getsentry/sentry@21.3.1 from workspace release publish: getsentry/toolkit/packages/cli@1.2.3, whose title suffix is the full concrete workspace path.
• 🟡 (03:30) Added src/modules/__tests__/generate-publish-issue-title-parser.js: generateDocumentation() must throw "Could not find the generated title grammar in the documentation." when docs/publish-issue-format.md lacks generated-title-grammar markers or contains duplicate BEGIN/END marker blocks.
• 🟡 (03:30) The documentation-generation script reads the current generated parser/documentation content and only writes docs/publish-issue-format.md when documentation !== generatedDocumentation.
• 🟡 (03:30) details-from-context tests verify parsing inputs returns { dry_run: "", merge_target: "custom-branch", path: ".", repo: "sentry", targets: ["github", "npm[@sentry/node]", "docker[latest]"], version: "21.3.1" }.
• 🟡 (03:30) Publish-title validation tests reject an unexpected space before version, e.g. publish: getsentry/toolkit @1.2.3, and unsafe checkout repository identities -toolkit, ., .., and __proto__, throwing "Invalid publish issue repository".
• 🟡 (03:30) Publish workflow state-file tests ensure versions differing only in case do not collide: 4.2.6+sentry1 versus 4.2.6+Sentry1.
• 🟡 (03:30) release-revision tests reject an appended/embedded decoy [View check runs](https://github.com/getsentry/toolkit/commit/<40 a's>/checks/) link outside the request-header Quick links block, throwing "Expected exactly one View check runs link in Quick links".
• 🟡 (03:30) src/modules/details-from-context.js target-section parsing uses TARGETS_SECTION_PARSER_REGEX = /^(?!### Targets$\s)(?: *- \[[ xX]\] \S+\s*$(?:\r?\n)?)+/m and extracts checked target strings with CHECKED_TARGETS_PARSER_REGEX; the negative lookahead prevents treating the ### Targets header itself as a target item.
• 🟡 (03:30) src/publish/__tests__/resolve-release-revision.js runs resolve-release-revision.js with PUBLISH_ARGS: "" and PUBLISH_ISSUE_BODY: ""; it must exit nonzero, include "Publish input must define a repository." in stderr, and not include "Unexpected end of JSON input".
• 🟡 (03:31) src/publish/__tests__/resolve-location.js runs resolve-location.js with PUBLISH_ARGS: "" and CRAFT_WORKSPACE_NAMES: "[]"; it must exit nonzero, include "Invalid publish path." in stderr, and not include "Unexpected end of JSON input".