Distillation

Date: September 8, 2026

• 🔴 [requested-review] (19:08) User requested a substantive read-only correctness review of the frozen OpenCode V2 pilot implementation in /home/byk/Code/opencode-v2-pilot, using exact current files rather than memory.
• 🔴 [enforced-read-only] (19:08) User prohibited editing files, starting or stopping services, installing anything, or exposing secrets during the review; read-only hashes, typechecks, and package tests are permitted.
• 🔴 (19:08) User identified repository Base HEAD as 2ac698d65aa4690a694307e9cbdf44537ea9a4fb and expected tracked binary diff SHA-256 as e3d14c2a661025b56eb941304df6c5d217d0dd95c8d01497e78011d3e990a34a.
• 🔴 (19:08) User stated the tracked modified files must be exactly: packages/core/src/plugin/host.ts, packages/core/test/plugin.test.ts, packages/core/test/plugin/fixture.ts, packages/core/test/plugin/host.ts, packages/plugin/src/effect/permission.ts, packages/plugin/src/promise/adapter.ts, and packages/plugin/src/promise/permission.ts.
• 🔴 (19:08) User requested inspection of /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/followup.ts with expected SHA-256 8d51037989aa2cbfa10de82b56ef9512218a07544a5308a74890d59252f43bad.
• 🔴 (19:08) User requested inspection of /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/pty.ts with expected SHA-256 b90315811f1ff67cd93d48676dda2fa02d9be0694bf154a049c8746a8ed11aa5.
• 🔴 (19:08) User requested inspection of /home/byk/.local/share/opencode-v2-pilot/config/opencode/test/followup.test.ts with expected SHA-256 507a152473809a95363a3758ab39fb6e8f5c82f32c23a9f11d7655607951f7ec.
• 🔴 (19:08) User requested inspection of /home/byk/.local/share/opencode-v2-pilot/config/opencode/test/pty.test.ts with expected SHA-256 c2bed5de452d64198e20cb4255e276e7b37be4b9fd60ee0f4bd98ccac14288b3.
• 🔴 (19:08) User requested inspection of /home/byk/.local/share/opencode-v2-pilot/config/opencode/opencode.json with expected SHA-256 571a0730c86bde522edf63516b7fa69cb9cbf2ff8730e15e2a8ce064c33ad905.
• 🔴 (19:08) User requested inspection of /home/byk/.local/share/opencode-v2-pilot/config/opencode/service-v2-pilot.json with expected SHA-256 0dbe0518ab13584c3a4ae465fb552d79572460766910ff9f7ea4271280d66bb0.
• 🔴 (19:08) User requested inspection of /home/byk/.local/share/opencode-v2-pilot/opencode-v2.service with expected SHA-256 38fc8a7f4b25acf611557c32380365f3f7d0422f8a31d0f5eb7ffba48e916045.
• 🔴 (19:08) User requested inspection of /home/byk/.local/share/opencode-v2-pilot/CUTOVER.md with expected SHA-256 31ce6b09b9448660dfed2ebd9f4a44e6e033cc0753ef978253db02884fc68b2b.
• 🔴 (19:08) User requested inspection of final SEA /home/byk/Code/opencode-v2-pilot/packages/cli/dist-v2-pilot-byk/cli-node-linux-x64/bin/opencode2-node with expected SHA-256 c67985bbc31f99e040ed58abf2aa37fc7c9a197a46c269eafaec468d99658937.
• 🔴 (19:08) User stated the chosen trust model deliberately matches existing production: OpenCode service, PTYs, and children run unprivileged as account byk, under systemd User=byk and NoNewPrivileges=yes.
• 🔴 (19:08) User stated the chosen trust model has no root helper, supervisor, or readiness marker.
• 🔴 (19:08) User stated dormant directory /home/byk/.local/share/opencode-v2-pilot/supervisor is explicitly excluded from activation and cutover and must not be reviewed as active implementation.
• 🔴 (19:08) User stated deliberately daemonized descendants that escape both tracked process groups are outside the chosen trust model, matching current production opencode-pty; absence of a stronger containment model alone is not grounds for rejection, though inaccuracies or defects relative to the stated model must be reported.
• 🟡 (19:08) User asked the review to assess the Promise permission.assert bridge across Effect typed errors, defects, interruption, DeclinedError, CorrectedError feedback, and Tool.Error conversion.
• 🟡 (19:08) User asked the review to assess direct PTY lifecycle and races covering synchronous reservations, late spawn, process and command process groups, startup failures/timeouts, fd-pinned cwd, output-before-listener, UTF-8 decoding and bounds, line paging, regex workers, Session ownership/deletion, plugin cleanup, timer cleanup, status ordering, and exactly-once notifications.
• 🟡 (19:08) User asked the review to assess five-tool behavior and canonical permission assertions immediately before spawn, write, and kill side effects.
• 🔴 (19:08) User directed that save must never turn model text into wildcard grants.
• 🟡 (19:08) User asked the review to assess service/cutover consistency and rollback safety.
• 🔴 (19:08) User stated production must remain untouched until explicit approval and the V2 database must remain isolated.
• 🔴 [requested-tests] (19:08) User required tests to exercise actual behavior and include fail-first evidence where relevant; residual test gaps must be reported separately from defects.
• 🟡 (19:08) User asked the review to ensure no active reference to pty-transport or the root supervisor remains in active plugin, config, unit, or cutover paths.
• 🔴 (19:08) User directed that package tests must never be run from the repository root.
• 🔴 (19:08) User required --printConsoleTrace for Vitest/Bun diagnostic tests.
• 🔴 (19:08) User prohibited inspecting or printing credential values.
• 🔴 (19:08) User stated untracked build artifacts must never be staged.
• 🔴 (19:08) User required the report to be concise but substantive, cite current file:line evidence, and classify every finding as PASS, CONCERN, or MUST-FIX.
• 🔴 (19:08) User required the report to end exactly with MERGE if no MUST-FIX remains, otherwise DO-NOT-MERGE; if evidence gathering is blocked, the exact tool/error must be named and the report must end DO-NOT-MERGE.
• 🔴 (19:10) Effect workflow instructions require consulting current Effect v4 / effect-smol source and nearby repository code rather than relying on memory or older Effect v2/v3 examples; .opencode/references/effect-smol is the designated source checkout when needed.
• 🔴 (19:10) Effect testing instructions require running tests from package directories such as packages/opencode, never from the repository root, and favor testEffect(...), it.live(...), explicit layers, scoped fixtures, and finalizers for applicable behavior.
• 🔴 (19:11) Repository dependency direction is Schema → Core and Protocol → Server; Client runtime code may depend on Schema and Protocol but never Core or Server; sdk composes Client, Core, and Server.
• 🔴 (19:11) Repository instructions require always running bun typecheck from package directories such as packages/core, never invoking tsc directly.
• 🔴 (19:11) Repository instructions prohibit aliased imports: never use forms such as import { foo as bar } from "..." or resolve as pathResolve; an aliased type import is allowed only as a last resort for a genuine collision.
• 🔴 (19:11) Repository instructions prohibit star imports and type-position import("...") references; namespace-style values should use the module’s own named exported namespace, such as import { Project } from "@opencode/core/project" and Project.ID.
• 🔴 (19:11) Repository test instructions require testing the actual implementation, avoiding duplicated implementation logic in tests, minimizing mocks, and avoiding globalThis.* unless it is the only option.
• 🔴 (19:12) packages/plugin/AGENTS.md states the plugin package has Effect and Promise versions; every Effect-version domain must extend the corresponding Effect API client interface from @opencode/client/effect/api, must not redefine existing client functions, and may add only plugin-context-specific functions.
• 🟡 (19:12) Repository verification showed HEAD exactly 2ac698d65aa4690a694307e9cbdf44537ea9a4fb.
• 🟡 (19:12) Repository verification showed exactly the seven expected tracked modifications: packages/core/src/plugin/host.ts, packages/core/test/plugin.test.ts, packages/core/test/plugin/fixture.ts, packages/core/test/plugin/host.ts, packages/plugin/src/effect/permission.ts, packages/plugin/src/promise/adapter.ts, and packages/plugin/src/promise/permission.ts.
• 🟡 (19:12) The tracked binary diff SHA-256 was verified as exactly e3d14c2a661025b56eb941304df6c5d217d0dd95c8d01497e78011d3e990a34a.
• 🟡 (19:12) Repository status showed eight untracked build artifacts: packages/cli/dist-v2-pilot-byk/cli-node-linux-x64/bin/opencode2-node, packages/cli/dist-v2-pilot-byk/cli-node-linux-x64/package.json, packages/cli/dist-v2-pilot-final/cli-node-linux-x64/bin/opencode2-node, packages/cli/dist-v2-pilot-final/cli-node-linux-x64/package.json, packages/cli/dist-v2-pilot-next/cli-node-linux-x64/bin/opencode2-node, packages/cli/dist-v2-pilot-next/cli-node-linux-x64/package.json, packages/cli/dist-v2-pilot/cli-node-linux-x64/bin/opencode2-node, and packages/cli/dist-v2-pilot/cli-node-linux-x64/package.json.
• 🟡 (19:13) All nine requested external/final artifact hashes matched their expected SHA-256 values exactly: followup.ts → 8d51037989aa2cbfa10de82b56ef9512218a07544a5308a74890d59252f43bad; pty.ts → b90315811f1ff67cd93d48676dda2fa02d9be0694bf154a049c8746a8ed11aa5; followup.test.ts → 507a152473809a95363a3758ab39fb6e8f5c82f32c23a9f11d7655607951f7ec; pty.test.ts → c2bed5de452d64198e20cb4255e276e7b37be4b9fd60ee0f4bd98ccac14288b3; opencode.json → 571a0730c86bde522edf63516b7fa69cb9cbf2ff8730e15e2a8ce064c33ad905; service-v2-pilot.json → 0dbe0518ab13584c3a4ae465fb552d79572460766910ff9f7ea4271280d66bb0; opencode-v2.service → 38fc8a7f4b25acf611557c32380365f3f7d0422f8a31d0f5eb7ffba48e916045; CUTOVER.md → 31ce6b09b9448660dfed2ebd9f4a44e6e033cc0753ef978253db02884fc68b2b; final SEA opencode2-node → c67985bbc31f99e040ed58abf2aa37fc7c9a197a46c269eafaec468d99658937.