Distillation

Date: Sep 16, 2026

• 🔴 (23:50) User’s regression-test discipline requires every adversarial-review defect to land a deterministic regression test in the same PR: it must fail on the base branch, pass on the fix, and drive the real precondition rather than an artificially constructed state.
• 🔴 (23:50) User’s guard-test standard: deleting the guard must make its test fail; a test that still passes without the guard is not testing the guard.
• 🔴 (23:50) User’s adversarial state-setup standard requires: 1. relevant state exists before the operation that should handle it, 2. delete-then-recreate sequences cross lifecycle boundaries, and 3. content is modified while sync is disabled so capture triggers cannot observe it.
• 🔴 (23:50) User’s fan-out registry contract mapping: SYNCED_TABLES → sync-registry-contract.test.ts covering each table’s shape, pull-only/no-capture invariant, composite-PK correctness; MIGRATIONS → db.test.ts schema-version assertion plus migration-specific tests, including one toBe(MIGRATIONS.length) assertion; AGENTS → agents.test.ts, requiring every agent to have name, displayName, binary, and detect(), with binary a constant placeholder string.
• 🔴 (23:50) User’s standing bug-class batteries are: 1. Registry contract in packages/core/test/sync-registry-contract.test.ts, covering SYNCED_TABLES shape, pull-only guard, id-column correctness, and versioned flag; 2. Sync invariants in packages/core/src/sync-data.ts via assertSyncInvariants, covering no pull-only outbox, profiles ≤ 1, and every state row referencing a registered table; 3. Sequence properties in packages/gateway/test/sync.property.test.ts, covering invariants after every operation, prune-floor never wedging, eventual convergence, no ping-pong, and currentTier correctness.
• 🔴 (23:50) User stated skip/early-return branches are the highest-risk surface; NOT EXISTS, latest <> 'upsert', and content-match guards previously masked data-loss bugs, so every skip branch needs a test that makes it fire wrongly and proves it does not skip valid work.
• 🔴 (23:50) User stated property-based tests over faithful mocks catch defects missed by example tests; the #833 property battery surfaced four sequence-dependent sync-engine bugs across enable/disable/push/pull boundaries.
• 🔴 (23:50) User’s TDD rule is: “Never trust the fix without seeing it fail.” Every bug fix must begin with a regression test confirmed failing on the base branch and then passing on the fix.
• 🔴 (23:50) User stated memoized arrays shared by multiple callers should be frozen so accidental mutation raises TypeError in strict mode instead of silently corrupting the cache.
• 🔴 (23:50) User stated db().query monkeypatches are shadowed by the tracing Proxy; SQL-counting tests must use the log.registerSink({ withDbSpan }) seam because direct db().query = ... patches are silently ignored.
• 🔴 (23:50) Review execution requirements in quality/REVIEW.md: run pnpm test, pnpm run typecheck, pnpm run lint, and pnpm run format:check; check exit codes because a blank tail may conceal lint/format failure; run property tests ×10; hash-verify the working tree remains unmodified; report per-point PASS / FAIL / CONCERN / MUST-FIX with file:line evidence and an overall MERGE / DO-NOT-MERGE verdict.
• 🔴 (23:50) Correctness-critical changes involving the sync engine, hashing, lifecycle, or migrations require adversarial review regardless of size; mechanical or test-only PRs may skip it at reviewer discretion.
• 🟡 (23:50) Current Jujutsu working copy is revision tmzmtlss / commit 8888d203, description fix(core): correct embedding runtime selection and admission, on bookmark fix/embedding-runtime-admission; parent is pxrvwsvv / 2cbf4006 on main, description feat(cch): add seeds for Claude Code up to 2.1.272 (#1780).
• 🟡 (23:50) Current working-copy files are: added packages/core/src/cgroup-memory.ts; modified packages/core/src/embedding/local.ts, packages/core/src/embedding/pool.ts, packages/core/src/embedding-cap.ts, packages/core/src/embedding-worker-types.ts, packages/core/src/embedding-worker.ts, packages/core/src/embedding.ts, and packages/core/src/ort-native.ts; added packages/core/test/cgroup-memory.test.ts; modified packages/core/test/embedding-cap.test.ts, packages/core/test/embedding-pool-memory.test.ts, packages/core/test/embedding-pool.test.ts, packages/core/test/embedding-wasm-fallback.test.ts, packages/core/test/embedding-worker-stdio.test.ts, packages/core/test/embedding-worker-types.test.ts, packages/core/test/ort-native.test.ts, packages/gateway/script/bundle.ts, packages/gateway/script/ort-platform-package.ts, packages/gateway/test/bundle-exports.test.ts, and packages/gateway/test/ort-platform-package.test.ts.
• 🟡 (23:50) Jujutsu reported a conflicting bookmark named fix/responses-private-references.
• 🔴 (23:51) Native ONNX Runtime resolution must be fail-closed and “must never interrupt WASM fallback.”
• 🔴 (23:51) Native package resolution may inspect only the worker package’s own node_modules; it “never selects an arbitrary” package outside that boundary.
• 🔴 (23:51) Native binding resolution “Never throws: an unresolvable package is the expected dist-only case” and must allow fallback rather than abort initialization.
• 🟡 (23:51) Working-copy diff removes the free-form error: string field from InitNeedsWasm in packages/core/src/embedding-worker-types.ts, leaving the outbound message as only type: "init-needs-wasm".
• 🟡 (23:51) Working-copy diff adds isNativeOrtLoadError(msg: string): boolean to distinguish failure to load a selected native ONNX Runtime addon.
• 🟡 (23:51) Working-copy diff adds resolveNativeOrtBindingPath(...), uses LORE_ORT_NODE_VERSION, validates package manifests and expected ONNX Runtime versions, checks canonical bindings with realpathSync/statSync, and treats failed resolution as a non-throwing fallback condition.