Distillation

Date: Sep 8, 2026

• 🔴 [requested-review] (08:13) User requested a final substantive independent READ-ONLY correctness review of the exact current source and artifacts under /home/byk/.local/share/opencode-v2-pilot/supervisor; plugin files /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/pty.ts and /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/pty-transport.ts; canonical tsconfig/package files; candidate unit; /home/byk/.local/share/opencode-v2-pilot/CUTOVER.md; and persistent/temp PTY tests.
• 🔴 (08:13) User stated immutable claimed source manifest SHA-256 is fff146df36754bc59d473a070985c4310cb57bdad64473ec7f68b5be5014286f.
• 🔴 (08:13) User stated claimed artifact SHA-256 hashes: supervisor ff03df72fc6a401e8070db776ceba524e9111d9d907c6f4939244354564a86f2; launcher d833c859476f021565e8f425e6ee51353909060fa5f64ce629fb07d3411987dd; client fb8739d98ff7882782005e04ef731b6120e8daf0719e606362a1fe620adc2cde.
• 🔴 (08:13) User required verification of prior correctness blockers: bounded STOP write; truthful helper documentation; canonical exact tsgo passing without hiding files; exact Node 26 SEA testing remaining a root acceptance requirement unless proven; persistent test evidence; end-to-end framing and limits; cwd fd behavior; helper inheritance; lifecycle; output queue; cleanup; systemd interfaces; signal proof; admission reservation; readiness verifier; and build reproducibility.
• 🔴 (08:13) User required inspection of every changed file, relevant pinned APIs, and tests, with unprivileged checks permitted when useful.
• 🔴 [enforced-read-only-workflow] (08:13) User directed that the review must never edit or install anything, never start or stop services, and never perform privileged actions.
• 🔴 (08:13) User required source approval to be distinguished from root-host acceptance.
• 🔴 (08:13) User required current file:line citations, classifications of PASS, CONCERN, or MUST-FIX, and a final response ending exactly with MERGE or DO-NOT-MERGE.
• 🟡 (08:13) Assistant established a five-step review plan in exact order: 1. inventory exact review scope and verify immutable source/artifact hashes; 2. inspect every source, config, unit, CUTOVER, and PTY test file with pinned APIs; 3. run canonical unprivileged typecheck, tests, reproducibility, and artifact checks; 4. trace each prior blocker and end-to-end correctness invariant to evidence; 5. deliver a classified independent verdict with root acceptance separated.
• 🟡 (08:13) Supervisor review inventory included review-source-hash, verify-readiness, ROOT-ACCEPTANCE.md, PROTOCOL.md, binaries bin/opencode-pty-client, bin/opencode-pty-launcher, and bin/opencode-pty-supervisor, units opencode-pty.slice and opencode-pty-supervisor.service, go.mod, go.sum, and Go code/tests under cmd/client, cmd/launcher, cmd/supervisor, internal/protocol, and internal/supervisor.
• 🟡 (08:13) Relevant top-level/config artifacts discovered included /home/byk/.local/share/opencode-v2-pilot/CUTOVER.md, /home/byk/.local/share/opencode-v2-pilot/opencode-v2.service, /home/byk/.local/share/opencode-v2-pilot/config/opencode/tsconfig.json, /home/byk/.local/share/opencode-v2-pilot/config/opencode/package.json, /home/byk/.local/share/opencode-v2-pilot/config/opencode/bun.lock, and /home/byk/.local/share/opencode-v2-pilot/config/opencode/test/followup.test.ts.
• 🟡 (08:14) In-scope project tests identified were /home/byk/.local/share/opencode-v2-pilot/supervisor/cmd/client/main_test.go, /home/byk/.local/share/opencode-v2-pilot/supervisor/cmd/launcher/main_test.go, /home/byk/.local/share/opencode-v2-pilot/supervisor/internal/supervisor/auth_test.go, /home/byk/.local/share/opencode-v2-pilot/supervisor/internal/supervisor/server_test.go, /home/byk/.local/share/opencode-v2-pilot/supervisor/internal/supervisor/systemd_test.go, /home/byk/.local/share/opencode-v2-pilot/supervisor/internal/protocol/frame_test.go, and /home/byk/.local/share/opencode-v2-pilot/config/opencode/test/followup.test.ts.
• 🟡 (08:14) Current hashes measured: review-source-hash file f231f9f8c57fbcadda3a32c7559cd3e45421647312269e04a6798187566584f6; bin/opencode-pty-supervisor ff03df72fc6a401e8070db776ceba524e9111d9d907c6f4939244354564a86f2; bin/opencode-pty-launcher d833c859476f021565e8f425e6ee51353909060fa5f64ce629fb07d3411987dd; bin/opencode-pty-client fb8739d98ff7882782005e04ef731b6120e8daf0719e606362a1fe620adc2cde.
• 🟡 (08:14) Running /home/byk/.local/share/opencode-v2-pilot/supervisor/review-source-hash recomputed the immutable source manifest exactly as fff146df36754bc59d473a070985c4310cb57bdad64473ec7f68b5be5014286f.
• 🟡 (08:14) review-source-hash derives ROOT from its parent directory, hashes sorted unique inputs from $ROOT/supervisor/cmd and $ROOT/supervisor/internal Go files, all TypeScript files under /home/byk/Code/opencode-v2-pilot/packages/plugin/src, and explicit files $ROOT/supervisor/go.mod, $ROOT/supervisor/go.sum, $ROOT/supervisor/opencode-pty.slice, $ROOT/supervisor/opencode-pty-supervisor.service, $ROOT/config/opencode/plugins/pty.ts, $ROOT/config/opencode/plugins/pty-transport.ts, $ROOT/config/opencode/tsconfig.json, $ROOT/config/opencode/package.json, $ROOT/config/opencode/bun.lock, $ROOT/opencode-v2.service, /home/byk/Code/opencode-v2-pilot/packages/plugin/package.json, and /home/byk/Code/opencode-v2-pilot/bun.lock; it uses LC_ALL=C /usr/bin/sort -u, /usr/bin/sha256sum, and /usr/bin/cut -d ' ' -f 1.
• 🟡 (08:14) Assistant reported that the immutable source manifest matched exactly and all three binaries matched their claimed hashes.
• 🟡 (08:14) Checkout status showed modified files packages/core/src/plugin/host.ts, packages/core/test/plugin.test.ts, packages/core/test/plugin/fixture.ts, packages/core/test/plugin/host.ts, packages/plugin/src/effect/permission.ts, packages/plugin/src/promise/adapter.ts, and packages/plugin/src/promise/permission.ts; untracked directories were packages/cli/dist-v2-pilot-final/, packages/cli/dist-v2-pilot-next/, and packages/cli/dist-v2-pilot/.
• 🟡 (08:14) Assistant decided to include the relevant uncommitted plugin/core API diffs and their tests in the contract review rather than trusting only the staged pilot copies.
• 🟡 (08:15) Inspected PTY plugin source exposed technical constants and checks including CLOSE_TIMEOUT_MS = 27_000, a kill option described as "Kill the PTY after this many seconds.", per-session admission reservations via reservations.get(context.sessionID) ?? 0, command byte-length enforcement through MAX_COMMAND_LENGTH, permission checks via ctx.permission.assert, and a cwd race guard that throws Working directory changed before spawn: ${workdir}.