Distillation

Date: Sep 16, 2026

• 🔴 (12:50) User stated undici remains external and is imported lazily only on the Node path in fetch.ts, so it is never bundled or evaluated under Bun; real undici@7 hangs on streaming response reads under Bun.
• 🔴 (12:50) User stated the Bun path uses native fetch and never touches undici; keeping undici as a devDependency is safe only because the Bun path never imports it, and it must become a runtime dependency if that changes.
• 🔴 (12:50) User stated the npm CJS embedding worker is emitted as packages/gateway/dist/embedding-worker.cjs, while the Bun ESM worker is emitted as packages/gateway/dist/embedding-worker.js; both use ortNpmDualPlugin() to prefer native ONNX Runtime and fall back to shipped WASM.
• 🔴 (12:50) User stated the Bun ESM embedding worker can dlopen the ONNX Runtime .node addon and preserves the dist-only WASM fallback through globalThis.__LORE_NPM_WASM_PATHS__ || ONNX_ENV.wasm.wasmPaths.
• 🔴 (12:50) User stated the shipped ort-wasm-simd-threaded.mjs is unpatched, unlike the SEA binary’s copy, and is safe only because embedding-worker.ts forces numThreads=1; therefore ort-web takes its single-thread path and never calls its pthread new Worker(...), which would crash under Node because that worker has no global Worker.
• 🔴 (12:50) User stated that if numThreads changes, the copied ort-wasm-simd-threaded.mjs must be patched like build-binary-sea to avoid a latent Node crash.
• 🔴 (12:50) User stated native ONNX Runtime resolution is fail-closed and must never interrupt WASM fallback.
• 🟡 (12:50) Assistant determined source-level native checks passed and said the remaining proof must execute both emitted workers in their supported runtimes, showing that an unloadable native addon causes exactly one controlled WASM retry without network access or a real model.
• 🟡 (12:51) Focused Vitest v4.1.8 run passed exactly 13 tests in 1 test file; duration was 1.96s, with transform 692ms, setup 746ms, import 22ms, tests 981ms, and environment 0ms.
• 🟡 (12:51) Assistant reported focused admission and emitted-bundle validation green with 280 source tests plus 13 artifact tests, and planned to check the final diff against every review finding, run guard-removal proofs, then execute full repository gates.
• 🟡 (12:52) packages/gateway/test/bundle-exports.test.ts now tests both embedding-worker.cjs and embedding-worker.js for an emitted native ORT compatibility resolver: artifacts must omit LORE_ORT_NODE_VERSION and contain loreOrtNodeVersion, glibcVersionRuntime, and the gateway’s declared onnxruntime-node version.
• 🟡 (12:52) Emitted-worker unloadable-addon regression in packages/gateway/test/bundle-exports.test.ts runs on supported targets linux-x64, linux-arm64, darwin-arm64, win32-x64, and win32-arm64; a preload intercepts process.dlopen, marks selection of onnxruntime_binding.node, throws onnxruntime_binding.node: file too short, blocks network through a throwing globalThis.fetch, posts an embed request using model lore-test/no-network-model, dimensions 64, maxTokens: 32, text ["probe"], inputType: "query", and priority: "high", then expects type: "init-needs-wasm" containing file too short. The probe timeout is 10_000 ms and test timeout is 30_000 ms.
• 🟡 (12:52) Malformed-addon regression in packages/gateway/test/bundle-exports.test.ts creates a temporary dist-only @loreai/gateway installation and matching @loreai/onnxruntime-${target} optional dependency at version 9.9.9, copies embedding-worker.cjs/embedding-worker.js, ort-wasm-simd-threaded.mjs, and ort-wasm-simd-threaded.wasm, writes onnxruntime_binding.node as "not a native addon", and verifies the malformed file is rejected before process.dlopen; the worker then reaches WASM fallback and emits type: "init-error" containing lore-wasm-probe-stop, while the native-load marker remains absent.
• 🟡 (12:53) Jujutsu working copy was tmzmtlss e6d0f1ed on fix/embedding-runtime-admission, description fix(core): correct embedding runtime selection and admission, with parent pxrvwsvv 2cbf4006 main | feat(cch): add seeds for Claude Code up to 2.1.272 (#1780).
• 🟡 (12:53) Jujutsu reported a conflicting bookmark fix/responses-private-references; suggested inspection with jj bookmark list and resolution with jj bookmark set <name> -r <rev>.
• 🟡 (12:53) packages/core/src/cgroup-memory.ts implements live Linux cgroup memory discovery: parses /proc/self/cgroup and /proc/self/mountinfo, decodes octal procfs path escapes, rejects nonabsolute paths, NULs, and .. segments, prefers an explicit cgroup v1 memory controller over v2 on hybrid hosts, chooses the most-specific direct mount root, and accepts a namespaced interpretation only when exactly one matching mount exists.
• 🟡 (12:53) readLinuxCgroupMemoryHeadroomBytes() in packages/core/src/cgroup-memory.ts rereads procfs on every call so live cgroup moves and cached discovery misses cannot admit a worker from stale data; v2 uses memory.current against both memory.high and memory.max, v1 uses memory.usage_in_bytes against memory.limit_in_bytes, and inherited limits are traversed through parent directories with the tightest finite headroom selected.
• 🟡 (12:53) Cgroup parsing fails closed to undefined for malformed or unsafe numeric values, unreadable constrained boundaries, invalid traversal, ambiguous discovery, or other read errors; "max" and limits above Number.MAX_SAFE_INTEGER are treated as infinite. A cgroup v2 mount root with root / may omit memory files, but every descendant boundary must remain readable.
• 🟡 (12:54) Current change spans exactly 18 files with 1,818 insertions and 90 deletions: packages/core/src/cgroup-memory.ts (+205, new), packages/core/src/embedding/local.ts, packages/core/src/embedding/pool.ts, packages/core/src/embedding-cap.ts, packages/core/src/embedding-worker-types.ts, packages/core/src/embedding-worker.ts, packages/core/src/embedding.ts, packages/core/src/ort-native.ts, packages/core/test/cgroup-memory.test.ts (+297, new), packages/core/test/embedding-cap.test.ts, packages/core/test/embedding-pool-memory.test.ts, packages/core/test/embedding-pool.test.ts, packages/core/test/embedding-worker-types.test.ts, packages/core/test/ort-native.test.ts, packages/gateway/script/bundle.ts, packages/gateway/script/ort-platform-package.ts, packages/gateway/test/bundle-exports.test.ts, and packages/gateway/test/ort-platform-package.test.ts.