Distillation

Date: Sep 3, 2026

• 🔴 (23:18) User directive/preference: action publish titles should always carry the full concrete workspace path (“always carry the full concrete”).
• 🟡 (22:36) Tool inspection identified two modified worktrees under /home/byk/Code/getsentry: craft-workspace-action-propagation on branch feat/workspace-action-propagation with 5 modified files (action.yml, docs/src/content/docs/targets/github.md, src/__tests__/action.test.ts, src/__tests__/config.test.ts, src/config.ts; 187 insertions, 37 deletions), and publish-workspace-acceptance on branch feat/workspace-acceptance with 13 modified files (including .github/workflows/publish.yml, docs/publish-issue-format.md, workspace/publish modules and tests; 76 insertions, 555 deletions).
• 🟡 (22:36) Two file-search tool invocations returned “No files found.”
• 🟡 (23:18) action.yml workspace-input validation was changed from accepting one compact workspace name matching /^(?!\.{1,2}$)(?!__proto__$)(?!-)[A-Za-z0-9_.-]+$/ to accepting slash-delimited paths whose every segment matches /^[A-Za-z0-9_.-]+$/, is not ., .., or __proto__, and does not start with -. The validation error changed to: Workspace names must use ASCII path segments containing only letters, digits, periods, underscores, and hyphens.
• 🟡 (23:18) Documentation in docs/src/content/docs/targets/github.md now defines workspace keys as literal paths or glob patterns expanded to concrete directories relative to .craft.yml; --workspace <path> / CRAFT_WORKSPACE must select one concrete path. Example keys changed from cli and mcp to packages/* and tools/mcp; craft workspace list now outputs concrete workspace paths as JSON; configured globs resolving to files and overlapping workspace keys are rejected; action publish titles carry the full concrete path.
• 🟡 (23:18) src/__tests__/action.test.ts changed action-input coverage: accepted workspace inputs are '', cli-v2, and packages/cli; rejected path-grammar inputs are cli\nnext and packages/*; rejected unsafe paths are ./packages/cli, packages/../cli, and packages/__proto__/cli. The publish-title test now runs packages/cli and expects publish: getsentry/toolkit/packages/cli@1.2.3\n rather than compact cli.
• 🟡 (23:18) src/__tests__/config.test.ts added glob-workspace coverage using temporary .craft.yml configuration with workspaces: packages/*, creating directories packages/cli and packages/mcp, expecting getWorkspaceNames() to return ['packages/cli', 'packages/mcp'], and verifying active packages/cli inherits releaseBranchPrefix: release/package.
• 🟡 (23:18) src/__tests__/config.test.ts added an overlap test for keys packages/* and packages/cli*, expecting both getWorkspaceNames() and getConfiguration(true) for active packages/cli to throw an error stating it matches multiple workspace patterns: packages/*, packages/cli*.
• 🟡 (23:18) src/config.ts now imports globSync and hasMagic from glob; workspace resolution uses getWorkspaceConfig() rather than direct key lookup. Concrete selected workspace names cannot themselves be glob patterns, literal keys match exactly, pattern keys match only if the concrete directory appears in getWorkspaceGlobMatches(), and multiple matching keys throw ConfigurationError.
• 🟡 (23:18) src/config.ts added getWorkspaceNamesFromConfig(): expands every glob workspace key, detects duplicate concrete paths matched by multiple keys, throws ConfigurationError on overlaps, and returns sorted concrete workspace names. getWorkspaceGlobMatches() runs globSync(workspaceGlob, { absolute: false, cwd: path.dirname(getConfigFilePath()), dot: true, ignore: ['**/node_modules/**'] }), filters matches using lstatSync(...).isDirectory(), and sorts results. isWorkspacePattern() uses hasMagic(name, { magicalBraces: true }).
• 🟡 (23:18) src/config.ts changed workspace-selection errors to list expanded concrete workspace names instead of raw config keys, and getWorkspaceNames() now returns expanded concrete names after validating configuration/minimum versions.
• 🟡 (23:18) src/config.ts cache behavior changed: setActiveWorkspace() also invalidates _configPathCache; findConfigFile() reuses _configPathCache only when existsSync(_configPathCache) is true, otherwise clears it before searching.