Distillation

Date: Sep 17, 2026

• 🟡 (09:56) V23 source validation passed with 0 failures and 0 warnings in 146.25s: packages/core bun test --printConsoleTrace — 1,194 passed, 0 failed, 3,374 assertions across 145 files in 71.62s; packages/core bun typecheck — no diagnostics in 10.74s; packages/schema bun test --printConsoleTrace test/event-manifest.test.ts — 2 passed, 0 failed, 23 assertions in 1 file in 0.29s; packages/schema bun typecheck — no diagnostics in 1.88s; packages/sdk/js bun typecheck — no diagnostics in 0.36s; packages/server bun typecheck — no diagnostics in 12.15s; packages/opencode bun typecheck — no diagnostics in 45.85s; packages/client bun typecheck — no diagnostics in 3.36s.
• 🟡 (09:56) V23 validation noted one expected Core error from a missing skill-download fixture plus informational watcher messages; neither caused failures. No files were edited or formatted, VCS and services were untouched, and check:generated was not run.
• 🟡 (09:56) Migration hygiene found no incremental schema changes. A full migration was generated at /tmp/opencode-core-migration-check-MlmNuG/full/20260917095607_schema/migration.sql using /tmp/opencode-core-migration-check-MlmNuG/full.config.ts; incremental config was /tmp/opencode-core-migration-check-MlmNuG/incremental.config.ts.
• 🟡 (09:58) Frozen V23 patch /tmp/opencode/session-recovery-final-v23.patch had SHA-256 14035d7631ba25b820fdc553087469935f447af034d549e2f14f8a141eda59dc, exactly 34 changed paths, 8,958 insertions, and 484 deletions.
• 🟡 (09:58) V23’s 34 changed paths were: packages/client/src/generated/types.ts; packages/core/schema.json; packages/core/src/database/migration.gen.ts; packages/core/src/database/migration/20260914170650_session-recovery.ts; packages/core/src/database/schema.gen.ts; packages/core/src/session.ts; packages/core/src/session/compaction.ts; packages/core/src/session/context-epoch.ts; packages/core/src/session/execution/local.ts; packages/core/src/session/input.ts; packages/core/src/session/message-updater.ts; packages/core/src/session/projector.ts; packages/core/src/session/recovery.ts; packages/core/src/session/run-coordinator.ts; packages/core/src/session/runner/index.ts; packages/core/src/session/runner/llm.ts; packages/core/src/session/runner/publish-llm-event.ts; packages/core/src/session/sql.ts; packages/core/test/database-migration.test.ts; packages/core/test/session-execution-local.test.ts; packages/core/test/session-projector.test.ts; packages/core/test/session-prompt.test.ts; packages/core/test/session-run-coordinator.test.ts; packages/core/test/session-runner-recorded.test.ts; packages/core/test/session-runner-tool-events.test.ts; packages/core/test/session-runner.test.ts; packages/opencode/src/server/routes/instance/httpapi/server.ts; packages/schema/src/session-event.ts; packages/schema/test/event-manifest.test.ts; packages/sdk/js/src/v2/gen/types.gen.ts; packages/sdk/openapi.json; packages/server/src/routes.ts; packages/core/src/session/execution/claim.ts; packages/core/src/session/recovery-id.ts.
• 🟡 (09:58) A clean detached worktree was prepared at base commit ab9408c81c (feat(app): adapt vertical tab density), and frozen V23 applied cleanly.
• 🟡 (09:59) Final V23 review scope explicitly covered the new acquisition latch, coordinator pre-interrupt boundary, exact malformed-projection quarantine, final-event transactional claim deletion, and all earlier recovery invariants.
• 🟡 (10:00) V23 pre-review gate status was: patch SHA-256 14035d7631ba25b820fdc553087469935f447af034d549e2f14f8a141eda59dc; SEA SHA-256 f875987afa4336956b9f33e14eee6de0a4af90e2bc6de899cccb7cbe5a5df998; 1,194 Core tests passed; 257 recovery tests passed; six package typechecks passed; migration and exact-artifact smoke passed; live services remained untouched.
• 🟡 (10:34) Independent V23 security review issued DO-NOT-MERGE after finding a MUST-FIX lost-resume bug in packages/core/src/session/run-coordinator.ts: line 81 used Effect.andThen after awaiting entry.done, while interrupted-owner failure was stored at lines 115-128. A resume registered during cleanup inherited that failure, so run(key) did not start its promised forced successor; run also did not set pendingWake. This contradicted the line 13 coordinator contract and packages/core/test/session-run-coordinator.test.ts:379-410. Without pending input, resume vanished permanently; with durable input, recovery retried only later.
• 🔴 (10:34) User asserted that a resume registered during interruption cleanup “never starts its promised forced successor” under the V23 bug.
• 🟡 (10:34) The V23 security review also found a stale-registration race in packages/core/src/session/execution/local.ts: successful drain deleted the durable claim at lines 114-118, but activeClaims retained the prospective claim until cleanup at lines 141-147. An interrupt in that interval saw stale registration at lines 239-243 and attempted the cancellation transition at lines 263-268; that transition could die with SessionExecutionClaim.Lost. Existing Lost reconciliation at lines 250-260 covered only post-interruption cleanup, allowing an otherwise successful interrupt to surface an internal defect/HTTP 500.
• 🟡 (10:34) Security review verification used base/HEAD ab9408c81cc9916177641ae8e9f08624fc27b5b9, patch SHA-256 14035d7631ba25b820fdc553087469935f447af034d549e2f14f8a141eda59dc, and SEA SHA-256 f875987afa4336956b9f33e14eee6de0a4af90e2bc6de899cccb7cbe5a5df998. It confirmed exactly 34 changed paths, byte-for-byte reconstructed patch equality, reverse applicability before and after review, migration ordering and generated-schema agreement, and otherwise approved exact claim fencing, malformed-projection quarantine, bounded-scan fairness, atomic event/claim transactions, failed-Step tool reconciliation, replay identities, generated clients, authorization, and dependency layering.
• 🟡 (10:34) Security review treated the disclosed final check-call gap, process-local routing, and bounded clock skew as non-findings. It modified or ran no files, VCS state, tests, builds, or services; recall was not used.
• 🟡 (10:34) Assistant rejected V23 and selected two fixes: (1) a forced run() waiting behind a stopping owner must observe and discard the old owner’s failed Exit, then retry; (2) pre-interrupt ownership loss after successful claim cleanup must resolve as an already-settled no-op rather than an internal defect.
• 🟡 (10:35) Root-cause analysis identified Effect.andThen in packages/core/src/session/run-coordinator.ts:81 as propagating the interrupted owner’s failure before retry. The chosen fix was to await completion as an Exit, discard the prior result, then call run(key); interruption of the waiting caller still cancels its own retry.
• 🟡 (10:35) For the stale-registration race, the chosen fix was to apply the same SessionExecutionClaim.Lost ownership-loss reconciliation to the pre-interrupt transition that post-interruption cleanup already used.
• 🟡 (10:36) Code fixes were applied to packages/core/src/session/run-coordinator.ts and packages/core/src/session/execution/local.ts.
• 🟡 (10:36) A deterministic stale-registration regression was designed with a narrow post-clear test hook: pause after successful durable claim deletion but before local activeClaims registration removal, call interrupt, and verify completion without a defect.
• 🔴 (10:36) User asserted the ownership invariant encoded by packages/core/test/session-execution-local.test.ts:138: “never starts a second owner while the lease is live.”
• 🔴 (10:36) User asserted the ownership invariant encoded by packages/core/test/session-execution-local.test.ts:161: “never overwrites an expired lease.”
• 🟡 (10:37) packages/core/test/session-execution-local.test.ts was updated with the deterministic post-success stale-registration regression.
• 🟡 (10:37) Two direct regressions covered both V23 review findings: forced resume during interruption cleanup must start with force:true, and interrupt after successful durable claim deletion must return cleanly.
• 🟡 (10:37) Targeted validation passed: one selected test run had 3 passed, 16 filtered out, 0 failed, and 8 expectations across 1 file in 311ms; another had 4 passed, 11 filtered out, 0 failed, and 11 expectations across 1 file in 875ms. Core tsgo --noEmit also passed.
• 🟡 (10:38) Full recovery gate for V24 passed: 258 tests, 0 failures, and 787 expectations across 8 files in 25.06s.
• 🟡 (10:38) Complete V24 source validation was launched after confirming: 258 recovery tests passed; forced resume survives interrupted-owner failure; wake intent survives cancellation setup; post-success stale registration resolves as settled; atomic cancellation deletion and malformed-projection quarantine remain green; Core typecheck passed. Planned subsequent gates were migration hygiene, build, isolated restart smoke, candidate freeze, and independent correctness/security approval.