Distillation

Date: Sep 15, 2026

• 🔴 [requested-review] (06:07) User requested continuation of the frozen correctness review against the exact canonical patch /tmp/opencode/session-recovery-full.patch, specifying SHA-256 f051a53df476dd924bda0a14c4cd91a63c9e7eafff53bbe71f0460571335fcbd, base ab9408c81cc9916177641ae8e9f08624fc27b5b9, and SEA hash 1ecc9afe36c12b31a8892cdbfb8a1560ceec97255c3537c073b795351233be40.
• 🔴 [enforced-read-only] (06:07) User required the correctness review to remain frozen and read-only: “Do not mutate anything.”
• 🔴 (06:07) User required substantive PASS/CONCERN/MUST-FIX findings with exact file:line evidence and a final line of exactly MERGE or DO-NOT-MERGE.
• 🔴 (06:07) User required that blocked reviews report the exact blocker and end DO-NOT-MERGE.
• 🔴 (06:07) User specified the response invariant: “never return empty or progress-only output.”
• 🔴 (06:07) User stated the server had restarted.
• 🟡 (06:07) Verification found the canonical patch unavailable: sha256sum: /tmp/opencode/session-recovery-full.patch: No such file or directory; therefore its required SHA-256 f051a53df476dd924bda0a14c4cd91a63c9e7eafff53bbe71f0460571335fcbd could not be verified.
• 🟡 (06:07) The SEA artifact packages/opencode/dist/server/opencode-server hashed to 1ecc9afe36c12b31a8892cdbfb8a1560ceec97255c3537c073b795351233be40, exactly matching the user-specified SEA hash.
• 🟡 (06:08) A file search returned No files found, leaving the required canonical patch unavailable.
• 🟡 (06:08) Repository HEAD was dc661f30cb2055ad6248fdc59b14998d834497be, which differs from the user-specified base ab9408c81cc9916177641ae8e9f08624fc27b5b9.
• 🟡 (06:08) The working tree was not clean. Modified files were .lore.md, AGENTS.md, packages/core/schema.json, packages/core/src/database/migration.gen.ts, packages/core/src/database/schema.gen.ts, packages/core/src/session/compaction.ts, packages/core/src/session/execution/local.ts, packages/core/src/session/message-updater.ts, packages/core/src/session/projector.ts, packages/core/src/session/recovery.ts, packages/core/src/session/runner/index.ts, packages/core/src/session/runner/llm.ts, packages/core/src/session/runner/publish-llm-event.ts, packages/core/src/session/sql.ts, packages/core/test/session-execution-local.test.ts, packages/core/test/session-projector.test.ts, packages/core/test/session-runner-recorded.test.ts, packages/core/test/session-runner-tool-events.test.ts, packages/core/test/session-runner.test.ts, and packages/schema/src/session-event.ts; untracked files were packages/core/src/database/migration/20260914235657_session-execution-lease.ts, perf.data, and perf.data.old.
• 🟡 (06:09) Review inspection of packages/core/src/session/run-coordinator.ts:5-15 showed that Coordinator<Key, E> serializes execution per key and exposes active, run, wake, and interrupt; wake is documented as registering one coalesced follow-up after newly recorded work.
• 🟡 (06:09) packages/core/src/session/run-coordinator.ts:17-22 defines each coordinator entry with done, optional owner, pendingWake, and stopping.
• 🟡 (06:09) packages/core/src/session/run-coordinator.ts:37-49 starts owner fibers through a FiberSet; normal starts wait on a ready deferred, while successors begin after Effect.yieldNow, and all exits call settle(key, entry, exit).
• 🟡 (06:09) packages/core/src/session/run-coordinator.ts:51-65 coalesces a pending wake after a successful, non-stopping execution by reusing the same entry; otherwise, any remaining pendingWake creates and starts a successor entry before completing the prior entry’s done deferred.
• 🟡 (06:09) packages/core/src/session/run-coordinator.ts:67-79 makes run(key) join the existing entry; if that entry is stopping, it waits for completion and recursively retries, while an idle key starts a forced drain.
• 🟡 (06:09) packages/core/src/session/run-coordinator.ts:81-92 makes wake(key) set pendingWake = true whenever an entry exists, without checking entry.stopping; for an idle key, it starts a non-forced drain.
• 🟡 (06:09) packages/core/src/session/run-coordinator.ts:94-101 makes interrupt(key) set stopping = true, clear pendingWake, and interrupt the owner fiber; because wake does not check stopping, a wake arriving after those assignments can set pendingWake again before settlement.
• 🟡 (06:11) packages/core/src/event.ts:316-353 invokes durable projectors and the optional local commit(seq) hook before updating EventSequenceTable and inserting into EventTable, all within an immediate database transaction; database operations are converted to defects with Effect.orDie.
• 🟡 (06:11) packages/core/src/event.ts:354-360 publishes durable aggregate wake notifications only after the transaction returns a committed event.
• 🟡 (06:11) packages/core/src/event.ts:369-395 rejects commit hooks for non-durable events with InvalidDurableEventError and exact message Local commit hooks require a durable event; durable events are persisted before isolated listener notification.
• 🟡 (06:11) packages/core/src/event.ts:398-415 logs non-interruption listener failures as Event listener failed with eventID, eventType, and cause; durable listeners may be isolated while local listeners are invoked directly.
• 🟡 (06:11) packages/core/src/event.ts:441-475 supports replay options publish, ownerID, and strictOwner; replay decodes the stored payload, commits it with the supplied sequence and aggregate ID, and only notifies listeners when a new commit occurred and publish is true.