Distillation

Date: Aug 25, 2026

• 🟡 (14:39) Inspected /home/byk/Code/getsentry/craft-workspace-action-propagation/src/config.ts lines 1-270. CONFIG_FILE_NAME = '.craft.yml'; DEFAULT_RELEASE_BRANCH_NAME = 'release'; WORKSPACES_MIN_VERSION = '2.29.0'.
• 🟡 (14:39) src/config.ts:69-95 stores selected workspace in _activeWorkspaceName: string | undefined; setActiveWorkspace(name) sets it and invalidates _configCache and _globalGitHubConfigCache; getActiveWorkspace() returns it.
• 🟡 (14:39) resolveWorkspaceConfig(base, workspaceName) in src/config.ts:110-160 errors with ConfigurationError for an unknown workspace and lists available workspaces (or reports none configured); applies shallow overrides for every defined workspace release field, does not deep-merge arrays/objects, strips top-level workspaces, and shallow-merges github so partial workspace fields can inherit base owner/repo.
• 🟡 (14:39) resolveWorkspaceConfig() only retains merged github when both owner and repo are present; otherwise deletes it so getGlobalGitHubConfig() can fall back to git-remote detection. A workspace with only projectPath and no base github therefore relies on git detection for owner/repo.
• 🟡 (14:39) isVersionGteMinVersion(minVersionRaw, requiredVersion) parses both versions and compares them after withoutBuildMetadata() removes SemVer build metadata; invalid or absent versions return false, allowing config minVersion values such as 2.29.0+linux.
• 🟡 (14:39) applyWorkspaceSelection() in src/config.ts:205-240 preserves legacy behavior when neither workspaces nor a selection exists; errors if --workspace is selected but config has no workspaces; errors if config defines workspaces but no explicit --workspace <name> or CRAFT_WORKSPACE selection; and requires minVersion >= 2.29.0 before resolving the selected workspace.
• 🟡 (14:39) findConfigFile() searches upward from process.cwd() for .craft.yml, caches a found path in _configPathCache, stops at filesystem root, and has MAX_DEPTH = 1024, logging findConfigFile: Reached maximum allowed directory depth if exceeded.
• 🟡 (14:40) Inspected /home/byk/Code/getsentry, which contains 34 entries including craft-workspace-action-propagation/, craft-workspaces-schema/, publish-workspace-acceptance/, publish/, sentry/, sentry-javascript/, sentry-python/, snuba/, and symbolic/.
• 🟡 (14:41) Inspected /home/byk/Code/getsentry/publish-workspace-acceptance; it contains .github/, AGENTS.md, docs/, node_modules/, package.json, README.md, src/, vitest.config.js, and yarn.lock.
• 🔴 (14:42) User stated the publish-workspace-acceptance repository is the Sentry Publish Repository: a GitHub Actions approval system for publishing releases across multiple Sentry projects using Craft; it is a pure JavaScript CommonJS project pinned to Node.js 24.0.0.
• 🔴 (14:42) User stated publish-workspace-acceptance uses Yarn classic 1.22.22 via Volta and must not use npm.
• 🔴 (14:42) User stated repository commands: install with yarn install; all tests yarn test; watch tests yarn test:watch; single-file test yarn test src/modules/__tests__/update-issue.js; pattern test yarn test -t "pattern"; lint yarn lint; format yarn prettier.
• 🔴 (14:42) User stated source structure: src/libs/ holds shared utilities, src/modules/ holds reusable core business logic, and src/publish/ holds GitHub Actions entry points; tests are in __tests__/ directories.
• 🔴 (14:42) User stated style conventions: kebab-case filenames such as details-from-context.js and update-issue.js; test files share their source filename in __tests__/; camelCase variables/functions; UPPER_SNAKE_CASE constants/regex patterns; CommonJS (require/module.exports) source and ES Modules (import/export) tests.
• 🔴 (14:42) User stated import order is: 1. Node.js built-ins, 2. external packages, 3. relative local modules.
• 🔴 (14:42) User stated CommonJS named exports are preferred for multiple exports (module.exports = { functionA, functionB }), while a single default export is module.exports = functionName.
• 🔴 (14:42) User stated formatting uses default Prettier settings, double-quoted strings, required semicolons, and yarn prettier should run before committing.
• 🔴 (14:42) User stated errors should be descriptive, include context and potential fixes, and inputs should be validated early with guard clauses.
• 🔴 (14:42) User stated switch statements must always throw for unexpected values, e.g. default: throw new Error(\Unknown status: '${status}'`);`.
• 🔴 (14:42) User stated files should be checked with fs.existsSync() before reading.
• 🔴 (14:42) User stated tests use Vitest v4.0.0 with globals enabled and automatically cleared mocks; source modules should be imported after vi.mock() calls.
• 🔴 (14:42) User stated key dependencies are @actions/core, @actions/github, and @sentry/node; common patterns include await Promise.all([operation1(), operation2()]), destructuring, and spread-object merging.
• 🟡 (14:44) Working tree on branch feat/workspace-acceptance has modifications to .github/workflows/publish.yml, src/modules/__tests__/details-from-context.js, and src/modules/details-from-context.js; base commit shown is 83d210b build(deps): bump js-yaml from 4.3.0 to 4.3.1 (#9174). Diff totals: 123 insertions and 7 deletions across 3 files.
• 🟡 (14:45) publish-workspace-acceptance/src/modules/details-from-context.js defines TARGETS_SECTION_PARSER_REGEX, TARGETS_PARSER_REGEX, and CHECKED_TARGETS_PARSER_REGEX; detailsFromContext({ context }) throws Error("Issue context is not defined") unless context.payload.issue exists.
• 🟡 (14:45) detailsFromContext() parses publish titles with ^publish: (?:getsentry\/)?(?<repo>[A-Za-z0-9_.-]+)(?<path>\/[\w./-]+)?(?: \[workspace: (?<workspace>"(?:[^"\\]|\\.)*")\] )?@(?<version>[\w.+-]+)$; invalid titles throw Invalid publish issue title: '<title>'.
• 🟡 (14:45) detailsFromContext() supports an optional human-readable JSON-quoted [workspace: "<name>"] title component; it parses the capture using JSON.parse(), rejects an empty name or names containing \n/\r with Workspace names must be nonempty and cannot contain line breaks, and returns workspace only when nonempty.
• 🟡 (14:45) detailsFromContext() outputs repo, version, path ("." + title path, default "."), dry_run ("1" only if issue labels include dry-run, otherwise ""), merge_target extracted from Merge target: <[\\w.\\-/]+> (otherwise ""), checked targets, and optional workspace.
• 🟡 (14:46) .github/workflows/publish.yml comments document that the CI poller always adds ci-ready (removing it first to trigger a fresh labeled event), so the publish gate requires the ci-ready label and avoids racing waiting-for-ci on the same event.
• 🔴 (14:46) User stated the CI poller always adds ci-ready.
• 🟡 (14:47) publish-workspace-acceptance/src/publish/inputs.js imports @actions/github, @actions/core, and detailsFromContext; its inputs() function parses github.context and emits the object as the result GitHub Actions output via core.setOutput('result', result), then immediately invokes inputs().
• 🟡 (14:49) Tests in publish-workspace-acceptance/src/modules/__tests__/details-from-context.js expect a standard issue title publish: getsentry/sentry@21.3.1 and checked target section to produce dry_run: "", merge_target: "custom-branch", path: ".", repo: "sentry", targets: ["github", "npm[@sentry/node]", "docker[latest]"], and version: "21.3.1".
• 🟡 (14:49) details-from-context tests verify version strings containing +, e.g. 4.2.6+sentry1, are parsed correctly; Merge target: (default) leaves merge_target: "".
• 🟡 (14:49) details-from-context tests verify title publish: getsentry/toolkit [workspace: "cli/v2"] @1.2.3 yields workspace cli/v2, and escaped title workspace "cli [preview] \"next\"" yields cli [preview] "next".
• 🟡 (14:49) details-from-context tests reject a legacy title with a space before its version (publish: getsentry/toolkit @1.2.3), empty workspace ([workspace: ""]), multiline workspace ([workspace: "cli\nnext"]), and missing issue payload.
• 🔴 (14:50) User stated remote-state-affecting Git methods must ALWAYS be blocked in dry-run.
• 🔴 (14:50) User stated --workspace --dry-run must never be mistaken for a workspace name.
• 🟡 (14:50) Search results identify src/utils/dryRun.ts as defining remote-state-affecting Git methods “that should ALWAYS be blocked in dry-run” around line 355; methods blocked in strict dry-run but allowed in worktree mode are separately documented around line 361.
• 🟡 (14:50) Search results identify dry-run isolation behavior in src/utils/dryRun.ts: non-dry-run returns a passthrough object; dry-run creates a temporary worktree at /tmp/craft-dry-run-*; cleanup handles signal receipt and worktree removal; dry-run Git commit mock results use commit: 'dry-run-commit-hash'.
• 🟡 (14:50) Search results identify tests in src/utils/__tests__/helpers.test.ts for ['--workspace', 'cli', '--workspace', '--dry-run'] and for ensuring --workspace --dry-run does not select --dry-run and instead defers to environment fallback.
• 🟡 (14:52) craft-workspace-action-propagation/src/schemas/project_config.ts:180-197 defines optional release-unit fields: github, targets, preReleaseCommand, postReleaseCommand, releaseBranchPrefix, changelog, changelogPolicy ('auto' | 'simple' | 'none'), requireNames, statusProvider, artifactProvider, versioning, and noMerge.
• 🟡 (14:52) WorkspaceSchema is z.object({ ...releaseUnitFields, github: GitHubGlobalConfigSchema.partial().optional() }); every workspace field is optional and inherits top-level values when omitted, while workspace github can override only projectPath, owner, or repo.
• 🟡 (14:52) CraftProjectConfigSchema adds optional minVersion matching /^\d+\.\d+\.\d+.*$/ and optional workspaces: z.record(z.string(), WorkspaceSchema); named workspaces are independently versioned release units requiring --workspace <name> or CRAFT_WORKSPACE, while no workspaces retains backward-compatible single implicit top-level release-unit behavior.