Distillation

Date: Sep 16, 2026

• 🔴 [requested-review] (21:55) User requested a read-only adversarial correctness review of frozen v15, using base commit ab9408c81cc9916177641ae8e9f08624fc27b5b9, patch /tmp/opencode/session-recovery-final-v15.patch with SHA-256 509563ba0cd17246a1d223ac7a6f3fabee1a49892c61b215c3fd7ca4744b6c77, and SEA /home/byk/Code/opencode/packages/opencode/dist/server/opencode-server with SHA-256 83a833aa93cc185825feffe107fba1bd8e3789d1ff5fe5f8cda7df1962aa078d.
• 🔴 (21:55) User required verification of the exact inputs, base, clean patch application, and all 34 paths, with every path inspected.
• 🔴 (21:55) User prohibited mutation, tests, builds, and services during the review.
• 🔴 (21:55) User stated the v14 cancellation blockers are addressed by a durable cancelling → cancelled handshake.
• 🔴 (21:55) User stated the local finalizer never clears either cancelling or cancelled.
• 🔴 (21:55) User stated explicit coordinator cleanup clears cancelled, permits pre-assistant cancelling, and rejects unresolved active cancelling.
• 🔴 (21:55) User stated the publication-defect regression retains the cancelling claim and running tool.
• 🔴 (21:55) User stated explicit Session.resume durably publishes PromptExecutionRequested for the oldest unpromoted ordinary input before claim/run, so a pre-promotion crash redrives the exact input without a synthetic replacement.
• 🔴 (21:55) User stated the current client was regenerated through packages/client.
• 🔴 (21:55) User stated an index was added to cover the recovery scan.
• 🔴 (21:55) User requested reassessment of lifecycle, replay, fairness, identity, tools, schema/client boundaries, and dependency boundaries.
• 🔴 (21:55) User accepted final-check-to-call, process-local, and clock-skew residual risks.
• 🔴 (21:55) User reported evidence results: recovery 247/0/730, full Core 1184/0/3319, six affected-package typechecks, manifest/migration/diff evidence, and a four-launch v15 smoke pass.
• 🔴 (21:55) User required findings classified exactly as PASS, CONCERN, or MUST-FIX, each with file:line, and a final verdict of exactly MERGE or DO-NOT-MERGE.
• 🔴 (21:55) User stated an empty review is invalid and instructed that the review use no recall.
• 🟡 (21:56) Tool verification matched /tmp/opencode/session-recovery-final-v15.patch to SHA-256 509563ba0cd17246a1d223ac7a6f3fabee1a49892c61b215c3fd7ca4744b6c77 and /home/byk/Code/opencode/packages/opencode/dist/server/opencode-server to SHA-256 83a833aa93cc185825feffe107fba1bd8e3789d1ff5fe5f8cda7df1962aa078d.
• 🟡 (21:56) Repository inspection reported base ab9408c81cc9916177641ae8e9f08624fc27b5b9 and current commit dc661f30cb2055ad6248fdc59b14998d834497be.
• 🟡 (21:56) Working-tree status showed modified files: .lore.md, AGENTS.md, packages/client/src/generated/types.ts, packages/core/schema.json, packages/core/src/database/migration.gen.ts, packages/core/src/database/migration/20260914170650_session-recovery.ts, packages/core/src/database/schema.gen.ts, packages/core/src/session.ts, packages/core/src/session/compaction.ts, packages/core/src/session/context-epoch.ts, packages/core/src/session/execution/local.ts, packages/core/src/session/input.ts, packages/core/src/session/message-updater.ts, packages/core/src/session/projector.ts, packages/core/src/session/recovery.ts, packages/core/src/session/run-coordinator.ts, packages/core/src/session/runner/index.ts, packages/core/src/session/runner/llm.ts, packages/core/src/session/runner/publish-llm-event.ts, packages/core/src/session/sql.ts, packages/core/test/database-migration.test.ts, packages/core/test/session-execution-local.test.ts, packages/core/test/session-projector.test.ts, packages/core/test/session-prompt.test.ts, packages/core/test/session-run-coordinator.test.ts, packages/core/test/session-runner-recorded.test.ts, packages/core/test/session-runner-tool-events.test.ts, packages/core/test/session-runner.test.ts, packages/schema/src/session-event.ts, packages/schema/test/event-manifest.test.ts, packages/sdk/js/src/v2/gen/types.gen.ts, and packages/sdk/openapi.json.
• 🟡 (21:56) Working-tree status showed deleted migration files packages/core/src/database/migration/20260914214636_session-execution.ts and packages/core/src/database/migration/20260914222526_session-execution-phase.ts; untracked source files packages/core/src/session/execution/claim.ts and packages/core/src/session/recovery-id.ts; and unrelated-looking untracked artifacts perf.data and perf.data.old.
• 🟡 (21:56) The 34-path patch listing additionally included packages/opencode/src/server/routes/instance/httpapi/server.ts and packages/server/src/routes.ts; these appeared in the patch path list but not as modified in the displayed working-tree status.
• 🟡 (21:56) Patch diffstat reported 34 paths, including newly created packages/core/src/database/migration/20260914170650_session-recovery.ts, packages/core/src/session/recovery.ts, packages/core/test/session-execution-local.test.ts, packages/core/src/session/execution/claim.ts, and packages/core/src/session/recovery-id.ts.
• 🟡 (21:56) Largest displayed patch changes included packages/core/test/session-projector.test.ts at 2771 insertions and 3 deletions, packages/core/test/session-runner.test.ts at 1140 insertions and 118 deletions, packages/sdk/openapi.json at 657 insertions and 44 deletions, packages/core/schema.json at 567 insertions and 48 deletions, and packages/core/src/session/recovery.ts at 504 insertions and 0 deletions.
• 🟡 (21:57) Git history showed dc661f30cb (HEAD -> byk/cumulative) feat(core): recover interrupted sessions above base ab9408c81c feat(app): adapt vertical tab density; earlier commits shown were 2e9407768d fix(server): bound Node shutdown, 2c92569e62 fix(app): prevent stale WebUI asset loads, and b98c698390 feat(server): add Fossilize standalone builds.
• 🟡 (21:57) Commit-level diff from the displayed history covered 22 files with 1372 insertions and 160 deletions, while the supplied patch diffstat covered 34 paths.
• 🟡 (21:57) A final tool command returned no output; the transcript does not identify the command or independently establish what the empty result verified.