Distillation

Date: Sep 10, 2026

• 🔴 (03:22) User showed branch feat/toolkit-bridge-upgrade tracking origin/feat/toolkit-bridge-upgrade, with e565b1afb39a341605adc883de8812851de7d581 at HEAD.
• 🔴 (03:22) User showed Sep 10 commit history by Burak Yigit Kaya <byk@sentry.io> in newest-to-oldest order: e565b1afb39a341605adc883de8812851de7d581 — fix(cli): validate stable upgrade metadata; 4a1d5bad105c006193c68459175f5eb3c7f78e08 — test(cli): update pinned version fixture; 2f9b5d0d26124d445a916b8bfc584ad518720584 — fix(cli): isolate pinned upgrade resolution; c6030fbf4d0c190f037c86d832edb6680d3e54ab — fix(cli): bind nightly manifests to versions; b6484e0fb1eb0f8bce68272d538f5c3b26cd5bd5 — fix(cli): validate resolved upgrade metadata; c8c815bbecf472061ec02ab96d1a31f23f078d01 — fix(cli): validate GitHub release pagination; 5ffa5cd0fe02c0a5dc5bec9a8a099f4135c0b447 — fix(cli): harden upgrade source resolution. (meaning Sep 10, 2026)
• 🔴 (03:22) User showed Sep 9 commit history by Burak Yigit Kaya <byk@sentry.io> in newest-to-oldest order: dbee7e9f2a4555e044f74dfebad002cccfa43a1f — test(cli): update toolkit upgrade fixtures; 723375b6ce4e37884e760fa0f848e7e7e3effcc9 — fix(cli): address upgrade review findings; 9c874298e3b57515ba36d35140627a668a46dc7b — fix(cli): address toolkit bridge review; 04867eaf9b412a62d4b1ea1c59c2b382c557bd0b — feat(cli): add toolkit upgrade bridge. (meaning Sep 9, 2026)
• 🔴 (03:22) User showed packages/cli/test/lib/upgrade.test.ts GitHub pagination coverage using https://api.github.com/repos/getsentry/toolkit/releases?per_page=100 and a next-page Link header targeting https://api.github.com/repositories/1114546946/releases?per_page=100&page=2; expected requests include both the initial URL and https://api.github.com/repos/getsentry/toolkit/releases?per_page=100&page=2.
• 🔴 (03:22) User showed the test classifies malformed GitHub release pagination as a network error in packages/cli/test/lib/upgrade.test.ts, plus fallback expectations involving https://api.github.com/repos/getsentry/toolkit/releases?per_page=100 followed by https://api.github.com/repos/getsentry/cli/releases/latest.
• 🔴 (03:22) User showed packages/cli/test/lib/upgrade.test.ts filtering non-CLI Toolkit releases: fixture { tag_name: "cli@99.0.0-dev.1", prerelease: false }, test does not use an MCP release as the latest CLI release, and malformed/mismatched pinned-release fixture { tag_name: "mcp@1.0.0" }.
• 🔴 (03:22) User showed pinned-version source tests in packages/cli/test/lib/upgrade.test.ts using Toolkit URL https://api.github.com/repos/getsentry/toolkit/releases/tags/cli%401.0.0 and legacy fallback URL https://api.github.com/repos/getsentry/cli/releases/tags/1.0.0; one assertion verifies no request URL includes getsentry/cli.
• 🔴 (03:22) User showed nightly source-isolation and metadata-validation tests in packages/cli/test/lib/upgrade.test.ts: rejects a mismatched nightly annotation for an explicit source, manifest annotation fixture version: "0.0.0-dev.1740000000", and assertions concerning Toolkit/CLI GHCR token scopes and /v2/getsentry/toolkit/manifests/nightly versus https://ghcr.io/v2/getsentry/cli/manifests/nightly.
• 🔴 (03:22) User showed the test rejects a mismatched versioned manifest before downloading its blob in packages/cli/test/lib/upgrade.test.ts, indicating versioned OCI manifest metadata is validated before blob download.
• 🔴 (03:22) User showed packages/cli/test/lib/upgrade.test.ts cleanup coverage under describe("startCleanupOldBinary", ...): getOldPath() returns getCurlInstallPaths().oldPath; beforeEach calls clearInstallInfo() to restore default paths; test removes .old file if it exists creates the parent directory with mkdirSync(join(oldPath, ".."), { recursive: true }), writes "test content" via writeFileSync, and verifies cleanup behavior; another visible assertion requires startCleanupOldBinary() not to throw.
• 🔴 (03:22) User showed packages/cli/src/lib/upgrade.ts lines 72–76 preserving backward compatibility by re-exporting type InstallationMethod and function parseInstallationMethod from ./binary.js; the function export carries biome-ignore lint/performance/noBarrelFile: backward-compat re-export, not a barrel.
• 🔴 (03:22) User showed packages/cli/src/lib/upgrade.ts defining PackageManager = "npm" | "pnpm" | "bun" | "yarn" and OfflineMode = false | "explicit" | "network-fallback", where false means online upgrade, "explicit" means the user passed --offline, and "network-fallback" means a network failure automatically fell back to cache.
• 🔴 (03:22) User showed packages/cli/src/lib/upgrade.ts exporting NIGHTLY_TAG = "nightly" for the rolling nightly GitHub release, documented as a stable-fallback-only mechanism.