Distillation

Date: Sep 17, 2026

• 🟡 [requested-review] (09:45) User requested a read-only focused analysis in /home/byk/Code/opencode-lore-embedding-runtime of audit finding 6: startup per-worker memory versus persisted undivided free-memory baseline units, including pool ceiling changes.
• 🟡 (09:45) User asked to inspect jj change tmzmtlss and propose the smallest correct representation/reconciliation plus deterministic restart tests, with exact symbols, line references, and compatibility implications.
• 🔴 [enforced-workflow] (09:45) User directed that the analysis must not edit files, mutate VCS, use the network, or access a production DB.
• 🔴 (09:45) User stated jj never fails on conflict; conflicts are recorded in the resulting commit and must be detected with jj st and resolved by editing files rather than using interactive jj resolve.
• 🔴 (09:46) User stated tests use a temporary SQLite DB via packages/core/test/setup.ts, never the production DB.
• 🔴 (09:46) User stated releases use Sentry Craft and versions or CHANGELOG.md must never be manually bumped or edited; release automation handles both.
• 🔴 (09:46) User stated the project follows failing-first TDD for bug fixes: “Never trust the fix without seeing it fail.” A deterministic regression test must fail on the base branch and pass on the fix.
• 🔴 (09:46) User stated embedding worker admission is never below 1: the primary worker always runs.
• 🟡 (09:46) Repository guidance in quality/REVIEW.md:12-23 requires each adversarial-review defect to land with a deterministic regression test in the same PR; the test must fail on base, pass on the fix, exercise the real precondition, and fail if the tested guard is deleted.
• 🟡 (09:46) quality/REVIEW.md:25-37 requires adversarial-order setup, including state present before reconciliation, delete-then-recreate across lifecycle boundaries, and modify-while-off sequences.
• 🟡 (09:46) quality/REVIEW.md:85-105 defines two distinct review passes: 1. adversarial/correctness review, mandatory for correctness-critical paths; 2. security/pentest review according to risk. Reviewers must run pnpm test, pnpm run typecheck, pnpm run lint, and pnpm run format:check, verify property tests across 10 runs, hash-verify an unmodified tree, and give per-point PASS / FAIL / CONCERN / MUST-FIX verdicts with file:line evidence plus an overall MERGE / DO-NOT-MERGE.
• 🟡 (09:46) Repository is a colocated jj/Git workspace containing both .jj/ and .git/; mutations, if later authorized, must use jj rather than Git.
• 🟡 (09:46) Project runtime/tooling facts: Node.js development/tests/production requirement is >=22.5; root package.json pins Volta Node 24.16.0, pnpm 10.28.0, and packageManager pnpm@10.28.0.
• 🟡 (09:46) Relevant embedding-cap search hits in packages/core/src/embedding-cap.ts: worker-floor comment at line 120; freeBytes parameter at line 126; finite-positive normalization at line 134; memoryModelEmbedCap(freeBytes) at line 266; calculation using freeBytes * EMBED_MEM_FRACTION - EMBED_MODEL_BASELINE_BYTES at line 268; reconciliation parameters at line 291; persisted/live ratio freeBytes / stored.freeMemBytes at line 298; upward comparison at line 305; reprobe inputs at lines 328-332; and pool ceiling initialization let ceiling = memoryModelEmbedCap(freeBytes) at lines 356-360.
• 🟡 (09:46) Additional relevant source hits: packages/core/src/embedding/pool.ts:301 says the pool ceiling is passed as the memory divisor so every worker sizes its allocation; packages/core/src/embedding/local.ts:852 anchors the re-probe baseline at OOM-time free memory.
• 🟡 (09:47) Persisted-cap test/source search identified packages/core/test/embedding-cap.test.ts:271-330, including stored { cap, freeMemBytes } reconciliation cases; packages/core/test/embedding-cap-persistence.test.ts, including _persistEmbedCap, _readPersistedEmbedCap, and corrupt knownBadCap cases; and packages/core/src/embedding/local.ts:55-61,141-147,174-185,213-234, covering persisted freeMemBytes, defaulting to containerFreeBytes(), test helpers, and failure telemetry.
• 🟡 (09:47) Existing test comments use freeMemBytes=0 as a special trust-band condition: packages/core/test/embedding-pool-memory.test.ts:123 pins a learned cap high because host free memory is ignored; packages/core/test/embedding-oom-recovery.test.ts:119,159 trusts the cap as-is regardless of host free memory.
• 🟡 (09:47) jj working-copy change tmzmtlss currently resolves to commit 6a5b70c9ee77, description fix(core): correct embedding runtime selection and admission, bookmark fix/embedding-runtime-admission; its parent is change pxrvwsvv, commit 2cbf40060c67, main, description feat(cch): add seeds for Claude Code up to 2.1.272 (#1780).
• 🟡 (09:47) Change tmzmtlss has 20 working-copy paths: added packages/core/src/cgroup-memory.ts and packages/core/test/cgroup-memory.test.ts; modified packages/core/src/embedding/local.ts, packages/core/src/embedding/pool.ts, packages/core/src/embedding-cap.ts, packages/core/src/embedding-worker-types.ts, packages/core/src/embedding-worker.ts, packages/core/src/embedding.ts, packages/core/src/ort-native.ts, packages/core/test/embedding-cap.test.ts, packages/core/test/embedding-pool-memory.test.ts, packages/core/test/embedding-pool.test.ts, packages/core/test/embedding-wasm-fallback.test.ts, packages/core/test/embedding-worker-stdio.test.ts, packages/core/test/embedding-worker-types.test.ts, packages/core/test/ort-native.test.ts, packages/gateway/script/bundle.ts, packages/gateway/script/ort-platform-package.ts, packages/gateway/test/bundle-exports.test.ts, and packages/gateway/test/ort-platform-package.test.ts.
• 🟡 (09:47) jj reported a conflicted bookmark named fix/responses-private-references; no working-copy mutation was requested or authorized to resolve it.