Distillation

Date: Sep 2, 2026

• 🟡 (15:37) Independent adversarial audit issued DO-NOT-MERGE for Craft Action workspace validation: action.yml:84 accepted unsafe compact names __proto__, -foo, and --config because regex /^(?!\.{1,2}$)[A-Za-z0-9_.-]+$/ rejected only . and ..; these inputs could reach side effects in action.yml:89-173. Audit required rejecting reserved and option-looking names with focused validator tests. Audit otherwise passed revision authority, poller update, ci-ready/manual recovery flow, root-only legacy workspace JSON parsing, revision consistency, Craft-compatible state isolation/parity, no local-state fallback, generated-parser freshness, YAML parsing, whitespace hygiene, and exclusion of two newline-only unrelated Publish artifacts. Full suites were intentionally not run during that read-only audit.
• 🟡 (15:38) Assistant identified the Action validation gap and planned to align Action validation with Craft and Publish before adding executable regressions.
• 🟡 (15:40) Craft action.yml validation step at lines 74-87 sets PATH_INPUT=${{ inputs.path }} and WORKSPACE=${{ inputs.workspace }}, rejects simultaneous non-. path plus workspace, then validates a nonempty workspace with Node regex; the pre-fix regex allowed ASCII letters/digits/periods/underscores/hyphens except . and ...
• 🟡 (15:43) Existing Craft src/__tests__/action.test.ts coverage included: option-looking --config-from=untrusted being passed inline as prepare --workspace=--config-from=untrusted and targets --workspace=--config-from=untrusted; invalid control/tab, format (\u202e), line separator (\u2028), paragraph separator (\u2029), and non-ASCII cli-é values rejected before Git/Craft calls; safe '' and cli-v2 accepted; combined path=packages/cli plus workspace rejected; cli/v2, ., and .. rejected; request titles publish: getsentry/toolkit@1.2.3 for root and publish: getsentry/toolkit/cli@1.2.3 for workspace cli.
• 🟡 (15:44) Assistant decided to reject __proto__ and leading-dash workspaces in the first Action step while retaining the inline option-looking regression as a separate Craft parser-behavior test.
• 🟡 (15:45) Updated ../craft-workspace-action-propagation/action.yml and ../craft-workspace-action-propagation/src/__tests__/action.test.ts.
• 🟡 (15:46) Assistant stated Action validation now fails closed for reserved and option-looking compact names before side effects and planned focused Craft checks followed by cross-repository verification.
• 🟡 (15:48) Focused Craft command vitest run src/__tests__/action.test.ts src/__tests__/config.test.ts passed: 2 test files, 61 tests. Prettier reported code-style issues only in src/__tests__/action.test.ts.
• 🟡 (15:49) Assistant planned to format the expanded parameterized Action test and rerun relevant checks.
• 🔴 (15:50) User stated @typescript-eslint/no-unused-vars had never been used for the reported warnings.
• 🟡 (15:50) After formatting src/__tests__/action.test.ts, focused Craft tests again passed: 2 files, 61 tests; Prettier passed. ESLint had 0 errors and 7 warnings: src/commands/publish.ts _abortError at 482:14, 499:14, and 527:16; _statusError at 515:16; _diffError at 521:18; and src/utils/git.ts _err at 241:12 and 249:12, all @typescript-eslint/no-unused-vars.
• 🟡 (15:52) Assistant characterized the seven lint warnings as existing and planned Craft full-suite/build validation plus final read-only review limited to Action validation and current Publish contract.
• 🟡 (15:53) Full Craft vitest run passed: 61 test files, 1,158 passed tests, 1 skipped (1,159 total), duration 30.18s. Test output included expected mocked GitHub release scenarios, Vite SSR warnings in src/targets/__tests__/symbolCollector.test.ts concerning assignment to imported checkExecutableIsPresent, and debug messages for failed remote fetch/branch listing using cached refs. Lint retained exactly 7 warnings and 0 errors; Prettier passed; node build.mjs passed, skipping source-map upload because SENTRY_AUTH_TOKEN was absent.
• 🟡 (15:54) Assistant stated full Craft verification passed tests, typecheck, formatting, build, and whitespace checks, with only seven pre-existing lint warnings, and began final read-only contract review.
• 🟡 (16:02) Final independent audit returned MERGE: first Action-step workspace validation permits empty input and rejects unsafe compact names before Git/Craft/network effects; safe compact identity flows through prepare, target discovery, and publish-request titles; legacy JSON spellings including cli/v2 remain supported; canonical revision parser/poller constraints hold; approved revision drives checkout, discovery, state identity, and craft publish --rev; Base64URL state exists outside checkout; CI notification/label ordering and workflow_dispatch remain correct; parser/YAML/hygiene checks pass; known newline-only src/modules/post-workflow-details.js:16 and src/publish/inputs.js:5-12 remain unstaged. Audit cited Craft 1,158 passed/1 skipped plus lint/build and Publish 51 passed tests plus parser/lint validation.
• 🟡 (16:03) Assistant planned final allowlisted-diff and branch-state inspection, then commits excluding Publish’s two newline-only artifacts.
• 🔴 (16:05) User stated commit 4da4a25 was chore: replace deprecated trimRight() with trimEnd() (#9012).
• 🟡 (16:05) Publish worktree had intended modified files .github/workflows/ci-poller.yml, .github/workflows/publish.yml, docs/publish-issue-format.md, package.json, src/modules/__tests__/details-from-context.js, src/modules/__tests__/publish-workflow.js, src/modules/details-from-context.js, and yarn.lock; intended untracked implementation/test paths included scripts/generate-publish-issue-title-parser.js, src/modules/{ci-poller-input.js,publish-issue-title.js,publish-issue-title.peggy,publish-location.js,release-revision.js}, their tests, and src/publish/{resolve-ci-poller-input.js,resolve-location.js,resolve-release-revision.js}. Unrelated modified src/modules/post-workflow-details.js and src/publish/inputs.js were newline-only formatter artifacts.
• 🟡 (16:06) Assistant concluded the Publish change set was isolated from the two excluded newline-only files and planned Craft final-state inspection before explicit allowlist staging.
• 🟡 (16:08) Craft worktree intended change set comprised action.yml, GitHub target documentation, Action/config/publish tests, src/commands/publish.ts, src/config.ts, src/index.ts, src/schemas/project_config.ts, plus new src/commands/workspace.ts and src/commands/workspace_cmds/ files. Base branch included earlier commits 6dae341 feat: propagate release workspaces and 21270a1 feat(config): add release workspaces.
• 🟡 (16:09) Assistant chose separate allowlisted commits: Publish would exclude two newline-only files; Craft would include only compact-contract implementation and tests.
• 🟡 (16:10) Publish staged exactly 20 intended files, adding 1,601 insertions and 88 deletions, including generated parser src/modules/publish-issue-title.js (902 lines), grammar src/modules/publish-issue-title.peggy, generator script, location/revision/poller modules and tests, resolver entrypoints, workflow/docs/package/lockfile changes. src/modules/post-workflow-details.js and src/publish/inputs.js remained unstaged.
• 🟡 (16:13) Craft staged exactly 12 intended files, adding 438 insertions and 105 deletions, including new src/commands/workspace.ts, src/commands/workspace_cmds/list.ts, and src/commands/workspace_cmds/__tests__/list.test.ts.
• 🟡 (16:14) Assistant confirmed staged diffs contained only intended contract files and planned commits.
• 🟡 (16:18) Required lore staging check failed because pathspec .lore.md did not match any files. Staged summary confirmed new Publish parser, grammar, generation, location, revision, poller, resolver, and test files.
• 🟡 (16:20) Created Publish commit 52ef600 on feat/workspace-acceptance: feat: resolve compact workspace publish requests; 20 files changed, 1,601 insertions, 88 deletions. src/modules/post-workflow-details.js and src/publish/inputs.js remained uncommitted/unstaged.
• 🟡 (16:23) Created Craft commit 4862056 on feat/workspace-action-propagation: feat: support compact release workspaces; 12 files changed, 438 insertions, 105 deletions.
• 🟡 (16:24) Assistant noted both commits were created and planned verification against bases and branch pushes.
• 🟡 (16:26) Verified Publish’s only remaining local changes were newline/blank-line formatting in src/modules/post-workflow-details.js and src/publish/inputs.js; pushed feat/workspace-acceptance from b658ffa to 52ef600 at https://github.com/getsentry/publish.git. Remote reported 22 default-branch vulnerabilities: 12 high, 8 moderate, 2 low.
• 🟡 (16:27) Assistant confirmed Publish 52ef600 pushed and planned Craft push, PR check, review, thread, and comment monitoring; stated Publish must deploy ahead of Craft.
• 🟡 (16:29) Pushed Craft branch feat/workspace-action-propagation from 6dae341 to 4862056 at https://github.com/getsentry/craft.git. Remote reported 3 default-branch vulnerabilities: 2 high and 1 low.
• 🟡 (16:30) Assistant confirmed both PR branches pushed and began checking updated heads, CI, reviews, inline threads, comments, and merge gates.
• 🟡 (16:34) Task plan updated: “Fix adversarial review blockers in compact publish contract” completed; “Re-run adversarial review and verify both repositories” completed; “Commit, push, and monitor linked PRs” in progress; “Document workspace migration” pending/low priority.
• 🟡 (16:37) Craft PR #872 at head 48620564f86d8724982cddb6506c040235fe8954 was open draft, mergeStateStatus=BLOCKED, reviewDecision=REVIEW_REQUIRED, and had no reviews. All reported checks succeeded: Build & Test Node 22/Node 24/Build/Build Docs; Changelog Preview preview and Semver Impact; CodeQL actions/javascript/CodeQL; Dependency Review; Docs Preview; Enforce License Compliance; Lint fixes; Secret Scan; Warden/security review; image; Socket Security; and Semgrep. GitHub Actions posted a PR preview URL https://craft.sentry.dev/pr-preview/pr-872/.
• 🟡 (16:38) Assistant stated Craft PR #872 had clean CI/no review feedback but remained draft/review-blocked; stated Publish PR #9339 still had Warden and Cursor Bugbot activity and planned to wait for completion.
• 🟡 (16:39) Assistant scheduled a 2-minute follow-up (sny86pdk) to recheck Publish #9339 and Craft #872 PR checks, bots, threads, comments, and merge states.
• 🟡 (16:42) Publish PR #9339 at head 52ef600d6759911d4b76d7f3108c5a41c3e0ec2a was open, non-draft, mergeStateStatus=BLOCKED, reviewDecision=REVIEW_REQUIRED. Checks passed for CodeQL actions/javascript, dependency review, Secret Scan, unit tests, Cursor Bugbot (neutral), Seer Code Review, Socket Security, and Semgrep; Warden remained in progress. Cursor Bugbot posted a COMMENTED review identifying one potential issue.
• 🟡 (16:43) Assistant planned to retrieve Cursor Bugbot’s inline thread, validate it against the contract, and fix it if real.
• 🟡 (16:46) Assistant assessed Cursor’s finding as concern that root-config legacy path behavior would fail until Craft releases workspace list; stated planned version-gated compatibility idea, while asserting discovery errors should remain fail-closed once a root config requires compact classification.
• 🟡 (16:48) Publish .github/workflows/publish.yml “Resolve publish location” step initializes workspace_names='[]', calls needsWorkspaceDiscovery(input) from ./.__publish__/src/modules/publish-location, and when discovery is required with __repo__/.craft.yml, runs getsentry/craft:latest workspace list in Docker with __repo__ volume-mounted and workdir /github/workspace/__repo__; exports CRAFT_WORKSPACE_NAMES into resolve-location.js.
• 🟡 (16:49) Assistant concluded the bot report conflicted with approved rollout order: Publish uses getsentry/craft:latest, so Craft must release first and latest must contain both workspace list and --rev before this Publish controller change deploys; fallback to path behavior after failed discovery was deemed unsafe because it could silently misroute compact workspace requests.
• 🟡 (16:50) A reply was posted to Publish PR #9339 inline comment 3916489922: Craft-first release is an intentional deployment prerequisite; fallback after discovery failure is unsafe and discovery remains fail-closed when root .craft.yml requires compact classification. The relevant review thread PRRT_kwDOEgGvjc6elzOu remained unresolved at that moment, containing Cursor comment 3916354008 and the reply.
• 🟡 (16:51) Assistant concluded the Cursor finding was not a code defect under the approved deployment contract, documented the rationale, and planned to resolve the answered thread while monitoring remaining Warden gate.