Distillation

Date: Sep 8, 2026

• 🔴 [requested-security-fixes] (07:12) User directed implementation of fixes for ALL current correctness/security review blockers, with current sources read before editing.
• 🔴 [enforced-scope] (07:12) User restricted edits to /home/byk/.local/share/opencode-v2-pilot/supervisor/**, /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/pty.ts, /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/pty-transport.ts, config tsconfig/package files as needed, candidate service/CUTOVER, and /tmp/opencode/pty-plugin-smoke.ts.
• 🔴 (07:12) User prohibited installing, starting, or stopping services and prohibited modifying production.
• 🔴 (07:12) User required ControlGroup to come from the correct systemd Service interface on this systemd 255 host, while ActiveState, SubState, and InvocationID remain on Unit and MainPID remains on Service.
• 🔴 [requested-tests] (07:12) User required real-interface-aware regression coverage for systemd property interfaces, not only synthetic combined maps.
• 🔴 (07:12) User stated: “Never trust forgeable D-Bus signals as cleanup proof.”
• 🔴 (07:12) User required restricting signal sender to systemd where possible, accounting for well-known versus unique sender semantics.
• 🔴 (07:12) User required treating UnitRemoved only as a wakeup and independently querying with a bounded context to prove NoSuchUnit or an empty cgroup before returning cleanup success.
• 🔴 (07:12) User required avoiding godbus deferred-delivery goroutine amplification through a bounded signal strategy, or avoiding signal dependence in favor of bounded state queries/backoff without sleep-based external orchestration.
• 🔴 [requested-tests] (07:12) User required a test that forges a matching D-Bus signal and proves it cannot produce false cleanup success.
• 🔴 (07:12) User required bounding the STOP write itself before the 25-second exit wait in /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/pty-transport.ts; on timeout, destroy the socket and fail.
• 🔴 (07:12) User stated that terminate, deletion, and unload must “always finish or return within bounds.”
• 🔴 [requested-tests] (07:12) User required a saturated/backpressured STOP test.
• 🔴 (07:12) User required bounding pendingOutput before plugin listener registration by total bytes, at no more than plugin MAX_BUFFER_SIZE or a smaller limit, and consistently retaining only a bounded tail.
• 🔴 (07:12) User requested avoiding repeated Buffer.concat quadratic growth in the frame parser if practical.
• 🔴 [requested-tests] (07:12) User required a test for an immediate output flood before listener registration.
• 🔴 (07:12) User required closing every installed fd on MSG_CTRUNC and on all parse failures.
• 🔴 (07:12) User required a receive-buffer/control strategy for truncated rights, parsing and closing known descriptors before returning, a strict maximum descriptor count, and retaining MSG_CMSG_CLOEXEC.
• 🔴 [requested-tests] (07:12) User required fd-handling tests using 3 or more descriptors that prove no /proc/self/fd growth.
• 🔴 (07:12) User required fixing canonical isolated config TypeScript validation by deduplicating Effect resolution through tsconfig paths/package setup, without broadening checked scope to unrelated legacy plugins.
• 🔴 (07:12) User required tsgo -p /home/byk/.local/share/opencode-v2-pilot/config/opencode/tsconfig.json to pass against the exact current source while preserving the authoritative checkout plugin API.
• 🔴 (07:12) User stated helper documentation must “never claim the entire Go binary opens no path.”
• 🔴 (07:12) User required helper documentation to state the exact application invariant: the helper “never initiates socket connections,” resolves caller paths, or opens application-selected paths.
• 🔴 (07:12) User required helper documentation to list unavoidable Go runtime host-metadata reads if observed.
• 🔴 (07:12) User required acceptance tracing to permit only reviewed runtime-metadata paths and reject application-selected path or socket opens.
• 🔴 (07:12) User stated exact Node 26.4 SEA descriptor behavior remains a privileged/runtime acceptance item unless it can be proven unprivileged with the final binary without starting services.
• 🔴 (07:12) User requested a deterministic exact-runtime helper-inheritance probe if feasible.
• 🔴 (07:12) User stated: “Never fake it with Node 24.”
• 🔴 (07:12) User required admission control to ensure a legitimate authenticated MainPID is not denied solely because same-UID unauthenticated peers consumed a global minute quota.
• 🔴 (07:12) User required credential prefiltering/rate buckets or safely reserved authenticated capacity, noting that only MainPID can fully authenticate, while keeping D-Bus work bounded.
• 🔴 [requested-tests] (07:12) User required a test proving admission floods cannot consume all valid capacity.
• 🔴 (07:12) User required the readiness marker to contain exactly 4 lines: line 1 must use the exact reviewed revision format/value mechanism; lines 2–4 must contain exact SHA-256 values and fixed paths /usr/local/libexec/opencode-pty-supervisor, /usr/local/libexec/opencode-pty-launcher, and /usr/local/libexec/opencode-pty-client in that fixed order; no duplicates or trailing lines are allowed.
• 🔴 (07:12) User stated an arbitrary hexadecimal value must never be treated as source binding.
• 🔴 (07:12) User preferred a root-controlled verification helper/script, itself content-bound and reviewed, if shell ExecCondition is too weak.
• 🔴 (07:12) User required updating CUTOVER and ROOT-ACCEPTANCE.
• 🔴 (07:12) User required all documentation and tests to accurately identify SAME-UID ptrace/descriptor delegation and exact-host checks as outstanding deployment blockers.
• 🔴 (07:12) User stated source changes must not be claimed to prove root acceptance.
• 🔴 (07:12) User said the /tmp harness may remain if appropriate, but must be documented and invoked in ROOT-ACCEPTANCE; persistent transport/tool tests should be added where practical outside auto-discovered plugins.
• 🔴 (07:12) User stated root-only checks remain pending.
• 🔴 (07:12) User required running gofmt, go test -count=1 ./..., go test -race -count=1 ./..., go vet, deterministic builds with exact flags and reported hashes, the canonical tsgo config check, the exact dedicated check, PTY smoke 10 times, and offline systemd verification/security checks.
• 🔴 (07:12) User prohibited claiming root acceptance and requested a report containing exact edits, exact results, residual blockers, and whether the candidate is ready for fresh review.
• 🟡 (07:12) Assistant committed to inspect the exact isolated source, tests, configs, units, and acceptance documentation first; keep every edit within authorized paths; and leave services and production state untouched.
• 🟡 (07:12) Source inventory under /home/byk/.local/share/opencode-v2-pilot/supervisor/ included ROOT-ACCEPTANCE.md, PROTOCOL.md, binaries under bin/, opencode-pty.slice, opencode-pty-supervisor.service, go.mod, go.sum, command sources/tests under cmd/client/, cmd/launcher/, and cmd/supervisor/, protocol files internal/protocol/frame.go and frame_test.go, and supervisor files internal/supervisor/auth.go, auth_test.go, server.go, server_test.go, systemd.go, and systemd_test.go.
• 🟡 (07:12) Config inventory included /home/byk/.local/share/opencode-v2-pilot/config/opencode/tsconfig.json, /home/byk/.local/share/opencode-v2-pilot/config/opencode/package.json, /home/byk/.local/share/opencode-v2-pilot/config/opencode/bun.lock, and /home/byk/.local/share/opencode-v2-pilot/config/opencode/test/followup.test.ts.
• 🟡 (07:12) Plugin inventory included /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/pty-transport.ts, /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/pty.ts, and unrelated legacy plugin /home/byk/.local/share/opencode-v2-pilot/config/opencode/plugins/followup.ts.
• 🟡 (07:13) Candidate cutover documentation was located at /home/byk/.local/share/opencode-v2-pilot/CUTOVER.md.
• 🟡 (07:13) Inspection of /home/byk/.local/share/opencode-v2-pilot/supervisor/internal/supervisor/systemd.go showed operationTimeout = 5 * time.Second and unitPattern = regexp.MustCompile(\^opencode-pty-[0-9a-f]{32}.service$`)`.
• 🟡 (07:13) Existing /home/byk/.local/share/opencode-v2-pilot/supervisor/internal/supervisor/systemd_test.go contained: TestUnitNameGrammar; TestWaitForUnitSignalRejectsClosedChannelAndHonorsTimeout; TestWaitForJobResultRejectsClosedNonDoneAndTimeout; TestUnitPropertiesAreFixed; and TestDecodeUnitResult.
• 🟡 (07:13) TestUnitNameGrammar accepted opencode-pty-0123456789abcdef0123456789abcdef.service and rejected an empty identifier, uppercase hexadecimal identifier, .scope suffix, and path-traversal-style suffix.
• 🟡 (07:13) TestWaitForUnitSignalRejectsClosedChannelAndHonorsTimeout checked rejection of a closed chan *dbus.Signal and expected context.DeadlineExceeded after a 1-millisecond timeout.
• 🟡 (07:13) TestWaitForJobResultRejectsClosedNonDoneAndTimeout checked rejection of a closed channel, rejection of the non-done result "canceled", and context.DeadlineExceeded after a 1-millisecond timeout.
• 🟡 (07:13) TestUnitPropertiesAreFixed constructed unitProperties(...) using command sh -c "echo ok", /dev/null streams, and runtime value 60; checked a fixed set of service properties; expected User == "byk" and Delegate == false; expected signatures (bas) for RestrictAddressFamilies and SystemCallFilter; and expected signature as for SupplementaryGroups.
• 🟡 (07:13) TestDecodeUnitResult decoded {"Result":"exit-code","ExecMainCode":int32(1),"ExecMainStatus":int32(7)} and expected result "exit-code", main code 1, and main status 7.