Distillation

Date: Sep 16, 2026

• 🔴 (12:43) User stated the gateway bundle test builds the bundle on demand in beforeAll, so it always runs against a bundle built from current source.
• 🔴 (12:43) User stated packages/gateway/test/bundle-exports.test.ts must rebuild a missing or stale dist/ bundle so assertions never run against an artifact that predates source; the rebuild wipes and recreates dist/, and nothing else reads dist/ during that test.
• 🔴 (12:43) User stated native binding resolution is fail-closed and must never interrupt WASM fallback, including failures while closing a native binding file descriptor.
• 🔴 (12:43) User stated the source-workspace resolver fallback checks only the worker package’s own node_modules; it never selects an arbitrary ancestor workspace package.
• 🔴 (12:43) User stated native package resolution never throws: an unresolvable package is the expected dist-only case and must return null so execution falls back to WASM.
• 🟡 (12:43) Assistant limited planned edits to proven gaps in three areas: resolver scope, load-time WASM recovery, and tests that execute each emitted worker under its supported runtime.
• 🟡 (12:43) Root package.json pins packageManager to pnpm@10.28.0 and Volta to Node 24.16.0 plus pnpm 10.28.0; pnpm.onlyBuiltDependencies contains esbuild, onnxruntime-node, and sharp, while the override for onnxruntime-node is 1.27.0.
• 🟡 (12:43) Root validation/build scripts include "test": "vitest run", "pretest": "pnpm --filter @loreai/gateway run bundle", "test:coverage": "pnpm --filter @loreai/gateway run bundle && vitest run --coverage", "premutation": "pnpm --filter @loreai/gateway run bundle", "mutation": "stryker run", and "postinstall": "pnpm --filter @loreai/gateway run build".
• 🟡 (12:44) Repository review policy in AGENTS.md and quality/REVIEW.md requires every adversarial-review defect to receive a deterministic regression that fails on the base branch, passes on the fix, drives the real precondition, and fails when the tested guard is deleted.
• 🟡 (12:44) quality/REVIEW.md mandates two distinct review passes for non-trivial changes: 1. adversarial/correctness review covering enumerated break states, apply-then-revert mutants, property-test stability ×10, hash-equivalence proofs, frozen-array mutation safety, and stale-cache analysis; 2. security/pentest review covering injection vectors, credential leaks, protocol-level attacks, and privilege escalation.
• 🟡 (12:44) Reviewers must run pnpm test, pnpm run typecheck, pnpm run lint, and pnpm run format:check; verify exit codes, property-test stability across 10 runs, and an unmodified hash-verified working tree; then report per-point PASS / FAIL / CONCERN / MUST-FIX verdicts with file:line evidence plus an overall MERGE / DO-NOT-MERGE verdict.
• 🟡 (12:44) packages/core/src/ort-native.ts defines supported native targets as frozen ORT_NATIVE_TARGETS: linux-x64, linux-arm64, darwin-arm64, win32-x64, and win32-arm64; package names use the literal @loreai/onnxruntime-<platform>-<arch> form and the binding filename is onnxruntime_binding.node.
• 🟡 (12:44) packages/core/src/ort-native.ts:117-125 permits Linux native ONNX Runtime only when process.report exposes a parseable glibc runtime version of at least 2.27; unknown or malformed Linux libc information fails closed to WASM.
• 🟡 (12:44) packages/core/src/ort-native.ts:136-180 resolves package manifests through createRequire(fromPath).resolve(), canonicalizes paths with realpathSync(), rejects bindings outside the canonical package directory or non-files, and validates native magic bytes: ELF 7f 45 4c 46 for Linux, Mach-O cf fa ed fe or fe ed fa cf for Darwin, and MZ (4d 5a) for Windows.