Distillation

Date: Sep 17, 2026

• 🔴 (09:25) User asserted the project’s TDD rule: “Never trust the fix without seeing it fail.” Every bug fix must start with a deterministic regression test that fails on the base branch and passes on the fix.
• 🔴 (09:25) Project regression tests must drive the real precondition; tests of a guard must fail if that guard is deleted.
• 🔴 (09:25) Project adversarial-order test setup includes: state present before the handling operation, delete-then-recreate across lifecycle boundaries, and modify-while-off.
• 🔴 (09:25) Project fan-out registry batteries map SYNCED_TABLES to packages/core/test/sync-registry-contract.test.ts, MIGRATIONS to the db.test.ts schema-version assertion plus migration-specific tests, and AGENTS to agents.test.ts.
• 🔴 (09:25) Project standing test batteries cover registry contracts, per-operation sync invariants through assertSyncInvariants in packages/core/src/sync-data.ts, and sequence properties in packages/gateway/test/sync.property.test.ts.
• 🔴 (09:25) Project review heuristics identify skip/early-return branches as the highest-risk surface; examples include NOT EXISTS, latest <> 'upsert', and content-match guards. Each skip branch needs a test that makes it fire incorrectly and proves it does not skip required work.
• 🔴 (09:25) Project review heuristics favor property-based tests over faithful mocks; the #833 property battery found four sequence-dependent engine bugs across enable/disable/push/pull boundaries that example tests had missed.
• 🔴 (09:25) Project guidance says memoized arrays shared by multiple callers should be frozen so accidental mutation throws TypeError in strict mode rather than silently corrupting the cache.
• 🔴 (09:25) Project guidance states db().query monkeypatches are shadowed by the tracing Proxy; SQL-counting tests must use log.registerSink({ withDbSpan }), as empirically verified in #874.
• 🔴 (09:25) Reviewers must run pnpm test, pnpm run typecheck, pnpm run lint, and pnpm run format:check; they must inspect exit codes because a blank command tail can hide lint or formatting failures.
• 🔴 (09:25) Reviewers must run property tests ×10, hash-verify that the working tree is unmodified afterward, report per-point PASS / FAIL / CONCERN / MUST-FIX verdicts with file:line evidence, and give an overall MERGE / DO-NOT-MERGE verdict.
• 🔴 (09:25) Correctness-critical changes involving the sync engine, hashing, lifecycle, or migrations require adversarial review regardless of size; mechanical or test-only PRs may skip it at reviewer discretion.
• 🟡 (09:25) Working revision tmzmtlsspstn / commit 01e1ee401324aea61a6bf3a33ae56a344b7034c9 has parent 2cbf40060c67df229731cf1b9e34d5bf22ec2145, conflict=false, and empty=false; its description is fix(core): correct embedding runtime selection and admission.
• 🟡 (09:25) Audit baseline parent is revision pxrvwsvvkmpo / commit 2cbf40060c67df229731cf1b9e34d5bf22ec2145, described as feat(cch): add seeds for Claude Code up to 2.1.272 (#1780).
• 🟡 (09:25) The working copy contains 20 changed paths: added packages/core/src/cgroup-memory.ts and packages/core/test/cgroup-memory.test.ts; modified packages/core/src/embedding/local.ts, packages/core/src/embedding/pool.ts, packages/core/src/embedding-cap.ts, packages/core/src/embedding-worker-types.ts, packages/core/src/embedding-worker.ts, packages/core/src/embedding.ts, packages/core/src/ort-native.ts, packages/core/test/embedding-cap.test.ts, packages/core/test/embedding-pool-memory.test.ts, packages/core/test/embedding-pool.test.ts, packages/core/test/embedding-wasm-fallback.test.ts, packages/core/test/embedding-worker-stdio.test.ts, packages/core/test/embedding-worker-types.test.ts, packages/core/test/ort-native.test.ts, packages/gateway/script/bundle.ts, packages/gateway/script/ort-platform-package.ts, packages/gateway/test/bundle-exports.test.ts, and packages/gateway/test/ort-platform-package.test.ts.
• 🟡 (09:25) Jujutsu warned that bookmark fix/responses-private-references has conflicts, while the audited working revision itself reports conflict=false.
• 🟡 (09:25) A working-tree hash command returned eb8a9bc8e2c921d3f055314aa87581b3df0fc5b32955f44b4b51e4a3c5e5a1b6.
• 🔴 (09:26) User asserted the embedding telemetry rule: “Telemetry must never break the embedding path.”
• 🔴 (09:26) User stated the module-runtime convention: “CJS uses __filename (always defined); ESM uses import.meta.url.”
• 🔴 (09:26) User stated __filename is “always defined there” in CJS, making the related fallback branch unreachable in CJS at runtime.
• 🔴 (09:26) User stated the self-heal re-probe timestamp uses 0 to mean “never (primed on first tick).”
• 🟡 (09:26) Relevant embedding tests located during the audit include packages/core/test/embedding-pool-memory.test.ts, packages/core/test/embedding-cap.test.ts, packages/core/test/embedding-cap-persistence.test.ts, and packages/core/test/embedding-pool.test.ts.