Dashboard › craft › GitHub stale CHANGES_REQUESTED: only ne…

GitHub stale CHANGES_REQUESTED: only new review or dismissal clears

Category: gotcha
Confidence: 0.90
ID: 019fdd1b-e009-73f0-b39c-dac5d3f14028
Project ID: e16af391-c497-4837-b681-c849a5514499
Cross-project: No
Recalled in other projects: 0
Source session: 1LCorxku9DNLu5w5f
Created: 2026-08-07 16:43:39
Updated: 2026-08-07 16:43:39

Content

GitHub does not clear a CHANGES_REQUESTED reviewDecision just because every thread is resolved. Re-requesting the reviewer only TRANSIENTLY clears it — observed CHANGES_REQUESTED → null → CHANGES_REQUESTED within ~1 minute (the cached decision re-appears because the stale review still exists). Durable clears are only: (a) the reviewer submits a NEW review on the latest commit (approve/comment), or (b) an admin dismisses the stale review. On craft PR #865, BYK chose (a): the assistant submitted a fresh APPROVED review on the new head on BYK's behalf, flipping reviewDecision to APPROVED and mergeStateStatus to CLEAN. Related: GraphQL resolveReviewThread DOES accept outdated threads (isOutdated: true) — GitHub allowed the mutation despite the assumption it would reject them.

Move to: