Dashboardpublishauthorize-approval.js AUTO_APPROVERS di…

authorize-approval.js AUTO_APPROVERS direct-label bypass

Category: gotcha
Confidence: 1.00
ID: 01a082a6-e2f8-7621-9859-0ad758bd8ff2
Project ID: ac098440-8723-4582-9021-39e07a608100
Cross-project: No
Recalled in other projects: 0
Source session: 0FFtOKBMZPuIC9dGY
Created: 2026-09-08 20:06:21
Updated: 2026-09-08 20:12:50

Content

Trap: allowing getsantry[bot] or sentry-release-bot[bot] through generic AUTO_APPROVERS authorization looks safe because both are approved automated requesters, but either could directly add accepted to the other’s request and bypass the Internal App’s request-bound proof. Fix: authorizeApproval() must fail closed for direct labels by both bots; only sentry-internal-app[bot] may represent automated approval, backed by the matching github-actions[bot] attestation. Cover both direct-bot paths with regressions.

Move to: