DashboardpublishAlways test approval authorization as f…

Always test approval authorization as fail-closed

Category: preference
Confidence: 0.80
ID: 01a08772-2288-742e-91b7-a3ef5a83a0e4
Project ID: ac098440-8723-4582-9021-39e07a608100
Cross-project: No
Recalled in other projects: 0
Source session: 1eyAruiNgZJ4qgkPR
Created: 2026-09-09 18:33:19
Updated: 2026-09-09 18:33:19

Content

When changing release approval logic, preserve comprehensive tests for authorization boundaries. Verify automated approver identities cannot directly approve or fall back to collaborator permissions, malformed publish titles return unauthorized with a null repository, and only target-repository roles write, maintain, or admin authorize humans. Cover qualified and unqualified repository titles, exact repository resolution, allowlist mismatches, and ensure rejected bot or malformed-title paths do not call GitHub permission APIs. Also verify permission lookup failures propagate rather than silently authorizing or degrading.

Move to: