Dashboard › publish › Session 0buxzUmxVCIK
0buxzUmxVCIKGoXa4Perform a final independent, read-only correctness and security review of the exact current working tree in /home/byk/Code/getsentry/publish. Focus especially on the newly added requester/approver separation guard in src/publish/authorize-approval.js, including GitHub response data shapes, race behavior, and interactions with auto-approval. Also verify the previously remediated workflow_dispatch trusted checkout and attestation handoffs remain correct. Do not edit files. Inspect git diff and relevant tests. Report only substantive findings with current file:line evidence, classify as PASS, CONCERN, or MUST-FIX, and end exactly MERGE or DO-NOT-MERGE. This is correctness-critical release authorization behavior.
<path>/home/byk/Code/getsentry/publish</path> <type>directory</type> <entries> .eslintrc.js .git/ .github/ .gitignore .lore.md AGENTS.md auto-approve-repos.txt docs/ LICENSE node_modules/ package.json README.md src/ vitest.config.js yarn.lock (15 entries) </entries>
M .github/workflows/ci-poller.yml M .github/workflows/publish.yml M AGENTS.md M src/libs/__tests__/github.js M src/libs/github.js M src/modules/__tests__/details-from-context.js M src/modules/__tests__/update-issue.js M src/modules/details-from-context.js M src/modules/post-workflow-details.js M src/modules/process-end-state.js M src/modules/update-issue.js M src/publish/inputs.js M src/publish/post-result.js M src/publish/post-workflow-details.js M src/publish/update-issue.js ?? .lore.md ?? src/modules/__tests__/approval-attestation.js ?? src/modules/__tests__/approval-authorizer.js ?? src/modules/approval-attestation.js ?? src/modules/approval-authorizer.js ?? src/publish/__tests__/ ?? src/publish/authorize-approval.js ?? src/publish/current-accepted-event.js ?? src/publish/record-ci-ready-attestation.js ?? src/publish/validate-approval-attestation.js .github/workflows/ci-poller.yml | 142 ++++++++++++++++++++++++-- .github/workflows/publish.yml ...
Found 100 matches (more matches available)
/home/byk/Code/getsentry/publish/.github/workflows/publish.yml:
Line 18: # When accepted is added to a publish issue:
Line 23: # The publish job below requires ci-ready, so it will not fire until the
Line 24: # poller flips ci-pending → ci-ready (which also prevents publishing without
Line 31: github.event.label.name == 'accepted'
Line 67: run: node src/publish/authorize-approval.js
Line 79: --body "${{ steps.authorization.outputs.approval_attestation }}"
Line 91: run: node src/publish/validate-approval-attestation.js
Line 107: --remove-label "accepted"
Line 110: --body "Approval is invalid or could not be verified. Re-add the accepted label to retry after resolving the issue."
Line 115: # - Remove ci-ready (retries after a publish failure — if we leave
Line 116: # ci-ready, the poller's later --add-label won't generate a
Line 128: ...
<path>/home/byk/Code/getsentry/publish/src/publish/authorize-approval.js</path>
<type>file</type>
<content>
1: const fs = require("fs");
2: const {
3: createApprovalAttestation,
4: currentAcceptedEvent,
5: } = require("../modules/approval-attestation.js");
6: const { authorizeApproval } = require("../modules/approval-authorizer.js");
7:
8: function getAutoApprovedRepositories() {
9: return new Set(
10: fs
11: .readFileSync("auto-approve-repos.txt", "utf8")
12: .split(/\r?\n/)
13: .filter(Boolean)
14: );
15: }
16:
17: async function getPermission({ owner, repository, username }) {
18: const response = await getGitHubResponse(
19: `repos/${encodeURIComponent(owner)}/${encodeURIComponent(
20: repository
21: )}/collaborators/${encodeURIComponent(username)}/permission`
22: );
23:
24: if (!response.ok) {
25: throw new Error(
26: `Could not retrieve ${username}'s permission for ${owner}/${repository}: GitHub returned ...
<path>/home/byk/Code/getsentry/publish/src/modules/approval-authorizer.js</path>
<type>file</type>
<content>
1: const ALLOWED_ROLE_NAMES = new Set(["write", "maintain", "admin"]);
2: const AUTO_APPROVER = "getsantry[bot]";
3: const { parsePublishTitle } = require("./details-from-context.js");
4:
5: async function authorizeApproval({
6: actor,
7: issueTitle,
8: getPermission,
9: autoApprovedRepositories = new Set(),
10: }) {
11: const title = parsePublishTitle(issueTitle);
12:
13: if (!title) {
14: return { authorized: false, repository: null };
15: }
16:
17: const repository = `getsentry/${title.repo}`;
18: const releasePath = `${repository}${title.path || ""}`;
19:
20: if (actor === AUTO_APPROVER && autoApprovedRepositories.has(releasePath)) {
21: return { authorized: true, repository };
22: }
23:
24: if (actor === AUTO_APPROVER) {
25: return { authorized: false, repository };
26: }
27:
28: const { role_name } = await getPermission({
29: ...
<path>/home/byk/Code/getsentry/publish/src/modules/approval-attestation.js</path>
<type>file</type>
<content>
1: const crypto = require("crypto");
2:
3: const APPROVAL_ATTESTATION_PREFIX = "<!-- publish-approval ";
4: const CI_READY_ATTESTATION_PREFIX = "<!-- publish-ci-ready ";
5: const ATTESTATION_SUFFIX = " -->";
6:
7: function createAttestation(prefix, value) {
8: return `${prefix}${Buffer.from(JSON.stringify(value)).toString(
9: "base64url"
10: )}${ATTESTATION_SUFFIX}`;
11: }
12:
13: function requestDigest({ body, labels, title }) {
14: if (typeof body !== "string" || !Array.isArray(labels)) {
15: throw new Error("Invalid publish request");
16: }
17:
18: return crypto
19: .createHash("sha256")
20: .update(
21: JSON.stringify({
22: body,
23: dryRun: labels.some((label) => label.name === "dry-run"),
24: title,
25: })
26: )
27: .digest("hex");
28: }
29:
30: function createApprovalAttestation({ actor, eventId, ...
<path>/home/byk/Code/getsentry/publish/src/publish/validate-approval-attestation.js</path>
<type>file</type>
<content>
1: const {
2: currentAcceptedEvent,
3: currentCiReadyEvent,
4: hasApprovalAttestation,
5: hasCiReadyAttestation,
6: } = require("../modules/approval-attestation.js");
7:
8: async function getGitHubResponse(path) {
9: return fetch(`https://api.github.com/${path}`, {
10: headers: {
11: Accept: "application/vnd.github+json",
12: Authorization: `Bearer ${process.env.APPROVAL_TOKEN}`,
13: "X-GitHub-Api-Version": "2026-03-10",
14: },
15: });
16: }
17:
18: async function getIssue({ repository, issueNumber }) {
19: const response = await getGitHubResponse(
20: `repos/${repository}/issues/${issueNumber}`
21: );
22:
23: if (!response.ok) {
24: throw new Error(
25: `Could not retrieve issue #${issueNumber}: GitHub returned ${response.status}`
26: );
27: }
28:
29: return response.json();
30: }
31:
32: async ...
<path>/home/byk/Code/getsentry/publish/src/publish/record-ci-ready-attestation.js</path>
<type>file</type>
<content>
1: const fs = require("fs");
2: const {
3: createCiReadyAttestation,
4: currentAcceptedEvent,
5: } = require("../modules/approval-attestation.js");
6: const {
7: getAllPages,
8: getGitHubResponse,
9: getIssue,
10: } = require("./validate-approval-attestation.js");
11:
12: async function getAuthenticatedLogin() {
13: const response = await getGitHubResponse("user");
14:
15: if (!response.ok) {
16: throw new Error(
17: `Could not retrieve the authenticated user: GitHub returned ${response.status}`
18: );
19: }
20:
21: const { login } = await response.json();
22:
23: if (typeof login !== "string") {
24: throw new Error("GitHub returned no authenticated user login");
25: }
26:
27: return login;
28: }
29:
30: async function recordCiReadyAttestation({
31: expectedAcceptedEvent,
32: getAuthenticatedLogin,
33: getIssue,
34: ...
<path>/home/byk/Code/getsentry/publish/.github/workflows/publish.yml</path>
<type>file</type>
<content>
1: name: Publish
2: on:
3: issues:
4: types: [labeled]
5:
6: concurrency:
7: # Use the issue title (e.g. "publish: getsentry/foo@1.2.3") so duplicate
8: # issues for the same repo@version share a concurrency group.
9: group: ${{ github.event.issue.title }}
10: cancel-in-progress: false
11:
12: permissions:
13: contents: read
14: issues: write
15: packages: write
16:
17: jobs:
18: # When accepted is added to a publish issue:
19: # - Add ci-pending (and remove ci-failed if retrying)
20: # - Enable the poller via CI_POLLER_HAS_PENDING=true
21: # - Comment on the issue
22: # - Trigger the poller immediately so we don't wait for the next cron tick
23: # The publish job below requires ci-ready, so it will not fire until the
24: # poller flips ci-pending → ci-ready (which also prevents publishing without
25: # CI verification in the ...
<path>/home/byk/Code/getsentry/publish/.github/workflows/ci-poller.yml</path> <type>file</type> <content> 1: name: CI Status Poller 2: 3: on: 4: schedule: 5: - cron: "*/5 * * * *" 6: workflow_dispatch: 7: inputs: 8: attempt: 9: description: Self-dispatch attempt counter (internal use) 10: required: false 11: default: "0" 12: 13: permissions: 14: contents: read 15: issues: write 16: 17: jobs: 18: check-ci: 19: runs-on: ubuntu-latest 20: environment: production 21: # Skip entirely (no runner provisioned) when there's nothing to check. 22: # Set to "true" by ci-pending.yml, reset to "false" here when done. 23: # Always allow workflow_dispatch for manual recovery. 24: if: vars.CI_POLLER_HAS_PENDING == 'true' || github.event_name == 'workflow_dispatch' 25: concurrency: 26: group: ci-status-poller 27: cancel-in-progress: false 28: steps: 29: - name: Get publish code 30: uses: ...
<path>/home/byk/Code/getsentry/publish/.github/workflows/auto-approve.yml</path>
<type>file</type>
<content>
1: name: auto-approve non-sdks
2: on:
3: issues:
4: types: [opened]
5:
6: permissions:
7: contents: read
8:
9: jobs:
10: auto-approve:
11: runs-on: ubuntu-latest
12: if: |
13: (github.actor == 'sentry-release-bot[bot]' || github.actor == 'getsantry[bot]') &&
14: startsWith(github.event.issue.title, 'publish: ')
15: steps:
16: - uses: actions/checkout@v4
17: with:
18: sparse-checkout: auto-approve-repos.txt
19: sparse-checkout-cone-mode: false
20: - name: Get auth token
21: id: token
22: uses: actions/create-github-app-token@v3
23: with:
24: client-id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
25: private-key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
26: - name: Auto-approve if repo is in the list
27: env:
28: GH_TOKEN: ${{ ...
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__</path> <type>directory</type> <entries> authorize-approval.js ci-poller-workflow.js current-accepted-event.js record-ci-ready-attestation.js validate-approval-attestation.js (5 entries) </entries>
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/authorize-approval.js</path>
<type>file</type>
<content>
1: import { afterEach, describe, expect, test, vi } from "vitest";
2: import fs from "fs";
3: const {
4: getAutoApprovedRepositories,
5: main,
6: } = require("../authorize-approval.js");
7:
8: const originalEnvironment = { ...process.env };
9:
10: afterEach(() => {
11: process.env = { ...originalEnvironment };
12: vi.restoreAllMocks();
13: vi.resetModules();
14: });
15:
16: function jsonResponse(json) {
17: return { ok: true, json: vi.fn().mockResolvedValue(json) };
18: }
19:
20: async function runAuthorization({ actor, issueTitle, responses }) {
21: process.env.GITHUB_OUTPUT = "/tmp/github-output";
22: process.env.APPROVAL_TOKEN = "release-bot-token";
23: process.env.APPROVAL_ACTOR = actor;
24: process.env.APPROVAL_ISSUE_NUMBER = "123";
25: process.env.APPROVAL_ISSUE_REPOSITORY = "getsentry/publish";
26: process.env.APPROVAL_ISSUE_TITLE = ...
<path>/home/byk/Code/getsentry/publish/src/modules/__tests__/approval-authorizer.js</path>
<type>file</type>
<content>
1: import { describe, expect, test, vi } from "vitest";
2:
3: const { authorizeApproval } = require("../approval-authorizer.js");
4:
5: const issueTitle = "publish: getsentry/sentry-javascript@10.0.0";
6:
7: describe("authorizeApproval", () => {
8: test("allows the auto-approval bot for an allowlisted release without a target repository lookup", async () => {
9: const getPermission = vi.fn();
10:
11: await expect(
12: authorizeApproval({
13: actor: "getsantry[bot]",
14: issueTitle,
15: getPermission,
16: autoApprovedRepositories: new Set(["getsentry/sentry-javascript"]),
17: })
18: ).resolves.toEqual({
19: authorized: true,
20: repository: "getsentry/sentry-javascript",
21: });
22:
23: expect(getPermission).not.toHaveBeenCalled();
24: });
25:
26: test("rejects the auto-approval bot ...
<path>/home/byk/Code/getsentry/publish/src/modules/details-from-context.js</path> <type>file</type> <content> 1: /** 2: * Matches the entire "Targets" section of a github publish issue body. 3: */ 4: const TARGETS_SECTION_PARSER_REGEX = 5: /^(?!### Targets$\s)(?: *- \[[ xX]\] \S+\s*$(?:\r?\n)?)+/m; 6: 7: /** 8: * Matches all targets of a github publish issue body in a section that was already matched and extracted with `TARGETS_PARSER_REGEX`. 9: * The "id" of the targets is captured within a capture group. 10: */ 11: const TARGETS_PARSER_REGEX = /^\s*- \[[ x]\] (\S+)/gim; 12: 13: /** 14: * Matches checked targets of a github publish issue body in a section that was already matched and extracted with `TARGETS_PARSER_REGEX`. 15: * The "id" of the targets is captured within a capture group. 16: */ 17: const CHECKED_TARGETS_PARSER_REGEX = /^\s*- \[x\] (\S+)/gim; 18: const PUBLISH_TITLE_REGEX = 19: /^publish: ...
<path>/home/byk/Code/getsentry/publish/.github/workflows/publish.yml</path>
<type>file</type>
<content>
320: version_sanitised="$(sanitise "$CRAFT_PUBLISH_VERSION")"
321: state_dir="$GITHUB_WORKSPACE/.craft-state/craft"
322: state_file="$state_dir/publish-state-${owner_sanitised}-${repo_sanitised}-${cwd_hash}-${version_sanitised}.json"
323: mkdir -p "$state_dir"
324: printf %s "$payload" > "$state_file"
325: echo "Wrote state file: $state_file"
326:
327: - uses: docker://getsentry/craft:latest
328: name: Publish using Craft
329: with:
330: entrypoint: /bin/bash
331: args: >-
332: -e
333: -c "
334: export HOME=/root &&
335: cd __repo__/${{ fromJSON(steps.inputs.outputs.result).path }} &&
336: exec craft publish ${{ fromJSON(steps.inputs.outputs.result).version }}
337: "
338: env:
339: # Pin ...
diff --git a/.github/workflows/ci-poller.yml b/.github/workflows/ci-poller.yml
index a3db430..3eb2cd9 100644
--- a/.github/workflows/ci-poller.yml
+++ b/.github/workflows/ci-poller.yml
@@ -12,7 +12,7 @@ on:
permissions:
contents: read
- issues: read
+ issues: write
jobs:
check-ci:
@@ -26,6 +26,13 @@ jobs:
group: ci-status-poller
cancel-in-progress: false
steps:
+ - name: Get publish code
+ uses: actions/checkout@v6
+ with:
+ # workflow_dispatch can target any ref. Always run trusted code.
+ ref: ${{ github.event.repository.default_branch }}
+ persist-credentials: false
+
# sentry-internal-app token for label changes on this repo.
# This token is what triggers publish.yml downstream — see
# https://github.com/getsentry/publish for why GITHUB_TOKEN can't.
@@ -92,12 +99,49 @@ jobs:
title=$(echo "$issue" | jq -r '.title')
body=$(echo "$issue" | jq -r '.body')
- ...
<path>/home/byk/Code/getsentry/publish/src/modules/__tests__/approval-attestation.js</path>
<type>file</type>
<content>
1: import { describe, expect, test } from "vitest";
2:
3: const {
4: createApprovalAttestation,
5: createCiReadyAttestation,
6: currentAcceptedEvent,
7: hasApprovalAttestation,
8: hasCiReadyAttestation,
9: parseApprovalAttestation,
10: requestDigest,
11: } = require("../approval-attestation.js");
12:
13: function issue(title, { body = "", dryRun = false } = {}) {
14: return {
15: body,
16: labels: dryRun ? [{ name: "dry-run" }] : [],
17: title,
18: };
19: }
20:
21: describe("approval attestations", () => {
22: test("matches the latest accepted event to a trusted attestation", () => {
23: const title = "publish: getsentry/relay/py@1.2.3";
24: const publishIssue = issue(title);
25: const attestation = createApprovalAttestation({
26: actor: "contractor",
27: eventId: "200",
28: issue: publishIssue,
29: ...
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/ci-poller-workflow.js</path>
<type>file</type>
<content>
1: import { readFileSync } from "fs";
2: import { describe, expect, test } from "vitest";
3:
4: const workflow = readFileSync(".github/workflows/ci-poller.yml", "utf8");
5:
6: describe("CI poller workflow", () => {
7: test("checks out trusted code before requesting app tokens", () => {
8: expect(workflow).toMatch(
9: /- name: Get publish code\n\s+uses: actions\/checkout@v6\n\s+with:\n(?:\s+#.*\n)*\s+ref: \$\{\{ github\.event\.repository\.default_branch \}\}/
10: );
11:
12: expect(workflow.indexOf("Get publish code")).toBeLessThan(
13: workflow.indexOf("Get auth token")
14: );
15: });
16: });
(End of file - total 16 lines)
</content>
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/current-accepted-event.js</path>
<type>file</type>
<content>
1: import { describe, expect, test, vi } from "vitest";
2:
3: const { getCurrentAcceptedEvent } = require("../current-accepted-event.js");
4:
5: describe("getCurrentAcceptedEvent", () => {
6: test("returns the latest accepted-label event", async () => {
7: await expect(
8: getCurrentAcceptedEvent({
9: getIssueEvents: vi.fn().mockResolvedValue([
10: {
11: actor: { login: "contractor" },
12: event: "labeled",
13: id: "100",
14: label: { name: "accepted" },
15: },
16: {
17: actor: { login: "contractor" },
18: event: "labeled",
19: id: "200",
20: label: { name: "accepted" },
21: },
22: ]),
23: issueNumber: "123",
24: repository: "getsentry/publish",
25: })
26: ).resolves.toEqual({ ...
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/record-ci-ready-attestation.js</path>
<type>file</type>
<content>
1: import { describe, expect, test, vi } from "vitest";
2:
3: const {
4: parseCiReadyAttestation,
5: } = require("../../modules/approval-attestation.js");
6: const {
7: recordCiReadyAttestation,
8: } = require("../record-ci-ready-attestation.js");
9:
10: describe("recordCiReadyAttestation", () => {
11: test("binds the current approval to the app that will add ci-ready", async () => {
12: const title = "publish: getsentry/sentry-javascript@10.0.0";
13:
14: await expect(
15: recordCiReadyAttestation({
16: getAuthenticatedLogin: vi
17: .fn()
18: .mockResolvedValue("sentry-internal-app[bot]"),
19: getIssue: vi.fn().mockResolvedValue({
20: body: "Merge target: main",
21: labels: [{ name: "accepted" }],
22: title,
23: }),
24: getIssueEvents: ...
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/validate-approval-attestation.js</path>
<type>file</type>
<content>
1: import { afterEach, describe, expect, test, vi } from "vitest";
2:
3: const {
4: validateApprovalAttestation,
5: } = require("../validate-approval-attestation.js");
6: const {
7: createApprovalAttestation,
8: createCiReadyAttestation,
9: } = require("../../modules/approval-attestation.js");
10:
11: afterEach(() => {
12: vi.restoreAllMocks();
13: });
14:
15: function jsonResponse(json) {
16: return { ok: true, json: vi.fn().mockResolvedValue(json) };
17: }
18:
19: function issue(title, { body = "", labels = [{ name: "accepted" }] } = {}) {
20: return { body, labels, title };
21: }
22:
23: describe("validateApprovalAttestation", () => {
24: test("accepts the current accepted event and its trusted attestation", async () => {
25: const title = "publish: getsentry/sentry-javascript@10.0.0";
26: const publishIssue = issue(title);
27: ...
yarn run v1.22.22 $ vitest run --printConsoleTrace [1m[46m RUN [49m[22m [36mv4.0.17 [39m[90m/home/byk/Code/getsentry/publish[39m [32m✓[39m src/publish/__tests__/current-accepted-event.js [2m([22m[2m2 tests[22m[2m)[22m[32m 41[2mms[22m[39m [32m✓[39m src/publish/__tests__/validate-approval-attestation.js [2m([22m[2m8 tests[22m[2m)[22m[32m 31[2mms[22m[39m [32m✓[39m src/modules/__tests__/approval-attestation.js [2m([22m[2m5 tests[22m[2m)[22m[32m 41[2mms[22m[39m [32m✓[39m src/modules/__tests__/approval-authorizer.js [2m([22m[2m14 tests[22m[2m)[22m[32m 33[2mms[22m[39m [32m✓[39m src/modules/__tests__/update-issue.js [2m([22m[2m6 tests[22m[2m)[22m[32m 19[2mms[22m[39m [32m✓[39m src/modules/__tests__/process-end-state.js [2m([22m[2m4 tests[22m[2m)[22m[32m 98[2mms[22m[39m [32m✓[39m src/publish/__tests__/authorize-approval.js [2m([22m[2m4 tests[22m[2m)[22m[32m 39[2mms[22m[39m [32m✓[39m ...
<path>/home/byk/Code/getsentry/publish/src/publish/current-accepted-event.js</path>
<type>file</type>
<content>
1: const { currentAcceptedEvent } = require("../modules/approval-attestation.js");
2: const { getAllPages } = require("./validate-approval-attestation.js");
3:
4: async function getCurrentAcceptedEvent({
5: getIssueEvents,
6: issueNumber,
7: repository,
8: }) {
9: const event = currentAcceptedEvent(
10: await getIssueEvents({ repository, issueNumber })
11: );
12:
13: if (!event) {
14: throw new Error("The issue has no current accepted label event");
15: }
16:
17: return event;
18: }
19:
20: async function main() {
21: for (const name of [
22: "APPROVAL_TOKEN",
23: "APPROVAL_ISSUE_NUMBER",
24: "APPROVAL_ISSUE_REPOSITORY",
25: ]) {
26: if (!process.env[name]) {
27: throw new Error(`No "${name}" environment variable found`);
28: }
29: }
30:
31: const event = await getCurrentAcceptedEvent({
32: getIssueEvents: ({ ...
StatusCode: non 2xx status code (404 GET https://docs.github.com/en/rest/repos/collaborators#get-repository-permissions-for-a-user)
<path>/home/byk/Code/getsentry/publish/src/publish/inputs.js</path>
<type>file</type>
<content>
1: const github = require("@actions/github");
2: const core = require("@actions/core");
3: const { detailsFromContext } = require("../modules/details-from-context");
4:
5: async function inputs() {
6: const result = await detailsFromContext({
7: context: github.context,
8: });
9: core.setOutput("result", result);
10: }
11:
12: inputs();
(End of file - total 12 lines)
</content>
MUST-FIX — Auto-approval provenance is not authenticated. auto-approve.yml:21-34 adds accepted using the Sentry Internal App token, so GitHub records that app as the label actor. publish.yml:63 passes that actor onward, but approval-authorizer.js:20-34 only special-cases getsantry[bot]; it otherwise authorizes the generic app by repository role. Auto-approvals will either fail or trust any accepted label written by that app. Require request-bound auto-approval proof.
MUST-FIX — Approval can be revoked after the sole publish-time validation. publish.yml:196-219 validates once, then mints the release token and performs checkout before Craft runs at publish.yml:265-327. validate-approval-attestation.js:71-99 only proves labels and attestations at read time; it also does not require the live issue to remain open. Removing accepted/ci-ready or closing the issue during this window does not stop publication. Revalidate the live, canonical request immediately before Craft in a fenced transition.
MUST-FIX — publish.yml:327 executes mutable getsentry/craft:latest while publish.yml:338-381 supplies publishing credentials and secrets. Pin Craft to an immutable digest.
PASS — The requester/approver guard reads GitHub’s issue-author shape (issue.user.login) and rejects case-insensitive self-approval while binding the attestation to the accepted-label event actor: authorize-approval.js:121-139. Permission response handling correctly consumes role_name at approval-authorizer.js:28-34; event IDs accept GitHub’s numeric form at approval-attestation.js:121-142.
PASS — The manual-dispatch checkout is trusted and precedes app-token creation: ci-poller.yml:29-44. CI-ready handoff binds the accepted event, uses literal output handling rather than sourcing, and validates the matching label actor before publishing: ci-poller.yml:102-126, 275-335; validate-approval-attestation.js:89-99.
yarn test --printConsoleTrace: 55 passed.
DO-NOT-MERGE
Date: Sep 8, 2026 * 🟡 (10:33) User provided `src/publish/current-accepted-event.js` (48 lines). It imports `currentAcceptedEvent` from `../modules/approval-attestation.js` and `getAllPages` from `./validate-approval-attestation.js`; `getCurrentAcceptedEvent({ getIssueEvents, issueNumber, repository })` fetches issue events, returns `currentAcceptedEvent(...)`, and throws `Error("The issue has no…
Date: Sep 8, 2026 * 🟡 (10:31) `yarn run v1.22.22` executed `vitest run --printConsoleTrace` in `/home/byk/Code/getsentry/publish`; all tests passed: 12 test files and 55 tests. * 🟡 (10:31) Passing test files/results: `src/publish/__tests__/current-accepted-event.js` (2 tests, 41ms); `src/publish/__tests__/validate-approval-attestation.js` (8 tests, 31ms); `src/modules/__tests__/approval-attesta…
Date: Sep 8, 2026 * 🟡 (10:28) `src/publish/__tests__/validate-approval-attestation.js` contains `validateApprovalAttestation` tests using `createApprovalAttestation`, mocked `global.fetch`, and expected attestation author `"github-actions[bot]"`. * 🟡 (10:28) `src/publish/__tests__/validate-approval-attestation.js:63+` tests rejection when an approval attestation’s issue title changes after atte…
Date: Sep 8, 2026 * 🔴 (10:27) User reiterated release-workflow security requirements embedded in the `ci-poller.yml` changes: “Always run trusted code.” `workflow_dispatch` can target any ref, therefore the poller must check out `${{ github.event.repository.default_branch }}` with `persist-credentials: false`. * 🔴 (10:27) User reiterated the release-authorization invariant: “Never move a releas…
Date: Sep 8, 2026 * 🔴 [requested-review] (10:25) User requested a final independent, read-only correctness and security review of the exact current working tree at `/home/byk/Code/getsentry/publish`; instructed not to edit files, to inspect `git diff` and relevant tests, report only substantive findings with current file:line evidence classified `PASS`, `CONCERN`, or `MUST-FIX`, and end exactly …
Date: Sep 8, 2026 * 🔴 (10:27) User asserted: “Always allow workflow_dispatch for manual recovery.” `ci-poller.yml` gates `check-ci` with `if: vars.CI_POLLER_HAS_PENDING == 'true' || github.event_name == 'workflow_dispatch'`. * 🔴 (10:27) User asserted: “Always run trusted code.” For `workflow_dispatch`, `.github/workflows/ci-poller.yml` checks out `${{ github.event.repository.default_branch }}` …