DashboardpublishSession 0wLrrhcYWeOP

Session 0wLrrhcYWeOP

Full ID: 0wLrrhcYWeOPUZqcb
Messages: 36
Distillations: 8
Time range: 2026-09-08 10:09:29 — 2026-09-08 10:22:10

Conversation (36 messages)

Perform a fresh independent, read-only correctness and security review of the exact current working tree in /home/byk/Code/getsentry/publish. Prior review found that workflow_dispatch checked out untrusted refs before app tokens. Verify the remediation and review all current changes related to approval attestations, ci-poller trusted checkout, and failure cleanup. Do not edit files. Inspect git diff and relevant code/tests. Report evidence with current file:line refs, classify every point PASS, CONCERN, or MUST-FIX. End exactly MERGE or DO-NOT-MERGE. If blocked, begin BLOCKED and name tool/error; never return an empty review.

gateway · 2026-09-08 10:09:29
result
File not found: /home/byk/Code/getsentry/publish/.jj
gateway · 2026-09-08 10:09:40
result
 M .github/workflows/ci-poller.yml
 M .github/workflows/publish.yml
 M AGENTS.md
 M src/libs/__tests__/github.js
 M src/libs/github.js
 M src/modules/__tests__/details-from-context.js
 M src/modules/__tests__/update-issue.js
 M src/modules/details-from-context.js
 M src/modules/post-workflow-details.js
 M src/modules/process-end-state.js
 M src/modules/update-issue.js
 M src/publish/inputs.js
 M src/publish/post-result.js
 M src/publish/post-workflow-details.js
 M src/publish/update-issue.js
?? .lore.md
?? src/modules/__tests__/approval-attestation.js
?? src/modules/__tests__/approval-authorizer.js
?? src/modules/approval-attestation.js
?? src/modules/approval-authorizer.js
?? src/publish/__tests__/
?? src/publish/authorize-approval.js
?? src/publish/current-accepted-event.js
?? src/publish/record-ci-ready-attestation.js
?? src/publish/validate-approval-attestation.js
gateway · 2026-09-08 10:09:44
result
 .github/workflows/ci-poller.yml               | 142 ++++++++++++++++++++++++--
 .github/workflows/publish.yml                 |  97 ++++++++++++++++++
 AGENTS.md                                     |   6 ++
 src/libs/__tests__/github.js                  |   2 +-
 src/libs/github.js                            |   6 +-
 src/modules/__tests__/details-from-context.js |  22 +++-
 src/modules/__tests__/update-issue.js         |  28 +++++
 src/modules/details-from-context.js           |  17 ++-
 src/modules/post-workflow-details.js          |   4 +-
 src/modules/process-end-state.js              |   4 +-
 src/modules/update-issue.js                   |  42 ++++----
 src/publish/inputs.js                         |  17 ++-
 src/publish/post-result.js                    |   8 +-
 src/publish/post-workflow-details.js          |   8 +-
 src/publish/update-issue.js                   |  33 ++++--
 15 files changed, 375 insertions(+), 61 ...
gateway · 2026-09-08 10:09:50
result
diff --git a/.github/workflows/ci-poller.yml b/.github/workflows/ci-poller.yml
index a3db430..3eb2cd9 100644
--- a/.github/workflows/ci-poller.yml
+++ b/.github/workflows/ci-poller.yml
@@ -12,7 +12,7 @@ on:
 
 permissions:
   contents: read
-  issues: read
+  issues: write
 
 jobs:
   check-ci:
@@ -26,6 +26,13 @@ jobs:
       group: ci-status-poller
       cancel-in-progress: false
     steps:
+      - name: Get publish code
+        uses: actions/checkout@v6
+        with:
+          # workflow_dispatch can target any ref. Always run trusted code.
+          ref: ${{ github.event.repository.default_branch }}
+          persist-credentials: false
+
       # sentry-internal-app token for label changes on this repo.
       # This token is what triggers publish.yml downstream — see
       # https://github.com/getsentry/publish for why GITHUB_TOKEN can't.
@@ -92,12 +99,49 @@ jobs:
             title=$(echo "$issue" | jq -r '.title')
             body=$(echo "$issue" | jq -r '.body')
 
-   ...
gateway · 2026-09-08 10:10:01
result
83d210b build(deps): bump js-yaml from 4.3.0 to 4.3.1 (#9174)
5268a23 feat: Add Vercel creds
92eba3f feat: Add CLOUDFLARE_API_TOKEN (#9122)
ada6147 build(deps): bump js-yaml from 4.1.1 to 4.3.0 (#8731)
a4f961a fix: Add GITHUB_API_TOKEN for commit-on-git target (#9069)
bf10f82 build(deps): bump postcss from 8.5.15 to 8.5.23 (#9017)
837edc0 docs: fix possessive apostrophe placement (#9015)
4da4a25 chore: replace deprecated trimRight() with trimEnd() (#9012)
22fd64d docs: fix typo 'acces' -> 'access' (#9011)
24b9ce3 docs: fix missing article in rfc.md (#9014)
gateway · 2026-09-08 10:10:05
result
<path>/home/byk/Code/getsentry/publish/.github/workflows/ci-poller.yml</path>
<type>file</type>
<content>
1: name: CI Status Poller
2: 
3: on:
4:   schedule:
5:     - cron: "*/5 * * * *"
6:   workflow_dispatch:
7:     inputs:
8:       attempt:
9:         description: Self-dispatch attempt counter (internal use)
10:         required: false
11:         default: "0"
12: 
13: permissions:
14:   contents: read
15:   issues: write
16: 
17: jobs:
18:   check-ci:
19:     runs-on: ubuntu-latest
20:     environment: production
21:     # Skip entirely (no runner provisioned) when there's nothing to check.
22:     # Set to "true" by ci-pending.yml, reset to "false" here when done.
23:     # Always allow workflow_dispatch for manual recovery.
24:     if: vars.CI_POLLER_HAS_PENDING == 'true' || github.event_name == 'workflow_dispatch'
25:     concurrency:
26:       group: ci-status-poller
27:       cancel-in-progress: false
28:     steps:
29:       - name: Get publish code
30:         uses: ...
gateway · 2026-09-08 10:10:10
result
<path>/home/byk/Code/getsentry/publish/.github/workflows/ci-poller.yml</path>
<type>file</type>
<content>
426:       - name: Self-dispatch if issues remain pending
427:         if: >-
428:           always()
429:           && steps.token.outcome == 'success'
430:           && steps.remaining.outcome == 'success'
431:           && steps.remaining.outputs.count != '0'
432:         env:
433:           GH_TOKEN: ${{ steps.token.outputs.token }}
434:           ATTEMPT: ${{ github.event.inputs.attempt || '0' }}
435:         run: |
436:           attempt=$((ATTEMPT + 1))
437:           if [[ "$attempt" -ge 60 ]]; then
438:             echo "::warning::Max self-dispatch attempts (60) reached. Relying on cron fallback."
439:             exit 0
440:           fi
441:           echo "Re-dispatching (attempt ${attempt}/60)..."
442:           gh workflow run ci-poller.yml -R "$GITHUB_REPOSITORY" -f attempt="${attempt}"

(End of file - total 442 lines)
</content>
gateway · 2026-09-08 10:10:14
result
<path>/home/byk/Code/getsentry/publish/.github/workflows/publish.yml</path>
<type>file</type>
<content>
1: name: Publish
2: on:
3:   issues:
4:     types: [labeled]
5: 
6: concurrency:
7:   # Use the issue title (e.g. "publish: getsentry/foo@1.2.3") so duplicate
8:   # issues for the same repo@version share a concurrency group.
9:   group: ${{ github.event.issue.title }}
10:   cancel-in-progress: false
11: 
12: permissions:
13:   contents: read
14:   issues: write
15:   packages: write
16: 
17: jobs:
18:   # When accepted is added to a publish issue:
19:   #   - Add ci-pending (and remove ci-failed if retrying)
20:   #   - Enable the poller via CI_POLLER_HAS_PENDING=true
21:   #   - Comment on the issue
22:   #   - Trigger the poller immediately so we don't wait for the next cron tick
23:   # The publish job below requires ci-ready, so it will not fire until the
24:   # poller flips ci-pending → ci-ready (which also prevents publishing without
25:   # CI verification in the ...
gateway · 2026-09-08 10:10:19
result
<path>/home/byk/Code/getsentry/publish/src/modules/approval-attestation.js</path>
<type>file</type>
<content>
1: const crypto = require("crypto");
2: 
3: const APPROVAL_ATTESTATION_PREFIX = "<!-- publish-approval ";
4: const CI_READY_ATTESTATION_PREFIX = "<!-- publish-ci-ready ";
5: const ATTESTATION_SUFFIX = " -->";
6: 
7: function createAttestation(prefix, value) {
8:   return `${prefix}${Buffer.from(JSON.stringify(value)).toString(
9:     "base64url"
10:   )}${ATTESTATION_SUFFIX}`;
11: }
12: 
13: function requestDigest({ body, labels, title }) {
14:   if (typeof body !== "string" || !Array.isArray(labels)) {
15:     throw new Error("Invalid publish request");
16:   }
17: 
18:   return crypto
19:     .createHash("sha256")
20:     .update(
21:       JSON.stringify({
22:         body,
23:         dryRun: labels.some((label) => label.name === "dry-run"),
24:         title,
25:       })
26:     )
27:     .digest("hex");
28: }
29: 
30: function createApprovalAttestation({ actor, eventId, ...
gateway · 2026-09-08 10:10:23
result
<path>/home/byk/Code/getsentry/publish/src/modules/approval-authorizer.js</path>
<type>file</type>
<content>
1: const ALLOWED_ROLE_NAMES = new Set(["write", "maintain", "admin"]);
2: const AUTO_APPROVER = "getsantry[bot]";
3: const { parsePublishTitle } = require("./details-from-context.js");
4: 
5: async function authorizeApproval({
6:   actor,
7:   issueTitle,
8:   getPermission,
9:   autoApprovedRepositories = new Set(),
10: }) {
11:   const title = parsePublishTitle(issueTitle);
12: 
13:   if (!title) {
14:     return { authorized: false, repository: null };
15:   }
16: 
17:   const repository = `getsentry/${title.repo}`;
18:   const releasePath = `${repository}${title.path || ""}`;
19: 
20:   if (actor === AUTO_APPROVER && autoApprovedRepositories.has(releasePath)) {
21:     return { authorized: true, repository };
22:   }
23: 
24:   if (actor === AUTO_APPROVER) {
25:     return { authorized: false, repository };
26:   }
27: 
28:   const { role_name } = await getPermission({
29:  ...
gateway · 2026-09-08 10:10:27
result
<path>/home/byk/Code/getsentry/publish/src/publish/authorize-approval.js</path>
<type>file</type>
<content>
1: const fs = require("fs");
2: const {
3:   createApprovalAttestation,
4:   currentAcceptedEvent,
5: } = require("../modules/approval-attestation.js");
6: const { authorizeApproval } = require("../modules/approval-authorizer.js");
7: 
8: function getAutoApprovedRepositories() {
9:   return new Set(
10:     fs
11:       .readFileSync("auto-approve-repos.txt", "utf8")
12:       .split(/\r?\n/)
13:       .filter(Boolean)
14:   );
15: }
16: 
17: async function getPermission({ owner, repository, username }) {
18:   const response = await getGitHubResponse(
19:     `repos/${encodeURIComponent(owner)}/${encodeURIComponent(
20:       repository
21:     )}/collaborators/${encodeURIComponent(username)}/permission`
22:   );
23: 
24:   if (!response.ok) {
25:     throw new Error(
26:       `Could not retrieve ${username}'s permission for ${owner}/${repository}: GitHub returned ...
gateway · 2026-09-08 10:10:31
result
<path>/home/byk/Code/getsentry/publish/src/publish/current-accepted-event.js</path>
<type>file</type>
<content>
1: const { currentAcceptedEvent } = require("../modules/approval-attestation.js");
2: const { getAllPages } = require("./validate-approval-attestation.js");
3: 
4: async function getCurrentAcceptedEvent({
5:   getIssueEvents,
6:   issueNumber,
7:   repository,
8: }) {
9:   const event = currentAcceptedEvent(
10:     await getIssueEvents({ repository, issueNumber })
11:   );
12: 
13:   if (!event) {
14:     throw new Error("The issue has no current accepted label event");
15:   }
16: 
17:   return event;
18: }
19: 
20: async function main() {
21:   for (const name of [
22:     "APPROVAL_TOKEN",
23:     "APPROVAL_ISSUE_NUMBER",
24:     "APPROVAL_ISSUE_REPOSITORY",
25:   ]) {
26:     if (!process.env[name]) {
27:       throw new Error(`No "${name}" environment variable found`);
28:     }
29:   }
30: 
31:   const event = await getCurrentAcceptedEvent({
32:     getIssueEvents: ({ ...
gateway · 2026-09-08 10:10:36
result
<path>/home/byk/Code/getsentry/publish/src/publish/record-ci-ready-attestation.js</path>
<type>file</type>
<content>
1: const fs = require("fs");
2: const {
3:   createCiReadyAttestation,
4:   currentAcceptedEvent,
5: } = require("../modules/approval-attestation.js");
6: const {
7:   getAllPages,
8:   getGitHubResponse,
9:   getIssue,
10: } = require("./validate-approval-attestation.js");
11: 
12: async function getAuthenticatedLogin() {
13:   const response = await getGitHubResponse("user");
14: 
15:   if (!response.ok) {
16:     throw new Error(
17:       `Could not retrieve the authenticated user: GitHub returned ${response.status}`
18:     );
19:   }
20: 
21:   const { login } = await response.json();
22: 
23:   if (typeof login !== "string") {
24:     throw new Error("GitHub returned no authenticated user login");
25:   }
26: 
27:   return login;
28: }
29: 
30: async function recordCiReadyAttestation({
31:   expectedAcceptedEvent,
32:   getAuthenticatedLogin,
33:   getIssue,
34:  ...
gateway · 2026-09-08 10:10:41
result
<path>/home/byk/Code/getsentry/publish/src/publish/validate-approval-attestation.js</path>
<type>file</type>
<content>
1: const {
2:   currentAcceptedEvent,
3:   currentCiReadyEvent,
4:   hasApprovalAttestation,
5:   hasCiReadyAttestation,
6: } = require("../modules/approval-attestation.js");
7: 
8: async function getGitHubResponse(path) {
9:   return fetch(`https://api.github.com/${path}`, {
10:     headers: {
11:       Accept: "application/vnd.github+json",
12:       Authorization: `Bearer ${process.env.APPROVAL_TOKEN}`,
13:       "X-GitHub-Api-Version": "2026-03-10",
14:     },
15:   });
16: }
17: 
18: async function getIssue({ repository, issueNumber }) {
19:   const response = await getGitHubResponse(
20:     `repos/${repository}/issues/${issueNumber}`
21:   );
22: 
23:   if (!response.ok) {
24:     throw new Error(
25:       `Could not retrieve issue #${issueNumber}: GitHub returned ${response.status}`
26:     );
27:   }
28: 
29:   return response.json();
30: }
31: 
32: async ...
gateway · 2026-09-08 10:10:48
result
<path>/home/byk/Code/getsentry/publish/src/modules/__tests__/approval-attestation.js</path>
<type>file</type>
<content>
1: import { describe, expect, test } from "vitest";
2: 
3: const {
4:   createApprovalAttestation,
5:   createCiReadyAttestation,
6:   currentAcceptedEvent,
7:   hasApprovalAttestation,
8:   hasCiReadyAttestation,
9:   parseApprovalAttestation,
10:   requestDigest,
11: } = require("../approval-attestation.js");
12: 
13: function issue(title, { body = "", dryRun = false } = {}) {
14:   return {
15:     body,
16:     labels: dryRun ? [{ name: "dry-run" }] : [],
17:     title,
18:   };
19: }
20: 
21: describe("approval attestations", () => {
22:   test("matches the latest accepted event to a trusted attestation", () => {
23:     const title = "publish: getsentry/relay/py@1.2.3";
24:     const publishIssue = issue(title);
25:     const attestation = createApprovalAttestation({
26:       actor: "contractor",
27:       eventId: "200",
28:       issue: publishIssue,
29:     ...
gateway · 2026-09-08 10:10:56
result
<path>/home/byk/Code/getsentry/publish/src/modules/__tests__/approval-authorizer.js</path>
<type>file</type>
<content>
1: import { describe, expect, test, vi } from "vitest";
2: 
3: const { authorizeApproval } = require("../approval-authorizer.js");
4: 
5: const issueTitle = "publish: getsentry/sentry-javascript@10.0.0";
6: 
7: describe("authorizeApproval", () => {
8:   test("allows the auto-approval bot for an allowlisted release without a target repository lookup", async () => {
9:     const getPermission = vi.fn();
10: 
11:     await expect(
12:       authorizeApproval({
13:         actor: "getsantry[bot]",
14:         issueTitle,
15:         getPermission,
16:         autoApprovedRepositories: new Set(["getsentry/sentry-javascript"]),
17:       })
18:     ).resolves.toEqual({
19:       authorized: true,
20:       repository: "getsentry/sentry-javascript",
21:     });
22: 
23:     expect(getPermission).not.toHaveBeenCalled();
24:   });
25: 
26:   test("rejects the auto-approval bot ...
gateway · 2026-09-08 10:11:01
result
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__</path>
<type>directory</type>
<entries>
authorize-approval.js
ci-poller-workflow.js
current-accepted-event.js
record-ci-ready-attestation.js
validate-approval-attestation.js

(5 entries)
</entries>
gateway · 2026-09-08 10:11:06
result
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/authorize-approval.js</path>
<type>file</type>
<content>
1: import { afterEach, describe, expect, test, vi } from "vitest";
2: import fs from "fs";
3: const {
4:   getAutoApprovedRepositories,
5:   main,
6: } = require("../authorize-approval.js");
7: 
8: const originalEnvironment = { ...process.env };
9: 
10: afterEach(() => {
11:   process.env = { ...originalEnvironment };
12:   vi.restoreAllMocks();
13:   vi.resetModules();
14: });
15: 
16: function jsonResponse(json) {
17:   return { ok: true, json: vi.fn().mockResolvedValue(json) };
18: }
19: 
20: async function runAuthorization({ actor, issueTitle, responses }) {
21:   process.env.GITHUB_OUTPUT = "/tmp/github-output";
22:   process.env.APPROVAL_TOKEN = "release-bot-token";
23:   process.env.APPROVAL_ACTOR = actor;
24:   process.env.APPROVAL_ISSUE_NUMBER = "123";
25:   process.env.APPROVAL_ISSUE_REPOSITORY = "getsentry/publish";
26:   process.env.APPROVAL_ISSUE_TITLE = ...
gateway · 2026-09-08 10:11:12
result
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/ci-poller-workflow.js</path>
<type>file</type>
<content>
1: import { readFileSync } from "fs";
2: import { describe, expect, test } from "vitest";
3: 
4: const workflow = readFileSync(".github/workflows/ci-poller.yml", "utf8");
5: 
6: describe("CI poller workflow", () => {
7:   test("checks out trusted code before requesting app tokens", () => {
8:     expect(workflow).toMatch(
9:       /- name: Get publish code\n\s+uses: actions\/checkout@v6\n\s+with:\n(?:\s+#.*\n)*\s+ref: \$\{\{ github\.event\.repository\.default_branch \}\}/
10:     );
11: 
12:     expect(workflow.indexOf("Get publish code")).toBeLessThan(
13:       workflow.indexOf("Get auth token")
14:     );
15:   });
16: });

(End of file - total 16 lines)
</content>
gateway · 2026-09-08 10:11:16
result
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/current-accepted-event.js</path>
<type>file</type>
<content>
1: import { describe, expect, test, vi } from "vitest";
2: 
3: const { getCurrentAcceptedEvent } = require("../current-accepted-event.js");
4: 
5: describe("getCurrentAcceptedEvent", () => {
6:   test("returns the latest accepted-label event", async () => {
7:     await expect(
8:       getCurrentAcceptedEvent({
9:         getIssueEvents: vi.fn().mockResolvedValue([
10:           {
11:             actor: { login: "contractor" },
12:             event: "labeled",
13:             id: "100",
14:             label: { name: "accepted" },
15:           },
16:           {
17:             actor: { login: "contractor" },
18:             event: "labeled",
19:             id: "200",
20:             label: { name: "accepted" },
21:           },
22:         ]),
23:         issueNumber: "123",
24:         repository: "getsentry/publish",
25:       })
26:     ).resolves.toEqual({ ...
gateway · 2026-09-08 10:11:21
result
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/record-ci-ready-attestation.js</path>
<type>file</type>
<content>
1: import { describe, expect, test, vi } from "vitest";
2: 
3: const {
4:   parseCiReadyAttestation,
5: } = require("../../modules/approval-attestation.js");
6: const {
7:   recordCiReadyAttestation,
8: } = require("../record-ci-ready-attestation.js");
9: 
10: describe("recordCiReadyAttestation", () => {
11:   test("binds the current approval to the app that will add ci-ready", async () => {
12:     const title = "publish: getsentry/sentry-javascript@10.0.0";
13: 
14:     await expect(
15:       recordCiReadyAttestation({
16:         getAuthenticatedLogin: vi
17:           .fn()
18:           .mockResolvedValue("sentry-internal-app[bot]"),
19:         getIssue: vi.fn().mockResolvedValue({
20:           body: "Merge target: main",
21:           labels: [{ name: "accepted" }],
22:           title,
23:         }),
24:         getIssueEvents: ...
gateway · 2026-09-08 10:11:25
result
<path>/home/byk/Code/getsentry/publish/src/publish/__tests__/validate-approval-attestation.js</path>
<type>file</type>
<content>
1: import { afterEach, describe, expect, test, vi } from "vitest";
2: 
3: const {
4:   validateApprovalAttestation,
5: } = require("../validate-approval-attestation.js");
6: const {
7:   createApprovalAttestation,
8:   createCiReadyAttestation,
9: } = require("../../modules/approval-attestation.js");
10: 
11: afterEach(() => {
12:   vi.restoreAllMocks();
13: });
14: 
15: function jsonResponse(json) {
16:   return { ok: true, json: vi.fn().mockResolvedValue(json) };
17: }
18: 
19: function issue(title, { body = "", labels = [{ name: "accepted" }] } = {}) {
20:   return { body, labels, title };
21: }
22: 
23: describe("validateApprovalAttestation", () => {
24:   test("accepts the current accepted event and its trusted attestation", async () => {
25:     const title = "publish: getsentry/sentry-javascript@10.0.0";
26:     const publishIssue = issue(title);
27:  ...
gateway · 2026-09-08 10:11:30
result
<path>/home/byk/Code/getsentry/publish/src/modules/__tests__/details-from-context.js</path>
<type>file</type>
<content>
1: import { test, expect } from "vitest";
2: 
3: const {
4:   detailsFromContext,
5:   parsePublishTitle,
6: } = require("../details-from-context.js");
7: 
8: const inputsArgs = {
9:   context: {
10:     repo: { owner: "getsentry", repo: "publish" },
11:     payload: {
12:       issue: {
13:         number: "223",
14:         title: "publish: getsentry/sentry@21.3.1",
15:         body: `
16: Requested by: @BYK
17: 
18: Merge target: custom-branch
19: 
20: Quick links:
21: - [View changes](https://github.com/getsentry/sentry/compare/21.3.0...refs/heads/releases/21.3.1)
22: - [View check runs](https://github.com/getsentry/sentry/commit/7e5ca7ed5581552de066e2a8bc295b8306be38ac/checks/)
23: 
24: Assign the **accepted** label to this issue to approve the release. ...
gateway · 2026-09-08 10:11:43
result
<path>/home/byk/Code/getsentry/publish/src/modules/__tests__/update-issue.js</path>
<type>file</type>
<content>
1: import { vi, describe, test, expect, beforeAll, beforeEach, it } from "vitest";
2: import fs from "fs";
3: 
4: const { updateIssue, transformIssueBody } = require("../update-issue.js");
5: 
6: let mockExistsSync;
7: 
8: const updateTargetsArgs = {
9:   inputs: { repo: "sentry", version: "21.3.1" },
10:   context: {
11:     runId: "1234",
12:     repo: { owner: "getsentry", repo: "publish" },
13:     payload: { issue: { number: "211" } },
14:   },
15:   octokit: {
16:     rest: {
17:       actions: {
18:         getWorkflowRun: async () => ({
19:           data: {
20:             html_url: "https://github.com/getsentry/sentry/actions/runs/1234",
21:           },
22:         }),
23:       },
24:       issues: {
25:         get: vi.fn(),
26:         update: vi.fn(),
27:         removeLabel: vi.fn(),
28:       },
29:     },
30:   },
31:   Sentry: {
32:     Scope: class Scope ...
gateway · 2026-09-08 10:12:21
result
Found 60 matches
/home/byk/Code/getsentry/publish/.github/workflows/publish.yml:
  Line 18:   # When accepted is added to a publish issue:

  Line 31:       github.event.label.name == 'accepted'

  Line 63:           APPROVAL_ACTOR: ${{ github.actor }}

  Line 107:             --remove-label "accepted"

  Line 110:             --body "Approval is invalid or could not be verified. Re-add the accepted label to retry after resolving the issue."

  Line 174:     # Fires ONLY on ci-ready label events — not accepted — to avoid racing

  Line 182:       && contains(github.event.issue.labels.*.name, 'accepted')

  Line 215:             --remove-label "accepted"

  Line 218:             --body "Approval is invalid or could not be verified. Re-add the accepted label to retry after resolving the issue."


/home/byk/Code/getsentry/publish/.github/workflows/ci-poller.yml:
  Line 80:           # Only check issues that have BOTH ci-pending AND accepted labels. ...
gateway · 2026-09-08 10:12:25
result
<path>/home/byk/Code/getsentry/publish/.github/workflows/auto-approve.yml</path>
<type>file</type>
<content>
1: name: auto-approve non-sdks
2: on:
3:   issues:
4:     types: [opened]
5: 
6: permissions:
7:   contents: read
8: 
9: jobs:
10:   auto-approve:
11:     runs-on: ubuntu-latest
12:     if: |
13:       (github.actor == 'sentry-release-bot[bot]' || github.actor == 'getsantry[bot]') &&
14:       startsWith(github.event.issue.title, 'publish: ')
15:     steps:
16:       - uses: actions/checkout@v4
17:         with:
18:           sparse-checkout: auto-approve-repos.txt
19:           sparse-checkout-cone-mode: false
20:       - name: Get auth token
21:         id: token
22:         uses: actions/create-github-app-token@v3
23:         with:
24:           client-id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
25:           private-key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
26:       - name: Auto-approve if repo is in the list
27:         env:
28:           GH_TOKEN: ${{ ...
gateway · 2026-09-08 10:13:30
result
<path>/home/byk/Code/getsentry/publish/package.json</path>
<type>file</type>
<content>
1: {
2:   "name": "publish",
3:   "private": true,
4:   "version": "0.0.1",
5:   "description": "Approval-based publishing system for Sentry",
6:   "main": "index.js",
7:   "repository": "git@github.com:getsentry/publish.git",
8:   "author": "Sentry Open Source <oss@sentry.io>",
9:   "license": "Apache-2.0",
10:   "volta": {
11:     "node": "24.0.0",
12:     "yarn": "1.22.22"
13:   },
14:   "resolutions": {
15:     "undici": "^6.23.0"
16:   },
17:   "scripts": {
18:     "test": "vitest run",
19:     "test:watch": "vitest",
20:     "lint": "eslint src .github --ignore-pattern '!.github'",
21:     "prettier": "prettier --write src"
22:   },
23:   "devDependencies": {
24:     "eslint": "^8.9.0",
25:     "eslint-config-prettier": "^8.3.0",
26:     "eslint-plugin-yml": "^0.13.0",
27:     "prettier": "^2.2.1",
28:     "vitest": "^4.1.0"
29:   },
30:   "dependencies": {
31:     "@actions/core": ...
gateway · 2026-09-08 10:13:41
result
yarn run v1.22.22
$ vitest run --printConsoleTrace

 RUN  v4.0.17 /home/byk/Code/getsentry/publish

 ✓ src/publish/__tests__/validate-approval-attestation.js (8 tests) 26ms
 ✓ src/modules/__tests__/approval-attestation.js (5 tests) 23ms
 ✓ src/publish/__tests__/current-accepted-event.js (2 tests) 31ms
 ✓ src/modules/__tests__/approval-authorizer.js (14 tests) 29ms
 ✓ src/modules/__tests__/process-end-state.js (4 tests) 60ms
 ✓ src/publish/__tests__/authorize-approval.js (3 tests) 14ms
 ✓ src/modules/__tests__/post-workflow-details.js (1 test) 27ms
 ✓ ...
gateway · 2026-09-08 10:13:49
result
yarn run v1.22.22
$ eslint src .github --ignore-pattern '!.github'

/home/byk/Code/getsentry/publish/.github/workflows/cocoapods-keepalive.yml
  1:7  error  Must use plain style scalar  yml/plain-scalar

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
gateway · 2026-09-08 10:14:23
result
<path>/home/byk/Code/getsentry/publish/src/modules/process-end-state.js</path>
<type>file</type>
<content>
1: const Sentry = require("@sentry/node");
2: 
3: async function processEndState({ context, octokit, inputs, status }) {
4:   const { repo, version } = inputs;
5:   const { repo: publishRepo, runId: run_id } = context;
6:   const { number: issue_number } = context.payload.issue;
7:   const workflowInfo = (
8:     await octokit.rest.actions.getWorkflowRun({
9:       ...publishRepo,
10:       run_id,
11:     })
12:   ).data;
13: 
14:   const details = {
15:     repo,
16:     version,
17:     publishRepo,
18:     run_id,
19:     issue_number,
20:     workflowInfo,
21:     status,
22:   };
23: 
24:   await postIssueComment({
25:     octokit,
26:     details,
27:   });
28: 
29:   if (status === "success") {
30:     await octokit.rest.issues.update({
31:       ...publishRepo,
32:       issue_number,
33:       state: "closed",
34:     });
35:   }
36: 
37:   await reportSession({ ...
gateway · 2026-09-08 10:16:15
result
<path>/home/byk/Code/getsentry/publish/src/modules/update-issue.js</path>
<type>file</type>
<content>
1: const fs = require("fs");
2: const {
3:   TARGETS_SECTION_PARSER_REGEX,
4:   TARGETS_PARSER_REGEX,
5: } = require("./details-from-context");
6: 
7: async function updateTargets({ octokit, version, publishRepo, issue_number }) {
8:   const CRAFT_STATE_FILE_PATH = `${process.env.GITHUB_WORKSPACE}/__repo__/.craft-publish-${version}.json`;
9: 
10:   if (!fs.existsSync(CRAFT_STATE_FILE_PATH)) {
11:     return;
12:   }
13: 
14:   const issueRequest = octokit.rest.issues.get({
15:     ...publishRepo,
16:     issue_number,
17:   });
18: 
19:   const craftStateRequest = fs.promises
20:     .readFile(CRAFT_STATE_FILE_PATH, { encoding: "utf-8" })
21:     .then((data) => JSON.parse(data));
22: 
23:   const [{ data: issue }, craftState] = await Promise.all([
24:     issueRequest,
25:     craftStateRequest,
26:   ]);
27: 
28:   const newIssueBody = transformIssueBody(craftState, issue.body);
29: ...
gateway · 2026-09-08 10:18:16
result
No files found
gateway · 2026-09-08 10:19:19
result
<path>/home/byk/Code/getsentry/publish/src/modules/details-from-context.js</path>
<type>file</type>
<content>
1: /**
2:  * Matches the entire "Targets" section of a github publish issue body.
3:  */
4: const TARGETS_SECTION_PARSER_REGEX =
5:   /^(?!### Targets$\s)(?: *- \[[ xX]\] \S+\s*$(?:\r?\n)?)+/m;
6: 
7: /**
8:  * Matches all targets of a github publish issue body in a section that was already matched and extracted with `TARGETS_PARSER_REGEX`.
9:  * The "id" of the targets is captured within a capture group.
10:  */
11: const TARGETS_PARSER_REGEX = /^\s*- \[[ x]\] (\S+)/gim;
12: 
13: /**
14:  * Matches checked targets of a github publish issue body in a section that was already matched and extracted with `TARGETS_PARSER_REGEX`.
15:  * The "id" of the targets is captured within a capture group.
16:  */
17: const CHECKED_TARGETS_PARSER_REGEX = /^\s*- \[x\] (\S+)/gim;
18: const PUBLISH_TITLE_REGEX =
19:   /^publish: ...
gateway · 2026-09-08 10:20:43
result
 M .github/workflows/ci-poller.yml
 M .github/workflows/publish.yml
 M AGENTS.md
 M src/libs/__tests__/github.js
 M src/libs/github.js
 M src/modules/__tests__/details-from-context.js
 M src/modules/__tests__/update-issue.js
 M src/modules/details-from-context.js
 M src/modules/post-workflow-details.js
 M src/modules/process-end-state.js
 M src/modules/update-issue.js
 M src/publish/inputs.js
 M src/publish/post-result.js
 M src/publish/post-workflow-details.js
 M src/publish/update-issue.js
?? .lore.md
?? src/modules/__tests__/approval-attestation.js
?? src/modules/__tests__/approval-authorizer.js
?? src/modules/approval-attestation.js
?? src/modules/approval-authorizer.js
?? src/publish/__tests__/
?? src/publish/authorize-approval.js
?? src/publish/current-accepted-event.js
?? src/publish/record-ci-ready-attestation.js
?? src/publish/validate-approval-attestation.js
 .github/workflows/ci-poller.yml               | 142 ++++++++++++++++++++++++--
 .github/workflows/publish.yml         ...
gateway · 2026-09-08 10:22:10

Independent read-only review of the current working tree:

  • PASS Trusted code loads before app tokens in ci-poller.yml:29-56. workflow_dispatch always checks out the repository default branch with credentials disabled before either token step.
  • PASS Approval attestations bind the actor, accepted-label event, title, body, and dry-run state (src/modules/approval-attestation.js:13-46). Validation requires the current accepted event and a comment from github-actions[bot] (src/publish/validate-approval-attestation.js:71-99).
  • PASS The poller binds an accepted event before CI, revalidates after CI, records the app identity for ci-ready, and validates again immediately before promotion (ci-poller.yml:102-134, 253-340). Renamed or re-approved issues cannot progress.
  • PASS Publishing requires a CI-ready attestation tied to both the current approval and the actor that added ci-ready (publish.yml:196-219, validate-approval-attestation.js:89-99).
  • PASS Failure cleanup runs unconditionally and preserves the pending-state variable conservatively (ci-poller.yml:376-417).
  • MUST-FIX A requester can approve their own release. publish.yml:61-67 supplies only the label actor; authorizeApproval() authorizes any human with target-repository write access (src/modules/approval-authorizer.js:28-34). Although it fetches the issue later, it never compares issue.user.login with the approver (src/publish/authorize-approval.js:111-130). This violates requester/approver separation and permits self-approval by a target-repository collaborator. Add a live issue-author comparison and reject equality; cover it with a regression test.
  • CONCERN yarn lint fails on unrelated existing file .github/workflows/cocoapods-keepalive.yml:1 (yml/plain-scalar). yarn test --printConsoleTrace passes: 54 tests.

git diff --check passed.

DO-NOT-MERGE

gpt-5.6-terra · 2026-09-08 10:22:10 · ~452 tokens

Distillations (8)

Gen 0 2026-09-08 10:24:50 · 1403 tokens

Date: Sep 8, 2026 * 🟡 (10:18) `src/modules/update-issue.js` defines `updateTargets({ octokit, version, publishRepo, issue_number })`, which reads `${process.env.GITHUB_WORKSPACE}/__repo__/.craft-publish-${version}.json` only if it exists; concurrently fetches the issue with `octokit.rest.issues.get` and parses the craft state JSON; transforms `issue.body` via `transformIssueBody(craftState, issu…

Gen 0 2026-09-08 10:18:58 · 665 tokens

Date: Sep 8, 2026 * 🟡 (10:16) `src/modules/process-end-state.js` exports `processEndState`, which accepts `{ context, octokit, inputs, status }`, extracts `repo`/`version` from `inputs`, `publishRepo` and `runId` (renamed `run_id`) from `context`, and `issue_number` from `context.payload.issue.number`. * 🟡 (10:16) `processEndState` fetches the GitHub Actions workflow run with `octokit.rest.acti…

Gen 0 2026-09-08 10:18:43 · 974 tokens

Date: Sep 8, 2026 * 🟡 (10:13) `.github/workflows/auto-approve.yml` defines workflow `auto-approve non-sdks`, triggered on newly opened issues (`issues.types: [opened]`), with `contents: read` permission and an `auto-approve` job on `ubuntu-latest`. * 🟡 (10:13) `auto-approve` runs only when `github.actor` is `sentry-release-bot[bot]` or `getsantry[bot]` and `github.event.issue.title` starts with…

Gen 0 2026-09-08 10:18:23 · 1108 tokens

Date: Sep 8, 2026 * 🟡 (10:12) `src/modules/__tests__/update-issue.js` imports `vi`, `describe`, `test`, `expect`, `beforeAll`, `beforeEach`, and `it` from `vitest`; imports `fs`; and requires `{ updateIssue, transformIssueBody }` from `../update-issue.js`. * 🟡 (10:12) `updateTargetsArgs` test fixture supplies `inputs: { repo: "sentry", version: "21.3.1" }`, context `runId: "1234"`, repo `{ owne…

Gen 0 2026-09-08 10:18:01 · 468 tokens

Date: Sep 8, 2026 * 🟡 (10:11) `src/modules/__tests__/details-from-context.js` imports `detailsFromContext` and `parsePublishTitle` from `../details-from-context.js`. * 🟡 (10:11) `detailsFromContext(inputsArgs)` is tested with issue `number: "223"`, title `publish: getsentry/sentry@21.3.1`, `accepted` label, `Merge target: custom-branch`, and checked targets `github`, `npm[@sentry/node]`, and `d…

Gen 0 2026-09-08 10:17:50 · 2228 tokens

Date: Sep 8, 2026 * 🟡 (10:10) `src/modules/approval-attestation.js` defines HTML-comment attestation formats `<!-- publish-approval ${base64url(JSON)} -->` and `<!-- publish-ci-ready ${base64url(JSON)} -->`; `createAttestation()` serializes JSON using `Buffer.from(JSON.stringify(value)).toString("base64url")`. * 🟡 (10:10) `requestDigest({ body, labels, title })` in `src/modules/approval-attesta…

Gen 0 2026-09-08 10:15:19 · 482 tokens

Date: Sep 8, 2026 * 🔴 (10:10) User stated that the CI poller always adds `ci-ready`. * 🟡 (10:10) Current `.github/workflows/publish.yml` excerpt indicates the publish workflow uses issue titles formatted like `publish: getsentry/foo@1.2.3` to distinguish duplicate publish requests. * 🟡 (10:10) Current `.github/workflows/publish.yml:175` comment states the poller always adds `ci-ready`, in the …

Gen 0 2026-09-08 10:12:49 · 2331 tokens

Date: Sep 8, 2026 * 🔴 [requested-security-review] (10:09) User requested a fresh, independent, read-only correctness and security review of the exact current working tree at `/home/byk/Code/getsentry/publish`. Scope: verify remediation for prior finding that `workflow_dispatch` checked out untrusted refs before app tokens; review all current changes concerning approval attestations, `ci-poller` …