Dashboard › opencode › Session 0GlDujc86X2S
0GlDujc86X2SbSJRQPerform a strict READ-ONLY security/pentest review of the frozen candidate in /tmp/opencode/session-recovery-v19-review. Do not edit files, run tests/builds/services, mutate Git/index/refs, or use recall. Read applicable AGENTS.md/package guidance and inspect every changed file plus necessary immutable-base context. Immutable inputs: base commit ab9408c81cc9916177641ae8e9f08624fc27b5b9; frozen patch /tmp/opencode/session-recovery-final-v19.patch SHA-256 a2bce01664538243cb8ba16c6ca8f0364c6f79463ad6677567044a1b3e1e74fe; exact SEA /home/byk/Code/opencode/packages/opencode/dist/server/opencode-server SHA-256 753b05afb86195246b211237ca5b11e26a7c08da863d70a711da2c93ee453c8a; exactly 34 changed paths. Verify hashes and patch applicability/read-only provenance first. Adversarially inspect ID/session scope, corrupt rows, stale owners, takeover, cancellation, replay, duplicate wakes, starvation/DoS, projection/event transactions, provider/tool side effects, authorization, data leakage, dependency direction, migrations, and generated contracts. Focus especially on coordinator-cleanup fallback after Step.Started commit/notification interruption: it runs only after runner and finalizers settle, must own a live exact claim, must not delete a successor, must publish/reconcile one interruption before clear, and must block pending successor until cleanup. Also verify explicit resume of resume:false persists intent before claim acquisition and cannot arm conflicts/recovery-owned inputs. Treat final synchronous check-to-external-call, process-local interruption routing, and bounded wall-clock skew as disclosed residuals, but report missing immediate fencing or broader races. Findings first with MUST-FIX/CONCERN and exact file:line evidence. If no blocker, explicitly say so and residual risks. End with exactly MERGE or DO-NOT-MERGE.
<path>/tmp/opencode/session-recovery-v19-review</path> <type>directory</type> <entries> .dockerignore .editorconfig .git .gitattributes .github/ .gitignore .gitleaksignore .husky/ .lore.md .opencode/ .oxlintrc.json .prettierignore .vscode/ .zed/ AGENTS.md artifacts/ bun.lock bunfig.toml CONTEXT.md CONTRIBUTING.md flake.lock flake.nix github/ infra/ install LICENSE nix/ package.json packages/ patches/ perf/ pnpm-lock.yaml pnpm-workspace.yaml README.ar.md README.bn.md README.br.md README.bs.md README.da.md README.de.md README.es.md README.fr.md README.gr.md README.it.md README.ja.md README.ko.md README.md README.no.md README.pl.md README.ru.md README.th.md README.tr.md README.uk.md README.vi.md README.zh.md README.zht.md screenshot-uk.png script/ sdks/ SECURITY.md specs/ sst-env.d.ts sst.config.ts STATS.md tsconfig.json turbo.json (65 entries) </entries>
/tmp/opencode/session-recovery-v19-review/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/app/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/ui/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/opencode/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/desktop/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/opencode/src/session/llm/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/app/e2e/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/session-ui/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/schema/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/opencode/src/server/routes/instance/httpapi/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/opencode/test/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/opencode/test/server/AGENTS.md /tmp/opencode/session-recovery-v19-review/packages/app/e2e/performance/AGENTS.md /tmp/opencode/session-recovery-v19-review/...
a2bce01664538243cb8ba16c6ca8f0364c6f79463ad6677567044a1b3e1e74fe /tmp/opencode/session-recovery-final-v19.patch 753b05afb86195246b211237ca5b11e26a7c08da863d70a711da2c93ee453c8a /home/byk/Code/opencode/packages/opencode/dist/server/opencode-server ab9408c81cc9916177641ae8e9f08624fc27b5b9 M packages/client/src/generated/types.ts M packages/core/schema.json M packages/core/src/database/migration.gen.ts M packages/core/src/database/schema.gen.ts M packages/core/src/session.ts M packages/core/src/session/compaction.ts M packages/core/src/session/context-epoch.ts M packages/core/src/session/execution/local.ts M packages/core/src/session/input.ts M packages/core/src/session/message-updater.ts M packages/core/src/session/projector.ts M packages/core/src/session/run-coordinator.ts M packages/core/src/session/runner/index.ts M packages/core/src/session/runner/llm.ts M packages/core/src/session/runner/publish-llm-event.ts M packages/core/src/session/sql.ts M ...
72 0 packages/client/src/generated/types.ts 567 48 packages/core/schema.json 1 0 packages/core/src/database/migration.gen.ts 62 0 packages/core/src/database/migration/20260914170650_session-recovery.ts 52 1 packages/core/src/database/schema.gen.ts 6 4 packages/core/src/session.ts 31 16 packages/core/src/session/compaction.ts 54 34 packages/core/src/session/context-epoch.ts 200 19 packages/core/src/session/execution/local.ts 391 31 packages/core/src/session/input.ts 69 0 packages/core/src/session/message-updater.ts 88 1 packages/core/src/session/projector.ts 504 0 packages/core/src/session/recovery.ts 30 5 packages/core/src/session/run-coordinator.ts 4 0 packages/core/src/session/runner/index.ts 358 104 packages/core/src/session/runner/llm.ts 111 48 packages/core/src/session/runner/publish-llm-event.ts 88 1 packages/core/src/session/sql.ts 66 1 packages/core/test/database-migration.test.ts 352 0 packages/core/test/session-execution-local.test.ts 2771 3 packages/core/test/session-project...
<path>/tmp/opencode/session-recovery-v19-review/AGENTS.md</path> <type>file</type> <content> 1: - To regenerate the legacy JavaScript SDK, run `./packages/sdk/js/script/build.ts`. 2: - After changing the public Protocol or Server `HttpApi`, run `bun run generate` from `packages/client`. Do not edit `src/generated` or `src/generated-effect` directly. 3: - Keep runtime dependencies directed from Schema to Core and Protocol, then from Core and Protocol to Server. Client runtime code may depend on Schema and Protocol but never Core or Server; `sdk-next` composes Client, Core, and Server. 4: - The default branch in this repo is `dev`. 5: - Local `main` ref may not exist; use `dev` or `origin/dev` for diffs. 6: 7: ## Branch Names 8: 9: Use a short branch name of at most three words, separated by hyphens. Do not use slashes or type prefixes such as `feat/` or `fix/`. 10: 11: Examples: `session-recovery`, `fix-scroll-state`, `regenerate-sdk`. ...
<path>/tmp/opencode/session-recovery-v19-review/packages/schema/AGENTS.md</path> <type>file</type> <content> 1: # Schema Package Guide 2: 3: `@opencode-ai/schema` owns browser-safe wire and storage contracts shared by protocol, server, core, and generated SDKs. Keep runtime behavior, service layers, side effects, and host-local implementation details in the domain package that owns them. 4: 5: ## Package Boundary 6: 7: - Preserve the dependency direction: `@opencode-ai/schema <- @opencode-ai/protocol <- @opencode-ai/server`. 8: - Schema values should be serializable contract definitions, not service implementations or runtime registries. 9: - A domain may keep a minimal public wire contract here when SDK generation needs it, but do not move the broader runtime model into Schema just because an event is public. `plugin.added` is the current example: Schema may own the minimum browser-safe event payload, while plugin runtime behavior stays outside Schema. ...
<path>/tmp/opencode/session-recovery-v19-review/packages/opencode/AGENTS.md</path>
<type>file</type>
<content>
1: # opencode database guide
2:
3: ## Database
4:
5: - **Schema**: Drizzle schema lives in `packages/core/src/**/*.sql.ts`.
6: - **Migrations**: database migrations live in `packages/core` and are applied by core.
7:
8: ## Development server
9:
10: - Running `bun dev` from `packages/opencode` starts the live interactive TUI. Do not run it as a blocking foreground command when you need to inspect the result.
11: - Start it in `tmux` instead: `tmux new-session -d -s opencode-dev 'bun dev'`.
12: - Capture the current TUI output with: `tmux capture-pane -pt opencode-dev`.
13: - Stop the session explicitly when done: `tmux kill-session -t opencode-dev`.
14:
15: # Module shape
16:
17: Do not use `export namespace Foo { ... }` for module organization. It is not
18: standard ESM, it prevents tree-shaking, and it breaks Node's native TypeScript
19: runner. ...
<path>/tmp/opencode/session-recovery-v19-review/packages/opencode/src/server/routes/instance/httpapi/AGENTS.md</path>
<type>file</type>
<content>
1: # HttpApi Route Patterns
2:
3: Use `HttpApiBuilder.group(...)` for normal HTTP endpoints, including streaming HTTP responses such as server-sent events. Handlers should yield stable services once while building the handler layer, then close over those services in endpoint implementations.
4:
5: ```ts
6: export const sessionHandlers = HttpApiBuilder.group(InstanceHttpApi, "session", (handlers) =>
7: Effect.gen(function* () {
8: const session = yield* Session.Service
9:
10: return handlers.handle("list", () => session.list())
11: }),
12: )
13: ```
14:
15: For SSE endpoints, stay in `HttpApiBuilder.group(...)` and return `HttpServerResponse.stream(...)` from the handler. Annotate the endpoint success schema with `HttpApiSchema.asText({ contentType: "text/event-stream" })` so OpenAPI documents the stream content type. ...
11174 /tmp/opencode/session-recovery-final-v19.patch 34
Found 34 matches /tmp/opencode/session-recovery-final-v19.patch: Line 1: diff --git a/packages/client/src/generated/types.ts b/packages/client/src/generated/types.ts Line 109: diff --git a/packages/core/schema.json b/packages/core/schema.json Line 1025: diff --git a/packages/core/src/database/migration.gen.ts b/packages/core/src/database/migration.gen.ts Line 1036: diff --git a/packages/core/src/database/migration/20260914170650_session-recovery.ts b/packages/core/src/database/migration/20260914170650_session-recovery.ts Line 1104: diff --git a/packages/core/src/database/schema.gen.ts b/packages/core/src/database/schema.gen.ts Line 1210: diff --git a/packages/core/src/session.ts b/packages/core/src/session.ts Line 1250: diff --git a/packages/core/src/session/compaction.ts b/packages/core/src/session/compaction.ts Line 1339: diff --git a/packages/core/src/session/context-epoch.ts b/packages/core/src/session/context-epoch.ts Line 1515: diff --git ...
<path>/tmp/opencode/session-recovery-final-v19.patch</path>
<type>file</type>
<content>
1: diff --git a/packages/client/src/generated/types.ts b/packages/client/src/generated/types.ts
2: index 3b3188c874..5130fa9496 100644
3: --- a/packages/client/src/generated/types.ts
4: +++ b/packages/client/src/generated/types.ts
5: @@ -775,8 +775,17 @@ export type SessionsHistoryOutput = {
6: }>
7: }
8: readonly delivery: "steer" | "queue"
9: + readonly requestExecution?: boolean
10: }
11: }
12: + | {
13: + readonly id: string
14: + readonly metadata?: { readonly [x: string]: JsonValue }
15: + readonly type: "session.next.prompt.execution_requested"
16: + readonly durable?: { readonly aggregateID: string; readonly seq: number; readonly version: number }
17: + readonly location?: { readonly directory: string; readonly workspaceID?: string }
18: + readonly data: { readonly timestamp: number; ...
<path>/tmp/opencode/session-recovery-final-v19.patch</path>
<type>file</type>
<content>
1564: + .select({ seq: SessionMessageTable.seq })
1565: + .from(SessionMessageTable)
1566: + .where(and(eq(SessionMessageTable.session_id, sessionID), eq(SessionMessageTable.type, "assistant")))
1567: + .orderBy(desc(SessionMessageTable.seq))
1568: + .limit(1)
1569: + .get()
1570: + .pipe(Effect.orDie)
1571: + return yield* db
1572: + .insert(SessionExecutionTable)
1573: + .values({
1574: + id: executionID,
1575: + session_id: sessionID,
1576: + owner_id: ownerID,
1577: + phase: "ready",
1578: + assistant_seq: latest?.seq ?? ...
<path>/tmp/opencode/session-recovery-final-v19.patch</path>
<type>file</type>
<content>
2812: + stored.phase === phase.value
2813: + )
2814: + return Effect.void
2815: + return Clock.currentTimeMillis.pipe(
2816: + Effect.flatMap((quarantinedAt) =>
2817: + db
2818: + .update(SessionExecutionTable)
2819: + .set({ recovery_error: "Recovery projection failed" })
2820: + .where(
2821: + and(
2822: + eq(SessionExecutionTable.id, recoveryClaim.executionID),
2823: + eq(SessionExecutionTable.session_id, recoveryClaim.sessionID),
2824: + eq(SessionExecutionTable.owner_id, recoveryClaim.ownerID),
2825: + gt(SessionExecutionTable.expires_at, ...
<path>/tmp/opencode/session-recovery-final-v19.patch</path>
<type>file</type>
<content>
3960: + error: { type: "unknown", message },
3961: + },
3962: + commit,
3963: + )
3964: assistantActive = false
3965: assistantFailed = true
3966: - yield* events.publish(SessionEvent.Step.Failed, {
3967: - sessionID: input.sessionID,
3968: - timestamp: yield* timestamp,
3969: - assistantMessageID,
3970: - error: { type: "unknown", message },
3971: - })
3972: })
3973:
3974: const failUnsettledTools = Effect.fn("SessionRunner.failUnsettledTools")(function* (
3975: message: string,
3976: hostedOnly = false,
3977: + commit: () => Effect.Effect<void> = input.eventCommit,
3978: ) {
3979: for (const [callID, tool] of tools) {
3980: if (tool.settled || (hostedOnly && !tool.providerExecuted)) continue
3981: - tool.settled = true
3982: - yield* events.publish(SessionEvent.Tool.Failed, {
3983: - ...
<path>/tmp/opencode/session-recovery-final-v19.patch</path>
<type>file</type>
<content>
5226: + expect(yield* db.select().from(SessionExecutionTable).all()).toEqual([])
5227: + expect(yield* db.select().from(SessionRecoveryTable).all()).toEqual([])
5228: + expect(yield* db.select().from(SessionInputTable).all()).toEqual([])
5229: + expect(
5230: + yield* db
5231: + .select({ type: EventTable.type })
5232: + .from(EventTable)
5233: + .where(eq(EventTable.type, "session.next.step.recovered.1"))
5234: + .all(),
5235: + ).toEqual([])
5236: + }),
5237: + )
5238: + }
5239: +
5240: + it.effect("recovers assistant-less continuation at its current assistant boundary", () =>
5241: + Effect.gen(function* () {
5242: + const { db } = yield* Database.Service
5243: + yield* db
5244: + .insert(ProjectTable)
5245: + .values({ id: Project.ID.global, worktree: ...
<path>/tmp/opencode/session-recovery-final-v19.patch</path>
<type>file</type>
<content>
6658: + project_id: Project.ID.global,
6659: + slug: "test",
6660: + directory: "/project",
6661: + title: "test",
6662: + version: "test",
6663: + })
6664: + .run()
6665: + yield* events.publish(SessionEvent.Step.Recovered, {
6666: + sessionID,
6667: + timestamp: created,
6668: + executionID: "quarantined-steer",
6669: + phase: "ready",
6670: + })
6671: + const continuationID = continuation("quarantined-steer")
6672: + yield* db
6673: + .update(SessionInputTable)
6674: + .set({ delivery: "steer" })
6675: + .where(eq(SessionInputTable.id, continuationID))
6676: + .run()
6677: + yield* SessionRecovery.recover().pipe(Effect.provideService(SessionExecution.Service, recoveryExecution))
6678: + expect(yield* ...
<path>/tmp/opencode/session-recovery-final-v19.patch</path>
<type>file</type>
<content>
8069: @@ -119,8 +143,23 @@ test("old success event data containing result still decodes", () => {
8070: assistantMessageID: SessionMessage.ID.create(),
8071: callID: "call-old",
8072: structured: { type: "media", mime: "image/png" },
8073: - content: [{ type: "file", uri: `data:image/png;base64,${base64}`, mime: "image/png" }],
8074: - result: { type: "content", value: [{ type: "file", uri: `data:image/png;base64,${base64}`, mime: "image/png" }] },
8075: + content: [
8076: + {
8077: + type: "file",
8078: + uri: `data:image/png;base64,${base64}`,
8079: + mime: "image/png",
8080: + },
8081: + ],
8082: + result: {
8083: + type: "content",
8084: + value: [
8085: + {
8086: + type: "file",
8087: + uri: `data:image/png;base64,${base64}`,
8088: + mime: "image/png",
8089: + },
8090: + ...
<path>/tmp/opencode/session-recovery-final-v19.patch</path>
<type>file</type>
<content>
9322: + const interrupted = yield* session.interrupt(sessionID).pipe(
9323: + Effect.exit,
9324: + Effect.ensuring(db.run(sql`DROP TRIGGER fail_interrupted_tool_publication`).pipe(Effect.orDie)),
9325: + )
9326: + toolExecutionGate = undefined
9327: +
9328: + expect(Exit.isSuccess(interrupted)).toBe(true)
9329: + expect(yield* Fiber.await(run)).toMatchObject({ _tag: "Failure" })
9330: + expect(yield* db.select().from(SessionExecutionTable).get()).toBeUndefined()
9331: + expect(yield* session.context(sessionID)).toMatchObject([
9332: + { type: "user", text: "Interrupt publication failure" },
9333: + {
9334: + type: "assistant",
9335: + finish: "error",
9336: + content: [{ type: "tool", id: "call-interrupt-publication-failure", state: { status: "error" } }],
9337: + },
9338: + ])
9339: + }),
9340: ...
<path>/tmp/opencode/session-recovery-final-v19.patch</path>
<type>file</type>
<content>
10845: + "type": "string"
10846: + },
10847: + "seq": {
10848: + "type": "integer"
10849: + },
10850: + "version": {
10851: + "type": "integer"
10852: + }
10853: + },
10854: + "required": ["aggregateID", "seq", "version"],
10855: + "additionalProperties": false
10856: + },
10857: + "location": {
10858: + "$ref": "#/components/schemas/LocationRef"
10859: + },
10860: + "data": {
10861: + "type": "object",
10862: + "properties": {
10863: + "timestamp": {
10864: + "type": "number"
10865: + },
10866: + "sessionID": {
10867: + "type": "string",
10868: + "pattern": "^ses"
10869: + },
10870: + ...
Found 11 matches
/tmp/opencode/session-recovery-v19-review/packages/core/src/event.ts:
Line 123: readonly commit?: (seq: number) => Effect.Effect<void>
Line 214: commit?: (seq: number) => Effect.Effect<void>,
Line 369: function publishEvent<D extends Definition>(definition: D, event: Payload<D>, commit?: PublishOptions["commit"]) {
Line 436: options?.commit,
/tmp/opencode/session-recovery-v19-review/packages/core/src/session/input.ts:
Line 502: commit?: (row: typeof SessionInputTable.$inferSelect) => Effect.Effect<void>,
Line 536: commit?: (row: typeof SessionInputTable.$inferSelect) => Effect.Effect<void>,
Line 570: commit?: (row: typeof SessionInputTable.$inferSelect) => Effect.Effect<void>,
Line 591: return row === undefined ? false : yield* publish(db, events, sessionID, [row.input], commit).pipe(Effect.as(true))
Line 615: yield* publish(db, events, sessionID, [row], ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/execution/local.ts</path>
<type>file</type>
<content>
1: import { and, asc, desc, eq, isNull } from "drizzle-orm"
2: import { Cause, Clock, DateTime, Duration, Effect, Exit, Layer, Option, Schedule } from "effect"
3: import { Database } from "../../database/database"
4: import { LocationServiceMap } from "../../location-service-map"
5: import { makeGlobalNode } from "../../effect/app-node"
6: import { SessionRunCoordinator } from "../run-coordinator"
7: import { SessionRunner } from "../runner"
8: import { SessionMessage } from "../message"
9: import { SessionSchema } from "../schema"
10: import { SessionStore } from "../store"
11: import { SessionExecution } from "../execution"
12: import { EventV2 } from "../../event"
13: import { SessionEvent } from "../event"
14: import { SessionExecutionClaim } from "./claim"
15: import {
16: SESSION_EXECUTION_LEASE_MS,
17: SessionExecutionTable,
18: ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/execution/claim.ts</path>
<type>file</type>
<content>
1: export * as SessionExecutionClaim from "./claim"
2:
3: import { and, eq, gt, notInArray } from "drizzle-orm"
4: import { Clock, Effect } from "effect"
5: import type { Database } from "../../database/database"
6: import type { SessionSchema } from "../schema"
7: import { SESSION_EXECUTION_LEASE_MS, SessionExecutionTable } from "../sql"
8:
9: type DatabaseService = Database.Interface["db"]
10:
11: export type Claim = {
12: readonly sessionID: SessionSchema.ID
13: readonly executionID: string
14: readonly ownerID: string
15: }
16:
17: export type Values = Partial<
18: Pick<typeof SessionExecutionTable.$inferInsert, "assistant_message_id" | "assistant_seq" | "phase">
19: >
20:
21: export class Lost extends Error {
22: constructor(readonly claim: Claim) {
23: super(`Session execution claim lost: ${claim.executionID}`)
24: }
25: }
26:
27: ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/run-coordinator.ts</path>
<type>file</type>
<content>
1: export * as SessionRunCoordinator from "./run-coordinator"
2:
3: import { Deferred, Effect, Exit, Fiber, FiberSet, Scope } from "effect"
4:
5: /** Serializes execution for each key while allowing different keys to run concurrently. */
6: export interface Coordinator<Key, E> {
7: /** Snapshots keys with an execution owned by this coordinator. */
8: readonly active: Effect.Effect<ReadonlySet<Key>>
9: /** Starts execution while idle or joins the active execution. */
10: readonly run: (key: Key) => Effect.Effect<void, E>
11: /** Registers one coalesced follow-up after newly recorded work. */
12: readonly wake: (key: Key) => Effect.Effect<void>
13: /** Stops active execution, runs cleanup, then starts work that arrived while stopping. */
14: readonly interrupt: (key: Key, cleanup?: Effect.Effect<void>) => Effect.Effect<void>
15: }
16:
17: ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/event.ts</path>
<type>file</type>
<content>
90: const page = rows.slice(0, input.limit)
91: const decode = Schema.decodeUnknownSync(input.manifest.schema)
92: const events = page.map((event) =>
93: decode({
94: id: event.id,
95: type: input.manifest.definitions.get(event.type)?.type ?? event.type,
96: durable: {
97: aggregateID: event.aggregate_id,
98: seq: event.seq,
99: version: input.manifest.definitions.get(event.type)?.durable?.version,
100: },
101: data: event.data,
102: }),
103: )
104: return {
105: events,
106: hasMore: rows.length > input.limit,
107: }
108: })
109:
110: export class SubscriberOverflowError extends Schema.TaggedErrorClass<SubscriberOverflowError>()(
111: "EventV2.SubscriberOverflow",
112: { capacity: Schema.Int },
113: ) {}
114:
115: export const define = Event.define
116: export const versionedType = ...
Found 1 matches /tmp/opencode/session-recovery-v19-review/packages/core/schema.json: Line 6: "d4ff43d2-c4f9-442c-bada-a7d488b42fd2"
Found 1 matches /tmp/opencode/session-recovery-v19-review/packages/core/schema.json: Line 5: "prevIds": [
No files found
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/database/schema.gen.ts</path> <type>file</type> <content> 100: yield* tx.run(` 101: CREATE TABLE \`project_directory\` ( 102: \`project_id\` text NOT NULL, 103: \`directory\` text NOT NULL, 104: \`type\` text, 105: \`strategy\` text, 106: \`time_created\` integer NOT NULL, 107: CONSTRAINT \`project_directory_pk\` PRIMARY KEY(\`project_id\`, \`directory\`), 108: CONSTRAINT \`fk_project_directory_project_id_project_id_fk\` FOREIGN KEY (\`project_id\`) REFERENCES \`project\`(\`id\`) ON DELETE CASCADE 109: ); 110: `) 111: yield* tx.run(` 112: CREATE TABLE \`project\` ( 113: \`id\` text PRIMARY KEY, 114: \`worktree\` text NOT NULL, 115: \`vcs\` text, 116: \`name\` text, 117: \`icon_url\` text, 118: \`icon_url_override\` text, 119: \`icon_color\` ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/recovery.ts</path>
<type>file</type>
<content>
1: export * as SessionRecovery from "./recovery"
2:
3: import { and, asc, desc, eq, exists, gt, isNull, lte, or, sql } from "drizzle-orm"
4: import { Clock, DateTime, Effect, Layer, Option, Schedule, Schema } from "effect"
5: import { Database } from "../database/database"
6: import { makeGlobalNode } from "../effect/app-node"
7: import { EventV2 } from "../event"
8: import { SessionEvent } from "./event"
9: import { SessionExecution } from "./execution"
10: import { SessionProjector } from "./projector"
11: import { SessionExecutionClaim } from "./execution/claim"
12: import { SessionInput } from "./input"
13: import { continuation } from "./recovery-id"
14: import { SessionSchema } from "./schema"
15: import {
16: MAX_WAKE_ATTEMPTS,
17: SESSION_EXECUTION_LEASE_MS,
18: SessionExecutionTable,
19: SessionInputTable,
20: SessionRecoveryTable,
21: ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/input.ts</path>
<type>file</type>
<content>
1: export * as SessionInput from "./input"
2:
3: import { and, asc, desc, eq, isNull, lte } from "drizzle-orm"
4: import { DateTime, Effect, Option, Schema } from "effect"
5: import { Admitted, Delivery } from "@opencode-ai/schema/session-input"
6: import type { Database } from "../database/database"
7: import { EventV2 } from "../event"
8: import { SessionEvent } from "./event"
9: import { SessionMessage } from "./message"
10: import { Prompt } from "./prompt"
11: import { continuation, message } from "./recovery-id"
12: import { SessionSchema } from "./schema"
13: import { SessionInputTable, SessionMessageTable, SessionRecoveryTable, SessionTable } from "./sql"
14:
15: type DatabaseService = Database.Interface["db"]
16:
17: export { Admitted, Delivery }
18:
19: const decodePrompt = Schema.decodeUnknownSync(Prompt)
20: const encodePrompt = ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/projector.ts</path>
<type>file</type>
<content>
340: .update(SessionTable)
341: .set({ agent: event.data.agent, time_updated: DateTime.toEpochMillis(event.data.timestamp) })
342: .where(eq(SessionTable.id, event.data.sessionID))
343: .run()
344: .pipe(Effect.orDie, Effect.andThen(run(db, event))),
345: )
346: yield* events.project(SessionEvent.ModelSwitched, (event) =>
347: Effect.gen(function* () {
348: yield* db
349: .update(SessionTable)
350: .set({ model: event.data.model, time_updated: DateTime.toEpochMillis(event.data.timestamp) })
351: .where(eq(SessionTable.id, event.data.sessionID))
352: .run()
353: .pipe(Effect.orDie)
354: yield* run(db, event)
355: }),
356: )
357: yield* events.project(SessionEvent.Prompted, (event) =>
358: Effect.gen(function* () {
359: ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/runner/llm.ts</path>
<type>file</type>
<content>
100: const events = yield* EventV2.Service
101: const llm = yield* LLMClient.Service
102: const agents = yield* AgentV2.Service
103: const tools = yield* ToolRegistry.Service
104: const models = yield* SessionRunnerModel.Service
105: const store = yield* SessionStore.Service
106: const location = yield* Location.Service
107: const systemContext = yield* SystemContextRegistry.Service
108: const skillGuidance = yield* SkillGuidance.Service
109: const referenceGuidance = yield* ReferenceGuidance.Service
110: const config = yield* Config.Service
111: const snapshots = yield* Snapshot.Service
112: const db = (yield* Database.Service).db
113: const compaction = SessionCompaction.make({
114: events,
115: llm,
116: config: yield* config.entries(),
117: })
118: const getSession = ...
Found 3 matches
/tmp/opencode/session-recovery-v19-review/packages/core/src/snapshot.ts:
Line 49: readonly capture: () => Effect.Effect<ID | undefined>
Line 129: const capture = Effect.fn("Snapshot.capture")(function* () {
Line 241: capture: () => Effect.succeed(undefined),
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/snapshot.ts</path>
<type>file</type>
<content>
110: return new Git.Repository({
111: worktree,
112: gitDirectory,
113: commonDirectory: gitDirectory,
114: })
115: return yield* git.repo
116: .create({
117: worktree,
118: gitDirectory,
119: seed: source,
120: })
121: .pipe(Effect.mapError((cause) => failure("capture", cause)))
122: })
123:
124: const enabled = Effect.fnUntraced(function* () {
125: if (location.vcs?.type !== "git") return false
126: return Config.latest(yield* config.entries(), "snapshots") !== false
127: })
128:
129: const capture = Effect.fn("Snapshot.capture")(function* () {
130: if (!(yield* enabled())) return undefined
131: return yield* Effect.gen(function* () {
132: const repo = yield* repository()
133: return ID.make(
134: ...
No files found
<path>/tmp/opencode/session-recovery-v19-review/packages/core/test/session-run-coordinator.test.ts</path>
<type>file</type>
<content>
260: ? Deferred.succeed(firstStarted, undefined).pipe(
261: Effect.andThen(Effect.never),
262: Effect.onInterrupt(() =>
263: Deferred.succeed(cleanupStarted, undefined).pipe(Effect.andThen(Deferred.await(cleanupGate))),
264: ),
265: )
266: : Deferred.succeed(secondStarted, undefined),
267: ),
268: ),
269: })
270:
271: yield* coordinator.wake("session")
272: yield* Deferred.await(firstStarted)
273: const interrupt = yield* coordinator.interrupt("session").pipe(Effect.forkChild)
274: yield* Deferred.await(cleanupStarted)
275: yield* coordinator.wake("session")
276: yield* Deferred.succeed(cleanupGate, undefined)
277: ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/package.json</path>
<type>file</type>
<content>
1: {
2: "$schema": "https://json.schemastore.org/package.json",
3: "version": "1.18.30",
4: "name": "@opencode-ai/core",
5: "type": "module",
6: "license": "MIT",
7: "private": true,
8: "scripts": {
9: "db": "bun drizzle-kit",
10: "migration": "bun run script/migration.ts",
11: "fix-node-pty": "bun run script/fix-node-pty.ts",
12: "test": "bun test --only-failures",
13: "typecheck": "tsgo --noEmit"
14: },
15: "bin": {
16: "opencode": "./bin/opencode"
17: },
18: "exports": {
19: "./effect/layer-node": "./src/effect/layer-node.ts",
20: "./effect/app-node": "./src/effect/app-node.ts",
21: "./session/runner": "./src/session/runner/index.ts",
22: "./system-context": "./src/system-context/index.ts",
23: "./*": "./src/*.ts"
24: },
25: "imports": {
26: "#sqlite": {
27: "bun": ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/script/migration.ts</path>
<type>file</type>
<content>
1: #!/usr/bin/env bun
2:
3: import { $ } from "bun"
4: import fs from "fs/promises"
5: import os from "os"
6: import path from "path"
7: import { pathToFileURL } from "url"
8: import { parseArgs } from "util"
9:
10: const root = path.resolve(import.meta.dirname, "../../..")
11: const snapshot = path.join(root, "packages/core/schema.json")
12: const tsDir = path.join(root, "packages/core/src/database/migration")
13: const registry = path.join(root, "packages/core/src/database/migration.gen.ts")
14: const schema = path.join(root, "packages/core/src/database/schema.gen.ts")
15: const args = parseArgs({
16: args: process.argv.slice(2),
17: options: {
18: check: { type: "boolean" },
19: name: { type: "string" },
20: },
21: })
22:
23: if (args.values.check) {
24: await check()
25: process.exit(0)
26: }
27:
28: await generate()
29:
30: async function ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/message-updater.ts</path>
<type>file</type>
<content>
1: import { castDraft, produce, type WritableDraft } from "immer"
2: import { Effect } from "effect"
3: import { SessionEvent } from "./event"
4: import { SessionMessage } from "./message"
5: import { message } from "./recovery-id"
6:
7: export type MemoryState = {
8: messages: SessionMessage.Message[]
9: }
10:
11: export interface Adapter {
12: readonly getCurrentAssistant: () => Effect.Effect<SessionMessage.Assistant | undefined>
13: readonly getAssistant: (messageID: SessionMessage.ID) => Effect.Effect<SessionMessage.Assistant | undefined>
14: readonly getCurrentShell: (callID: string) => Effect.Effect<SessionMessage.Shell | undefined>
15: readonly updateAssistant: (assistant: SessionMessage.Assistant) => Effect.Effect<void>
16: readonly updateShell: (shell: SessionMessage.Shell) => Effect.Effect<void>
17: readonly appendMessage: (message: ...
Found 2 matches
/tmp/opencode/session-recovery-v19-review/packages/core/src/session/projector.ts:
Line 141: const adapter: SessionMessageUpdater.Adapter = {
Line 160: getAssistant(messageID) {
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/projector.ts</path>
<type>file</type>
<content>
120: function run(db: DatabaseService, event: SessionEvent.Event) {
121: return Effect.gen(function* () {
122: const decodeRow = (row: typeof SessionMessageTable.$inferSelect) =>
123: decodeMessage({ ...row.data, id: row.id, type: row.type })
124: const updateMessage = (message: SessionMessage.Message) => {
125: if (event.durable === undefined) return Effect.die("Durable Session event is missing aggregate sequence")
126: const encoded = encodeMessage(message)
127: const { id, type, ...data } = encoded
128: return db
129: .update(SessionMessageTable)
130: .set({ type, time_created: DateTime.toEpochMillis(message.time.created), data })
131: .where(
132: and(
133: eq(SessionMessageTable.id, SessionMessage.ID.make(id)),
134: eq(SessionMessageTable.session_id, ...
Found 16 matches
/tmp/opencode/session-recovery-v19-review/packages/core/test/session-projector.test.ts:
Line 95: phase: "unknown",
Line 115: phase: "unknown",
Line 146: phase: "unknown",
Line 215: phase: "unknown",
Line 328: phase: "unknown",
Line 365: assistantRow(SessionMessage.ID.make("msg_recovery_newer"), 1, { created, completed: created }),
Line 375: phase: "unknown",
Line 410: .values(assistantRow(SessionMessage.ID.make(`msg_recovery_newer_${phase}`), 0, { created, completed: created }))
Line 524: .values(assistantRow(SessionMessage.ID.make("msg_recovery_current_boundary"), 0, { created, completed: created }))
Line 578: phase: "unknown",
Line 599: phase: "unknown",
Line 1473: phase: "unknown",
Line 1616: phase: "unknown",
Line 1731: phase: "unknown",
Line 1795: phase: "unknown",
Line 2766: ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/test/session-projector.test.ts</path>
<type>file</type>
<content>
60: id: _,
61: type,
62: ...data
63: } = encodeMessage(SessionMessage.Assistant.make({ id, type: "assistant", agent: "build", model, content: [], time }))
64: return { id, session_id: sessionID, type, seq, time_created: DateTime.toEpochMillis(time.created), data }
65: }
66:
67: describe("SessionProjector", () => {
68: it.effect("atomically reconciles one abandoned execution into one continuation", () =>
69: Effect.gen(function* () {
70: const { db } = yield* Database.Service
71: const events = yield* EventV2.Service
72: const assistantID = SessionMessage.ID.make("msg_recovery_assistant")
73: const continuationID = continuation("execution")
74: yield* db
75: .insert(ProjectTable)
76: .values({ id: Project.ID.global, worktree: AbsolutePath.make("/project"), sandboxes: [] })
77: ...
Found 7 matches
/tmp/opencode/session-recovery-v19-review/packages/sdk/openapi.json:
Line 15312: "$ref": "#/components/schemas/EventSessionNextPromptExecution_requested"
Line 20580: "$ref": "#/components/schemas/SyncEventSessionNextPromptExecution_requested"
Line 23814: "$ref": "#/components/schemas/SessionNextPromptExecution_requested"
Line 24203: "$ref": "#/components/schemas/SessionNextPromptExecution_requested"
Line 25724: "SyncEventSessionNextPromptExecution_requested": {
Line 28610: "SessionNextPromptExecution_requested": {
Line 34822: "EventSessionNextPromptExecution_requested": {
No files found
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/runner/publish-llm-event.ts</path>
<type>file</type>
<content>
1: import { ToolOutput, type LLMEvent, type ProviderMetadata, type ToolResultValue, type Usage } from "@opencode-ai/llm"
2: import { DateTime, Effect } from "effect"
3: import { EventV2 } from "../../event"
4: import { ModelV2 } from "../../model"
5: import { SessionEvent } from "../event"
6: import { SessionMessage } from "../message"
7: import { SessionSchema } from "../schema"
8:
9: type Input = {
10: readonly sessionID: SessionSchema.ID
11: readonly agent: string
12: readonly model: ModelV2.Ref
13: readonly snapshot?: string
14: readonly startCommit: (assistantMessageID: SessionMessage.ID, seq: number) => Effect.Effect<void>
15: readonly eventCommit: () => Effect.Effect<void>
16: }
17:
18: const safe = (value: number | undefined) => Math.max(0, Number.isFinite(value) ? (value ?? ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session/projector.ts</path>
<type>file</type>
<content>
500: yield* events.project(SessionEvent.RevertEvent.Committed, (event) =>
501: Effect.gen(function* () {
502: const boundary = yield* db
503: .select({ seq: SessionMessageTable.seq })
504: .from(SessionMessageTable)
505: .where(
506: and(
507: eq(SessionMessageTable.session_id, event.data.sessionID),
508: eq(SessionMessageTable.id, event.data.messageID),
509: ),
510: )
511: .get()
512: .pipe(Effect.orDie)
513: if (!boundary) return yield* Effect.die(`Revert boundary message not found: ${event.data.messageID}`)
514: yield* db
515: .delete(SessionMessageTable)
516: .where(
517: and(eq(SessionMessageTable.session_id, event.data.sessionID), gt(SessionMessageTable.seq, boundary.seq)),
518: ...
Found 100 matches (more matches available)
/tmp/opencode/session-recovery-v19-review/packages/core/src/session/input.ts:
Line 13: import { SessionInputTable, SessionMessageTable, SessionRecoveryTable, SessionTable } from "./sql"
Line 173: SessionRecoveryTable,
Line 174: eq(SessionRecoveryTable.continuation_message_id, SessionInputTable.id),
Line 180: isNull(SessionRecoveryTable.execution_id),
Line 306: .set({ wake_attempts: 0 })
Line 342: .update(SessionRecoveryTable)
Line 346: eq(SessionRecoveryTable.session_id, input.sessionID),
Line 347: eq(SessionRecoveryTable.continuation_message_id, input.id),
Line 348: eq(SessionRecoveryTable.wake_pending, true),
Line 360: .from(SessionRecoveryTable)
Line 361: .where(eq(SessionRecoveryTable.continuation_message_id, continuationMessageID))
Line 441: SessionRecoveryTable,
Line 442: eq(SessionRecoveryTable.continuation_message_id, ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/session.ts</path>
<type>file</type>
<content>
330: .from(SessionMessageTable)
331: .where(where)
332: .orderBy(order === "asc" ? asc(SessionMessageTable.seq) : desc(SessionMessageTable.seq))
333: const rows = yield* (input.limit === undefined ? query.all() : query.limit(input.limit).all()).pipe(
334: Effect.orDie,
335: )
336: return yield* Effect.forEach(direction === "previous" ? rows.toReversed() : rows, decode)
337: }),
338: message: Effect.fn("V2Session.message")(function* (input) {
339: const stored = yield* store.message(input.messageID)
340: return stored?.sessionID === input.sessionID ? stored.message : undefined
341: }),
342: context: Effect.fn("V2Session.context")(function* (sessionID) {
343: yield* result.get(sessionID)
344: return yield* store.context(sessionID)
345: }),
346: ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/src/database/migration/20260914170650_session-recovery.ts</path>
<type>file</type>
<content>
1: import { Effect } from "effect"
2: import type { DatabaseMigration } from "../migration"
3:
4: export default {
5: id: "20260914170650_session-recovery",
6: up(tx) {
7: return Effect.gen(function* () {
8: yield* tx.run(`ALTER TABLE \`session_input\` ADD \`wake_pending\` integer DEFAULT false NOT NULL;`)
9: yield* tx.run(
10: `ALTER TABLE \`session\` ADD \`wake_attempts\` integer DEFAULT 0 NOT NULL CONSTRAINT \`session_wake_attempts_check\` CHECK(\`wake_attempts\` >= 0 AND \`wake_attempts\` <= 9007199254740991);`,
11: )
12: yield* tx.run(`
13: CREATE TABLE \`session_execution\` (
14: \`id\` text NOT NULL,
15: \`session_id\` text NOT NULL,
16: \`owner_id\` text NOT NULL,
17: \`assistant_message_id\` text,
18: \`phase\` text NOT ...
<path>/tmp/opencode/session-recovery-v19-review/packages/core/schema.json</path>
<type>file</type>
<content>
1: {
2: "version": "7",
3: "dialect": "sqlite",
4: "id": "3bc49670-06d1-4eba-9a45-8c8128bdcf6f",
5: "prevIds": [
6: "d4ff43d2-c4f9-442c-bada-a7d488b42fd2"
7: ],
8: "ddl": [
9: {
10: "name": "workspace",
11: "entityType": "tables"
12: },
13: {
14: "name": "data_migration",
15: "entityType": "tables"
(Showing lines 1-15 of 2590. Use offset=16 to continue.)
</content>
abf93718acd0193fa2ca6cfc205cde8714eff23d7df42a4f093a55e9921fd1a3 - /usr/bin/bash: line 1: python: command not found
f14a9b18-8207-487e-a3d3-227e629ba9ad ["169a0f0f-d58f-479f-b024-fa1c7b9a09db"]
{
"patchPaths": 34,
"statusPaths": 34,
"pathSetsEqual": true,
"blobMismatches": [
{
"path": "packages/client/src/generated/types.ts",
"expected": "5130fa9496",
"got": "5130fa94963341f68ff81aeeb5c2f14e7338579e"
},
{
"path": "packages/core/schema.json",
"expected": "81e5eca808",
"got": "81e5eca8080cb1460c7c9b5c28009261c6bf3529"
},
{
"path": "packages/core/src/database/migration.gen.ts",
"expected": "77948f1529",
"got": "77948f152910d908fa990652e38c8d756dca04e6"
},
{
"path": "packages/core/src/database/migration/20260914170650_session-recovery.ts",
"expected": "20eb1a4373",
"got": "20eb1a43739b0bfaae61ad727f11b8a0f0c64c4e"
},
{
"path": "packages/core/src/database/schema.gen.ts",
"expected": "94881e7038",
"got": "94881e70387518c9caba17c8b9fcae204e5885b9"
},
{
"path": "packages/core/src/session.ts",
"expected": "1fbd6285d0",
"got": ...
Found 100 matches (more matches available)
/tmp/opencode/session-recovery-v19-review/packages/sdk/openapi.json:
Line 1815: "line_number": {
Line 1819: "absolute_offset": {
Line 1852: "required": ["path", "lines", "line_number", "absolute_offset", "submatches"],
Line 7103: "/session/{sessionID}/prompt_async": {
Line 7106: "operationId": "session.prompt_async",
Line 7241: "source": "import { createOpencodeClient } from \"@opencode-ai/sdk\n\nconst client = createOpencodeClient()\nawait client.session.prompt_async({\n ...\n})"
Line 8349: "aggregate_id": {
Line 8363: "required": ["id", "aggregate_id", "seq", "type", "data"],
Line 11279: "_tag": {
Line 11287: "required": ["_tag", "error"],
Line 11293: "_tag": {
Line 11299: ...
{
"checked": 34,
"prefixMismatches": []
}
Continue the strict read-only security review from where you stopped. Do not use recall. The frozen v19 candidate is already rejected by correctness, so any verdict is informative for finding additional defects only. Return substantive findings with exact file:line evidence and end exactly MERGE or DO-NOT-MERGE.
ripgrep execution failed
ripgrep execution failed
File not found: /tmp/opencode/session-recovery-v19-review/packages/core/src/session/revert.ts
ripgrep execution failed
File not found: /tmp/opencode/session-recovery-v19-review/packages/core/src/session
File not found: /tmp/opencode/session-recovery-v19-review/packages/core/src
NotFound: FileSystem.access (/tmp/opencode/session-recovery-v19-review)
File not found: /tmp/opencode/session-recovery-final-v19.patch
Step.Failed can be recovered as unknown work and trigger another provider StepcreateLLMEventPublisher.failAssistant commits Step.Failed using input.eventCommit, which only renews the current claim and leaves its phase unchanged (packages/core/src/session/runner/publish-llm-event.ts:222-239). The claim is still "unknown" from packages/core/src/session/runner/llm.ts:434-440. It becomes "safe" only later at packages/core/src/session/runner/llm.ts:513-518.
A crash after the durable Step.Failed commit but before that later update leaves:
"unknown".Recovery checks only that the referenced assistant is the latest assistant (packages/core/src/session/recovery.ts:147-165). It never checks whether that assistant already has time.completed, finish, or an error. It therefore emits Step.Recovered and creates a continuation (packages/core/src/session/recovery.ts:166-206; packages/core/src/session/projector.ts:441-466).
The recovery projector then overwrites the already settled assistant with a restart error and adds recovery text (packages/core/src/session/message-updater.ts:252-297). The pending continuation is subsequently awakened.
This turns a known terminal provider failure into another model call. That can incur cost and execute tools without a new user request. It also corrupts the durable meaning of the original Step.Failed.
Recovery must distinguish incomplete unknown work from an assistant already settled by Step.Failed. The terminal event and safe execution state should share one transaction where possible; otherwise recovery must inspect the completed projection and clear or reconcile the claim without creating a continuation. ...
### Current State - **Date:** Sep 17, 2026. - 🔴 **Active task (requested 01:35):** Strict **READ-ONLY security/pentest review** of frozen candidate `/tmp/opencode/session-recovery-v19-review`. The final response must: - Lead with findings. - Give exact `file:line` evidence. - Label each finding `MUST-FIX` or `CONCERN`. - Explicitly say if no blocker exists and identify residual risks. …
Date: Sep 17, 2026 * 🟡 (02:00) Tool returned identifier `f14a9b18-8207-487e-a3d3-227e629ba9ad` with associated list `["169a0f0f-d58f-479f-b024-fa1c7b9a09db"]`. * 🟡 (02:02) Patch/status verification found `patchPaths: 34`, `statusPaths: 34`, and `pathSetsEqual: true`. Git status contained 29 modified paths: `packages/client/src/generated/types.ts`, `packages/core/schema.json`, `packages/core/src…
Date: Sep 17, 2026 * 🟡 (01:52) Inspection of `/tmp/opencode/session-recovery-v19-review/packages/core/src/session/projector.ts:500-538` showed the `SessionEvent.RevertEvent.Committed` projector: it finds the revert boundary via `SessionMessageTable.session_id` + message `id`; dies with `Revert boundary message not found: ${event.data.messageID}` if absent; deletes later session messages where `s…
Date: Sep 17, 2026 * 🟡 (01:48) Search found 7 occurrences related to `SessionNextPromptExecution_requested` in `/tmp/opencode/session-recovery-v19-review/packages/sdk/openapi.json`: line 15312 references `#/components/schemas/EventSessionNextPromptExecution_requested`; line 20580 references `#/components/schemas/SyncEventSessionNextPromptExecution_requested`; lines 23814 and 24203 reference `#/c…
Date: Sep 17, 2026 * 🟡 (01:47) `packages/core/test/session-projector.test.ts:68-220` defines test `"atomically reconciles one abandoned execution into one continuation"` using assistant ID `msg_recovery_assistant`, execution ID `"execution"`, continuation ID `continuation("execution")`, and an expired `SessionExecutionTable` row with `owner_id: "dead"`, `phase: "unknown"`, `time_created: 0`, and…
Date: Sep 17, 2026 * 🔴 (01:45) User specified the recovery invariant: a newer turn supersedes stale incomplete rows; never resume an older assistant projection. * 🟡 (01:46) `packages/core/src/session/projector.ts:141-196` constructs `SessionMessageUpdater.Adapter` with `getCurrentAssistant()`, `getAssistant(messageID)`, `getCurrentShell(callID)`, `updateAssistant`, `updateShell`, and `appendMes…
Date: Sep 17, 2026 * 🟡 (01:43) `packages/core/package.json` defines private ESM package `@opencode-ai/core` version `1.18.30`, license `MIT`, with scripts: `"db": "bun drizzle-kit"`, `"migration": "bun run script/migration.ts"`, `"fix-node-pty": "bun run script/fix-node-pty.ts"`, `"test": "bun test --only-failures"`, and `"typecheck": "tsgo --noEmit"`; binary `"opencode"` points to `./bin/openco…
Date: Sep 17, 2026 * 🟡 (01:42) `packages/core/test/session-run-coordinator.test.ts` lines 260-283 show a coordinator interruption-race test: while the first `drain` run is blocked in interruption cleanup, `coordinator.wake("session")` is called; after `cleanupGate` opens and the interrupt fiber joins, `secondStarted` completes and `expect(runs).toBe(2)` verifies one follow-up run. * 🟡 (01:42) `…
Date: Sep 17, 2026 * 🟡 (01:41) In `packages/core/src/snapshot.ts`, snapshot support is enabled only when `location.vcs?.type === "git"` and `Config.latest(yield* config.entries(), "snapshots") !== false`. * 🟡 (01:41) `Snapshot.capture` calls `git.tree.capture` with `scopes: [yield* scope()]`, `ignores: source`, and `maximumUntrackedFileBytes: 2 * 1024 * 1024`; capture failures are logged as `"f…
Date: Sep 17, 2026 * 🟡 (01:40) Inspected session-input lifecycle logic. `SessionInput.admit` checks `isRecoveryInput(db, input.id)` and dies with `new LifecycleConflict({ id: input.id })` when a recovery continuation is improperly admitted through the normal path; stored input data includes `requestExecution`, `timeCreated`, and wake state. * 🟡 (01:41) In `packages/core/src/session/projector.ts…
Date: Sep 17, 2026 * 🟡 (01:39) Inspected the EventV2 service implementation. Its `Interface` exposes durable streaming by `{ aggregateID, after? }`; durable publishing derives the aggregate ID from the configured `durable.aggregate` data field, validates durable events, assigns aggregate-local sequence numbers, persists event metadata, and notifies subscribers. * 🟡 (01:39) EventV2 durable publi…
Date: Sep 17, 2026 * 🔴 (01:38) User stated that an expired session-execution claim never renews itself. * 🟡 (01:38) `packages/core/src/session/execution/claim.ts` defines `SessionExecutionClaim.Claim` with `sessionID`, `executionID`, and `ownerID`; claim matching requires all three fields plus `SessionExecutionTable.expires_at > now`. Lease timestamps use node wall clocks, and `SESSION_EXECUTIO…
Date: Sep 17, 2026 * 🟡 (01:38) The supplied patch adds runner coverage invoking `runner.run({ sessionID, force: true, executionID, ownerID: "test" }).pipe(Effect.forkChild)`. * 🟡 (01:38) The test patch coordinates execution with `Deferred.await(stepCommitted)` and directly inserts records into `SessionExecutionTable`. * 🟡 (01:38) A provider-step failure fixture uses `error: { type: "unknown", …
Date: Sep 17, 2026 * 🔴 [required-ownership-invariant] (01:38) User specified the provider-dispatch invariant: “never dispatches a provider after ownership changes”. * 🔴 [required-ownership-invariant] (01:38) User specified the streamed-output invariant: “never publishes streamed output after ownership changes”. * 🔴 [required-ownership-invariant] (01:38) User specified the local-tool invariant:…
Date: Sep 17, 2026 * 🔴 [required-recovery-invariant] (01:38) User specified the cancellation-claim invariant: “never recovers an expired cancellation claim”. * 🔴 [required-recovery-invariant] (01:38) User specified the cancellation-expiry invariant: “never quarantines cancellation after recovery ownership expires”. * 🔴 [required-recovery-invariant] (01:38) User specified the cancellation-trans…
Date: Sep 17, 2026 * 🔴 [required-recovery-invariant] (01:38) User specified the recovery-redrive invariant: “never wakes work settled between selection and redrive CAS”. * 🔴 [required-recovery-invariant] (01:38) User specified the recovery-boundary invariant: “never recovers a pre-promotion claim when input commits at the recovery boundary”. * 🔴 [required-recovery-invariant] (01:38) User speci…
Date: Sep 17, 2026 * 🔴 [required-concurrency-invariant] (01:37) User specified the execution-lease invariant: “never starts a second owner while the lease is live”. * 🔴 [required-concurrency-invariant] (01:37) User specified the execution-lease invariant: “never overwrites an expired lease”. * 🔴 [required-concurrency-invariant] (01:37) User specified the execution-lease invariant: “never re-en…
Date: Sep 17, 2026 * 🟡 (01:37) The patch excerpt calculates ordinary retry capacity as `const ordinaryRetryCapacity = BATCH_SIZE - retriedOrdinary.length - freshOrdinary.length`. * 🟡 (01:37) The patch excerpt runs a repeated effect with `Effect.repeat(Schedule.spaced("10 seconds"))`. * 🟡 (01:37) The patch excerpt defines an `interrupt` helper with signature `const interrupt = (key: Key, cleanu…
Date: Sep 17, 2026 * 🟡 (01:37) The patch excerpt defines `RecoveryPhase` as `Schema.Literals(["ready", "unknown", "continue"])`. * 🟡 (01:37) The patch excerpt adds a 504-line recovery-related file defining `Phase` as `Schema.Literals(["ready", "safe", "unknown", "continue", "cancelling", "cancelled"])`. * 🟡 (01:37) The patch excerpt adds cancellation-state handling that returns early when `cur…
Date: Sep 17, 2026 * 🟡 (01:37) User supplied a patch excerpt adding optional durable event metadata with exact shape `readonly durable?: { readonly aggregateID: string; readonly seq: number; readonly version: number }` in generated/public type surfaces. * 🟡 (01:37) The patch excerpt adds Session recovery database artifacts, including a `session_recovery` table, `assistant_message_id`, `wake_att…
Date: Sep 17, 2026 * 🟡 (01:36) Patch inspection reported `/tmp/opencode/session-recovery-final-v19.patch` is 11,174 lines and contains exactly 34 `diff --git` sections. * 🟡 (01:36) Patch numstat for the 34 changed paths was: `packages/client/src/generated/types.ts` +72/-0; `packages/core/schema.json` +567/-48; `packages/core/src/database/migration.gen.ts` +1/-0; `packages/core/src/database/migr…
Date: Sep 17, 2026 * 🔴 [requested-security-review] (01:35) User requested a strict READ-ONLY security/pentest review of the frozen candidate at `/tmp/opencode/session-recovery-v19-review`, with findings first, exact `file:line` evidence, and severity labels `MUST-FIX` or `CONCERN`. * 🔴 (01:35) User prohibited editing files, running tests/builds/services, mutating Git/index/refs, and using recal…