Session 0vrldJoMSuN7

commit ec83887a16f780f32fba4b7d710bad262dba3a22
Author:     sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
AuthorDate: Wed Sep 9 19:01:12 2026 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Wed Sep 9 19:01:12 2026 +0100

    fix(event): Prevent immediate retry of rate-limited org in event view fallback (#1566)
    
    This PR fixes an issue where the `sentry event view` command could
    trigger a "Consecutive HTTP" performance issue (CLI-2Y1).
    
    **Root Cause:**
    When `fetchEventWithContext` falls back to `tryEventFallbacks` and
    `resolveEventInOrg` hits a 429 (Too Many Requests) rate limit, the error
    was caught as a generic transient failure. This left `sameOrgSearched`
    as `false`, causing the subsequent `findEventAcrossOrgs` call to
    immediately retry the exact same rate-limited endpoint for the same
    organization. This back-to-back identical request against a rate-limited
    API endpoint caused the performance issue. ...

...output truncated...

Full output saved to: /home/byk/.local/share/opencode/tool-output/tool_089527488001nPJO1e2zNjmRc5


<!-- lore:01a02480-839e-7ba6-9717-24d7ddc0e709 -->
* **Large artifacts pipeline createWriteStream**: Large artifacts are always written with \`pipeline()\` into \`createWriteStream()\`, rather than buffering the complete payload in memory. Buffering looks simpler and may work for small fixtures, but it creates avoidable memory peaks and weakens backpressure for shipped CLI workloads.

<!-- lore:019f03b9-97f4-7bb6-aeba-27fa5aeca79b -->
* **Node version pinning convention: workflow-level env vars NODE\_VERSION\_22 / NODE\_VERSION\_24**: As of PR #1145, all GitHub Actions workflows in sentry-cli (TypeScript) centralize Node version pins as workflow-level \`env\` vars: \`NODE\_VERSION\_22: "22.23.1"\` and \`NODE\_VERSION\_24: "24.18.0"\`. All \`actions/setup-node\` steps reference \`${{ env.NODE\_VERSION\_22 }}\` or \`${{ env.NODE\_VERSION\_24 }}\` — no bare ...

# Jared (Outpost agent)

Autonomous GitHub coding agent. Work in `/workspace/repo`.

## Model tiers

The primary model is chosen per event (see `src/agents/models.ts`): heavy for
code-producing situations, cheaper for lightweight ones.

| Role | Subagent | Model |
| --- | --- | --- |
| Triage / plan / review (heavy) | (primary Jared) | Claude Opus 4.8 |
| Triage / plan / review (light) | (primary Jared) | xAI Grok 4.3 |
| Explore | `explore` | OpenAI gpt-5-mini |
| Implement | `implement` | Moonshot kimi-k2.7-code |
| Ship (commit/push/PR) | `ship` | xAI Grok (`grok-build-0.1`) |

Pipeline: triage → explore → plan → implement → review → ship.
(`worker` is a deprecated alias of `implement`.)

Operators also talk to Jared directly from the Outpost dashboard. Those turns
(`New operator chat` / `Operator guidance:`) skip triage — treat the request as
the task and answer in the conversation.

Long-term project knowledge for *this* Outpost repo lives in `.lore.md` when present. ...

AGENTS.md
packages/cli/.cursor/rules/ultracite.mdc
packages/cli/AGENTS.md
packages/cli/CONTRIBUTING.md

...output truncated...

Full output saved to: /home/byk/.local/share/opencode/tool-output/tool_08952cf90001vrlb7O5RHzYB2N


```bash
# Development
pnpm install                             # Install dependencies (from repo root)
pnpm run dev                             # Run CLI in dev mode
pnpm run cli -- <args>                   # Run the CLI with arguments

# Build
pnpm run build                           # Build for current platform
pnpm run build:all                       # Build for all platforms

# Type Checking
pnpm run typecheck                       # Check types (tsc)

# Linting & Formatting
pnpm run lint                            # Check for issues (Biome)
pnpm run lint:fix                        # Auto-fix issues (run before committing)

# Testing (Vitest)
pnpm run test:unit                       # Run unit tests
pnpm run test:e2e                        # Run e2e tests
pnpm exec vitest run test/lib/foo.test.ts # Run a single test file (skips generate steps)
pnpm exec ...

diff --git a/packages/cli/src/commands/cli/upgrade.ts b/packages/cli/src/commands/cli/upgrade.ts
index 8d8282368..8c03fa3f4 100644
--- a/packages/cli/src/commands/cli/upgrade.ts
+++ b/packages/cli/src/commands/cli/upgrade.ts
@@ -1,414 +1,462 @@
 /**
  * sentry cli upgrade
  *
  * Self-update the Sentry CLI to the latest or a specific version.
  * After upgrading, spawns the NEW binary with `cli setup` to update
  * completions, agent skills, and record installation metadata.
  *
  * Supports two release channels:
  * - stable (default): tracks the latest GitHub release
  * - nightly: tracks the rolling nightly prerelease built from main
  *
  * The channel can be set via --channel or by passing "nightly"/"stable"
  * as the version argument. The choice is persisted in the local database
  * so that subsequent bare `sentry cli upgrade` calls use the same channel. ...

diff --git a/packages/cli/src/lib/delta-upgrade.ts b/packages/cli/src/lib/delta-upgrade.ts
index ec709b8c8..37f4b7d54 100644
--- a/packages/cli/src/lib/delta-upgrade.ts
+++ b/packages/cli/src/lib/delta-upgrade.ts
@@ -1,358 +1,428 @@
 /** Delta upgrade discovery and application backed by binpatch. */
 
 import { join } from "node:path";
 // biome-ignore lint/performance/noNamespaceImport: Sentry SDK recommends namespace import
 import * as Sentry from "@sentry/node-core/light";
 import {
   applyPatchChainInMemory,
   extractStableChain as binpatchExtractStableChain,
   filterAndSortChainTags as binpatchFilterAndSortChainTags,
   validateChainStep as binpatchValidateChainStep,
   type DeltaTelemetry,
   type DeltaUnavailableReason,
   type ExtractStableChainOpts,
   type GitHubRelease,
   getPatchFromVersion,
   getPatchTargetSha256,
   ghcrSource,
   githubReleaseSource,
   type InstrumentHook,
   MAX_NIGHTLY_CHAIN_DEPTH,
   makeCache,
   OciClient,
   type OciManifest,
   ...

diff --git a/packages/cli/src/lib/release-notes.ts b/packages/cli/src/lib/release-notes.ts
index ddf617535..8cf12b4d4 100644
--- a/packages/cli/src/lib/release-notes.ts
+++ b/packages/cli/src/lib/release-notes.ts
@@ -1,99 +1,102 @@
 /**
  * Release Notes Parser & Aggregation
  *
  * Extracts user-facing changelog entries from GitHub Release bodies (stable)
  * or conventional commit messages (nightly). Uses `marked.lexer()` for
  * AST-based section extraction and produces structured data that can be
  * re-serialized as filtered markdown for rendering via `renderMarkdown()`. ...

diff --git a/packages/cli/src/lib/upgrade.ts b/packages/cli/src/lib/upgrade.ts
index 945adc48d..4a23b4b25 100644
--- a/packages/cli/src/lib/upgrade.ts
+++ b/packages/cli/src/lib/upgrade.ts
@@ -1,139 +1,228 @@
 /**
  * Upgrade Module
  *
  * Detects how the CLI was installed and provides self-upgrade functionality.
  * Binary management helpers (download URLs, locking, replacement) live in
  * binary.ts and are shared with the setup --install flow.
  */
 
 import { spawn } from "node:child_process";
 import {
   chmodSync,
   closeSync,
   existsSync,
   openSync,
   realpathSync,
   statSync,
   unlinkSync,
   writeSync,
 } from "node:fs";
 import { writeFile } from "node:fs/promises";
 import { homedir } from "node:os";
 import { dirname, isAbsolute, join, sep } from "node:path";
 import { setTimeout } from "node:timers/promises";
+import { prerelease as semverPrerelease, valid as semverValid } from "semver";
 import {
   acquireLock,
   cleanupOldBinary,
+  compareVersions,
   ...

diff --git a/packages/cli/test/commands/cli.test.ts b/packages/cli/test/commands/cli.test.ts
index cd1514eb0..4eec11e9d 100644
--- a/packages/cli/test/commands/cli.test.ts
+++ b/packages/cli/test/commands/cli.test.ts
@@ -87,150 +87,144 @@ describe("feedbackCommand.func", () => {
       "Please provide a feedback message."
     );
   });
 
   test("throws ConfigError when Sentry is disabled", async () => {
     const func = await feedbackCommand.loader();
     const mockContext = {
       stdout: { write: vi.fn(() => true) },
       stderr: { write: vi.fn(() => true) },
     };
 
     // Sentry is disabled in test environment (no DSN)
     await expect(
       func.call(mockContext, {}, "test", "feedback")
     ).rejects.toThrow("Feedback not sent: telemetry is disabled.");
   });
 });
 
 // Test the upgrade command func
 describe("upgradeCommand.func", () => {
   let originalFetch: typeof globalThis.fetch;
   let restoreStderr: (() => void) | undefined;
 
   beforeEach(() => {
     ...

diff --git a/packages/cli/test/lib/upgrade.test.ts b/packages/cli/test/lib/upgrade.test.ts
index 7c6f63a4b..6cfc7fae9 100644
--- a/packages/cli/test/lib/upgrade.test.ts
+++ b/packages/cli/test/lib/upgrade.test.ts
@@ -88,221 +88,370 @@ function fakeErrorProcess(message: string): FakeProc {
   };
   queueMicrotask(() => emitter.emit("error", new Error(message)));
   return emitter;
 }
 
 // Swappable spawn implementation. Individual tests replace `spawnImpl.fn`
 // before calling the code under test. The holder object is hoisted so
 // vi.mock() can capture the reference; tests mutate `.fn` to swap behavior.
 const { spawnImpl } = vi.hoisted(() => ({
   spawnImpl: {
     fn: (() => {
       // placeholder — replaced per-test
     }) as (cmd: string, args: string[], opts: object) => FakeProc,
   },
 }));
 // Initialize with the real default now that fakeProcess is defined
 spawnImpl.fn = () => fakeProcess(0);
 
 vi.mock("node:child_process", async (importOriginal) => {
   const orig = ...

diff --git a/packages/cli/test/lib/ghcr.test.ts b/packages/cli/test/lib/ghcr.test.ts
index e5c81d532..680851f68 100644
--- a/packages/cli/test/lib/ghcr.test.ts
+++ b/packages/cli/test/lib/ghcr.test.ts
@@ -1,47 +1,49 @@
 /**
  * GHCR Client Tests
  *
  * Unit tests for the GHCR/OCI download protocol helpers.
  * All HTTP calls are mocked via globalThis.fetch to avoid network access.
  */
 
 import { afterEach, beforeEach, describe, expect, test } from "vitest";
+import { UPGRADE_SOURCES } from "../../src/lib/binary.js";
 import { UpgradeError } from "../../src/lib/errors.js";
 import {
   downloadLayerBlob,
   downloadNightlyBlob,
   fetchManifest,
   fetchNightlyManifest,
   findLayerByFilename,
   GHCR_REPO,
   GHCR_TAG,
+  GhcrManifestHttpError,
   getAnonymousToken,
   getNightlyVersion,
   listTags,
   type OciManifest,
 } from "../../src/lib/ghcr.js";
 
 /** Store original fetch for restoration */
 let originalFetch: typeof globalThis.fetch;
 
 /** Helper to mock fetch without ...

diff --git a/packages/cli/test/lib/delta-upgrade.mocked.test.ts b/packages/cli/test/lib/delta-upgrade.mocked.test.ts
index cd0a2fddc..f6186ab59 100644
--- a/packages/cli/test/lib/delta-upgrade.mocked.test.ts
+++ b/packages/cli/test/lib/delta-upgrade.mocked.test.ts
@@ -72,85 +72,85 @@ function mockFetch(
 
 const BINARY_NAME = getPlatformBinaryName();
 
 function versionHex(version: string): string {
   return Array.from(version)
     .map((c) => c.charCodeAt(0).toString(16).padStart(2, "0"))
     .join("");
 }
 
 function tempFile(name: string): string {
   return join(
     tmpdir(),
     `delta-iso-${Date.now()}-${Math.random().toString(36).slice(2)}-${name}`
   );
 }
 
 // ============================================================================
 // resolveStableDelta
 // ============================================================================
 
 describe("resolveStableDelta", () => {
   test("resolves and applies a stable delta patch", async () => {
     // Create a ...

...output truncated...

Full output saved to: /home/byk/.local/share/opencode/tool-output/tool_08955c20e001arGE5RqZl4JJCM

+    const requests: string[] = [];
+
+    const resolved = await resolveUpgradeSource({
+      getProbeUrl: (source) => getGitHubReleaseByTagUrl("0.45.0", source),
+      fetch: async (url) => {
+        requests.push(String(url));
+        return new Response(JSON.stringify({ tag_name: "cli@0.45.0" }), {
+          status: 200,
+        });
+      },
+    });
+
+    expect(resolved).toEqual({
+      source: UPGRADE_SOURCES[0],
+      response: expect.any(Response),
+    });
+    expect(requests).toEqual([
+      "https://api.github.com/repos/getsentry/toolkit/releases/tags/cli%400.45.0",
+    ]);
+  });
+
+  test("falls back to the legacy source only on HTTP 404", async () => {
+    const requests: string[] = [];
+
+    const resolved = await resolveUpgradeSource({
+      getProbeUrl: (source) => getGitHubReleaseByTagUrl("0.45.0", source),
+      fetch: async ...

    60	  GhcrManifestHttpError,
    61	  getAnonymousToken,
    62	  getNightlyVersion,
    63	  type OciManifest,
    64	} from "./ghcr.js";
    65	import { logger } from "./logger.js";
    66	import { clearPatchCache } from "./patch-cache.js";
    67	import { makeByteProgress, type SetMessage } from "./progress.js";
    68	
    69	/** Scoped logger for upgrade operations */
    70	const log = logger.withTag("upgrade");
    71	
    72	// Re-export for backward compatibility — consumers that import
    73	// InstallationMethod from upgrade.ts continue to work.
    74	export type { InstallationMethod } from "./binary.js";
    75	// biome-ignore lint/performance/noBarrelFile: backward-compat re-export, not a barrel
    76	export { parseInstallationMethod } from "./binary.js";
    77	
    78	/** Package managers that can be used for global installs */
    79	type PackageManager = "npm" | "pnpm" | "bun" | "yarn";
    80	
    81	/**
    82	 * How the current upgrade reached the offline ...

   220	      return [];
   221	    }
   222	    const data = await response.json();
   223	    if (!Array.isArray(data)) {
   224	      log.debug("GitHub releases response is not an array", typeof data);
   225	      return [];
   226	    }
   227	    return data
   228	      .filter(isGitHubRelease)
   229	      .filter(
   230	        (release) =>
   231	          !(release.draft || release.prerelease) &&
   232	          release.tag_name.startsWith(source.tagPrefix)
   233	      )
   234	      .map((release) => ({
   235	        ...release,
   236	        tag_name: release.tag_name.slice(source.tagPrefix.length),
   237	      }));
   238	  } catch (error) {
   239	    log.debug("Failed to fetch recent releases from GitHub", error);
   240	    return [];
   241	  }
   242	}
   243	
   244	export async function downloadStablePatch(
   245	  url: string,
   246	  signal?: AbortSignal
   247	): Promise<Uint8Array | null> {
   248	  try {
   249	    const response = await ...

    39	  setReleaseChannel,
    40	} from "../../lib/db/release-channel.js";
    58	  readonly channel?: ReleaseChannel;
   500	          emit(`Recorded installation method: ${method}`);
   501	        }
   502	      },
   503	      warn
   504	    );
   505	  }
   506	
   507	  // 1b. Persist release channel (set by install script or upgrade command)
   508	  const channel = flags.channel;
   509	  if (channel) {
   510	    await bestEffort(
   511	      "Recording release channel",
   512	      () => {
   513	        setReleaseChannel(channel);
   514	        if (!flags.install) {
   515	          emit(`Recorded release channel: ${channel}`);
   516	        }
   517	      },
   518	      warn
   519	    );
   520	  }
   521	
   522	  // 2. Handle PATH modification
   523	  if (!flags["no-modify-path"]) {
   524	    await bestEffort(
   525	      "PATH modification",
   526	      () => handlePathModification(binaryDir, shell, env, emit),
   527	      warn
   528	    );
   529	  }
   ...

  1000	          persistChannelFn: () =>
  1001	            persistChannel(channel, channelChanged, version),
  1002	        })
  1003	    );
  1004	    // Early exit for check-only (online) and up-to-date results.
  1005	    if (resolved.kind === "done") {
  1006	      const result = resolved.result;
  1007	      // For --check with a version diff, fetch changelog before returning.
  1008	      if (
  1009	        result.action === "checked" &&
  1010	        result.currentVersion !== result.targetVersion
  1011	      ) {
  1012	        result.changelog = await startChangelogFetch({
  1013	          channel,
  1014	          currentVersion: CLI_VERSION,
  1015	          targetVersion: result.targetVersion,
  1016	          offline: false,
  1017	          source: resolved.source,
  1018	        });
  1019	      }
  1020	      return yield new CommandOutput(result);
  1021	    }
  1022	
  1023	    const { target, offline, source } = resolved;
  1024	
  1025	    // Start changelog ...

base=ec83887a16f780f32fba4b7d710bad262dba3a22 tree=110d6530e57ca4fbfb2a3f98e52013d2668b5b5e
parents=e7beceb6ba09b64dc277ae1732df04e65500062b
head=e565b1afb39a341605adc883de8812851de7d581 tree=d6c50e6e63351dd7e552c193199788fb455a5d47
parents=4a1d5bad105c006193c68459175f5eb3c7f78e08
e565b1afb39a341605adc883de8812851de7d581
c3d7791d84ebb5ad57a949129d66f9147973d239432b7695c3f1d034a1956351  -