005fd53 fix(cloudflare): default to worker, optional account id, infer prod branch
0f8720e feat(targets): add cloudflare deploy target (#843)
7a65e77 meta: Bump new development version
---BRANCH---
fix/cloudflare-target-review
---STATUS---
 M .lore.md
?? .craft-issue-842-plan.md
?? .opencode/

826 /tmp/opencode/cf-diff.txt

<path>/home/byk/Code/getsentry/craft/src/targets/cloudflare.ts</path>
<type>file</type>
<content>
1: import { join } from 'path';
2: 
3: import {
4:   GitHubGlobalConfig,
5:   TargetConfig,
6:   TypedTargetConfig,
7: } from '../schemas/project_config';
8: import { checkEnvForPrerequisite } from '../utils/env';
9: import { ConfigurationError, reportError } from '../utils/errors';
10: import { withTempDir } from '../utils/files';
11: import { isDryRun } from '../utils/helpers';
12: import { logDryRun } from '../utils/dryRun';
13: import {
14:   checkExecutableIsPresent,
15:   extractZipArchiveWithFlattening,
16:   resolveExecutable,
17:   spawnProcess,
18: } from '../utils/system';
19: import { BaseTarget } from './base';
20: import { BaseArtifactProvider } from '../artifact_providers/base';
21: 
22: /**
23:  * Secrets required to authenticate with the Cloudflare API.
24:  *
25:  * Only the API token is a true secret. ...

<path>/home/byk/Code/getsentry/craft/src/targets/__tests__/cloudflare.test.ts</path>
<type>file</type>
<content>
1: import { vi } from 'vitest';
2: 
3: import { CloudflareTarget, targetSecrets } from '../cloudflare';
4: import { NoneArtifactProvider } from '../../artifact_providers/none';
5: import * as system from '../../utils/system';
6: import { isDryRun } from '../../utils/helpers';
7: 
8: const TMP_DIR = '/tmp/craft-cloudflare-test';
9: const DEFAULT_SECRET_VALUE = 'secret_value';
10: const ACCOUNT_ID = 'acc_1234';
11: 
12: vi.mock('../../utils/helpers');
13: 
14: vi.mock('../../utils/system', async importOriginal => {
15:   const actual = await importOriginal<typeof import('../../utils/system')>();
16:   return {
17:     ...actual,
18:     checkExecutableIsPresent: vi.fn(),
19:     spawnProcess: vi.fn(async () => undefined),
20:     extractZipArchiveWithFlattening: vi.fn(async () => undefined),
21:   };
22: });
23: 
24: vi.mock('../../utils/files', async importOriginal => {
25:  ...

<path>/home/byk/Code/getsentry/craft/src/utils/errors.ts</path>
<type>file</type>
<content>
1: import { logger } from '../logger';
2: import { isDryRun } from './helpers';
3: import { captureException } from '@sentry/node';
4: 
5: /**
6:  * Custom error class that describes client configuration errors
7:  */
8: export class ConfigurationError extends Error {
9:   // We have to do the following because of: https://github.com/Microsoft/TypeScript/issues/13965
10:   // Otherwise we cannot use instanceof later to catch a given type
11:   /** Error prototype */
12:   public __proto__: Error;
13: 
14:   public constructor(message?: string) {
15:     const trueProto = new.target.prototype;
16:     super(message);
17: 
18:     this.__proto__ = trueProto;
19:   }
20: }
21: 
22: /**
23:  * Writes an error or message to "error" log if in dry-mode, throws an error
24:  * otherwise
25:  *
26:  * @param error Error object or error message
27:  * @param errorLogger Optional logger to use
28:  */
29: ...

TSC_EXIT=0

> @sentry/craft@2.27.0-dev.0 test /home/byk/Code/getsentry/craft
> vitest run src/targets/__tests__/cloudflare.test.ts


 RUN  v4.1.8 /home/byk/Code/getsentry/craft


 Test Files  1 passed (1)
      Tests  27 passed (27)
   Start at  10:47:59
   Duration  1.36s (transform 412ms, setup 0ms, import 1.14s, tests 36ms, environment 0ms)

---PRETTIER---
Checking formatting...
All matched files use Prettier code style!

---
77:export async function withTempDir<T>(
78-  callback: (arg: string) => T | Promise<T>,
79-  cleanup = true,
80-  prefix = 'craft-',
81-): Promise<T> {
82-  const directory = await mkdtemp(path.join(os.tmpdir(), prefix));
83-  try {
84-    return await callback(directory);
85-  } finally {
86-    if (cleanup) {
87-      fs.rm(directory, { recursive: true, force: true }, err => {
88-        // XXX(BYK): intentionally DO NOT await unlinking as we do not want
89-        // to block (both in terms of waiting for IO and the success of the
90-        // operation) finishing the task at hand. If unlinking fails, we honestly
91-        // don't care as this is already a temporary file and will be removed
92-        // eventually by the OS. And it doesn't make sense to wait until this op
93-        // finishes then as nothing relies on the removal of this file.
94-        if (err) {
95-          logger.trace(`Couldn't remove temp dir ${directory}:`, err);
96-        }
97-      });
98-    ...

 docs/src/content/docs/targets/cloudflare.md |  48 ++++--
 src/targets/__tests__/cloudflare.test.ts    | 242 ++++++++++++++++++++++++----
 src/targets/cloudflare.ts                   | 226 ++++++++++++++++++++++----
 3 files changed, 438 insertions(+), 78 deletions(-)

<path>/home/byk/Code/getsentry/craft/docs/src/content/docs/targets/cloudflare.md</path>
<type>file</type>
<content>
1: ---
2: title: Cloudflare
3: description: Deploy static sites or Workers to Cloudflare
4: ---
5: 
6: Deploys a release artifact to Cloudflare, either as a [Cloudflare Worker](https://developers.cloudflare.com/workers/) (optionally with static assets) or as a [Cloudflare Pages](https://developers.cloudflare.com/pages/) site.
7: 
8: The target extracts a ZIP artifact and shells out to the [`wrangler`](https://developers.cloudflare.com/workers/wrangler/) CLI to perform the deployment. `wrangler` is bundled in the Craft Docker image.
9: 
10: :::note
11: `deployType` defaults to `worker`. Cloudflare is steering new projects to Workers (with static assets) and positioning Pages as legacy, so Workers is the forward-looking default. Pages remains fully supported via `deployType: pages`. ...

 * The expansion is performed only when the entire string has the form
 * of "${...}", i.e. string "$ENV_VAR" will not be expanded.
 *
 * @param arg String to process
 * @param env Environment-like key-value mapping
 */
export function replaceEnvVariable(
  arg: string,
  env: Record<string, any>,
): string {
  if (!env || !arg || arg[0] !== '$') {
    return arg;
  }

  const argLen = arg.length;
  if (arg[1] === '{' && arg[argLen - 1] === '}') {
    const envVarKey = arg.slice(2, argLen - 1);
    return env[envVarKey] || '';
  } else {
    return arg;
  }
}

/**
 * Additional options for spawnProcess() function
 */
export interface SpawnProcessOptions {
  /** Do not buffer standard output */
  showStdout?: boolean;
  /** Force the process to run in dry-run mode */
  enableInDryRunMode?: boolean;
  /** Data to write to stdin (process will receive 'pipe' for stdin instead of 'inherit') */
  stdin?: string;
}

/**
 * Asynchronously spawns a child process
 *
 * Process arguments that ...

66 |  
67 |    test('symbol collector present and config ok', () => {
68 |      (checkExecutableIsPresent as MockedFunction<
   |       ^
69 |        typeof checkExecutableIsPresent
70 |      >) = vi.fn();

  Plugin: vite:esbuild
  File: /home/byk/Code/getsentry/craft/src/targets/__tests__/symbolCollector.test.ts

 Test Files  58 passed (58)
      Tests  1052 passed | 1 skipped (1053)
   Start at  10:49:38
   Duration  37.73s (transform 3.61s, setup 0ms, import 62.09s, tests 28.96s, environment 11ms)

---index registration---
3:import { CloudflareTarget } from './cloudflare';
27:  cloudflare: CloudflareTarget,